We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.
Total Complexity | 46 |
Total Lines | 282 |
Duplicated Lines | 0 % |
Coverage | 100% |
Changes | 0 |
Complex classes like NestedValidationException often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use NestedValidationException, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
20 | class NestedValidationException extends ValidationException implements IteratorAggregate |
||
21 | { |
||
22 | /** |
||
23 | * @var SplObjectStorage |
||
24 | */ |
||
25 | private $exceptions = []; |
||
26 | |||
27 | /** |
||
28 | * @param ValidationException $exception |
||
29 | * |
||
30 | * @return self |
||
31 | */ |
||
32 | 123 | public function addRelated(ValidationException $exception) |
|
33 | { |
||
34 | 123 | $this->getRelated()->attach($exception); |
|
35 | |||
36 | 123 | return $this; |
|
37 | } |
||
38 | |||
39 | /** |
||
40 | * @param string $path |
||
41 | * @param ValidationException $exception |
||
42 | * |
||
43 | * @return ValidationException |
||
44 | */ |
||
45 | 8 | private function getExceptionForPath($path, ValidationException $exception) |
|
46 | { |
||
47 | 8 | if ($path === $exception->guessId()) { |
|
48 | 5 | return $exception; |
|
49 | } |
||
50 | |||
51 | 6 | if (!$exception instanceof self) { |
|
52 | 2 | return $exception; |
|
53 | } |
||
54 | |||
55 | 4 | foreach ($exception as $subException) { |
|
56 | 4 | return $subException; |
|
57 | } |
||
58 | |||
59 | 1 | return $exception; |
|
60 | } |
||
61 | |||
62 | /** |
||
63 | * @param array $paths |
||
64 | * |
||
65 | * @return string[] |
||
66 | */ |
||
67 | 8 | public function findMessages(array $paths) |
|
68 | { |
||
69 | 8 | $messages = []; |
|
70 | |||
71 | 8 | foreach ($paths as $key => $value) { |
|
72 | 8 | $numericKey = is_numeric($key); |
|
73 | 8 | $path = $numericKey ? $value : $key; |
|
74 | |||
75 | 8 | if (!($exception = $this->getRelatedByName($path))) { |
|
76 | 4 | $exception = $this->findRelated($path); |
|
77 | } |
||
78 | |||
79 | 8 | $path = str_replace('.', '_', $path); |
|
80 | |||
81 | 8 | if (!$exception) { |
|
82 | 1 | $messages[$path] = ''; |
|
83 | 1 | continue; |
|
84 | } |
||
85 | |||
86 | 8 | $exception = $this->getExceptionForPath($path, $exception); |
|
87 | 8 | if (!$numericKey) { |
|
88 | 4 | $exception->setTemplate($value); |
|
89 | } |
||
90 | |||
91 | 8 | $messages[$path] = $exception->getMainMessage(); |
|
92 | } |
||
93 | |||
94 | 8 | return $messages; |
|
95 | } |
||
96 | |||
97 | /** |
||
98 | * @return Exception |
||
99 | */ |
||
100 | 5 | public function findRelated($path) |
|
111 | } |
||
112 | |||
113 | /** |
||
114 | * @return RecursiveIteratorIterator |
||
115 | */ |
||
116 | 118 | private function getRecursiveIterator() |
|
117 | { |
||
118 | 118 | $exceptionIterator = new RecursiveExceptionIterator($this); |
|
119 | 118 | $recursiveIteratorIterator = new RecursiveIteratorIterator( |
|
120 | 118 | $exceptionIterator, |
|
121 | 118 | RecursiveIteratorIterator::SELF_FIRST |
|
122 | ); |
||
123 | |||
124 | 118 | return $recursiveIteratorIterator; |
|
125 | } |
||
126 | |||
127 | /** |
||
128 | * Returns weather an exception should be omitted or not. |
||
129 | * |
||
130 | * @param ExceptionInterface $exception |
||
131 | * |
||
132 | * @return bool |
||
133 | */ |
||
134 | 112 | private function isOmissible(ExceptionInterface $exception) |
|
135 | { |
||
136 | 112 | if (!$exception instanceof self) { |
|
137 | 106 | return false; |
|
138 | } |
||
139 | |||
140 | 17 | $relatedExceptions = $exception->getRelated(); |
|
141 | 17 | $relatedExceptions->rewind(); |
|
142 | 17 | $childException = $relatedExceptions->current(); |
|
143 | |||
144 | 17 | return 1 === $relatedExceptions->count() && !$childException instanceof NonOmissibleExceptionInterface; |
|
145 | } |
||
146 | |||
147 | /** |
||
148 | * @return SplObjectStorage |
||
149 | */ |
||
150 | 113 | public function getIterator() |
|
151 | { |
||
152 | 113 | $childrenExceptions = new SplObjectStorage(); |
|
153 | |||
154 | 113 | $recursiveIteratorIterator = $this->getRecursiveIterator(); |
|
155 | 113 | $exceptionIterator = $recursiveIteratorIterator->getInnerIterator(); |
|
156 | |||
157 | 113 | $lastDepth = 0; |
|
158 | 113 | $lastDepthOriginal = 0; |
|
159 | 113 | $knownDepths = []; |
|
160 | 113 | foreach ($recursiveIteratorIterator as $childException) { |
|
161 | 112 | if ($this->isOmissible($childException)) { |
|
162 | 11 | continue; |
|
163 | } |
||
164 | |||
165 | 112 | $currentDepth = $lastDepth; |
|
166 | 112 | $currentDepthOriginal = $recursiveIteratorIterator->getDepth() + 1; |
|
167 | |||
168 | 112 | if (isset($knownDepths[$currentDepthOriginal])) { |
|
169 | 13 | $currentDepth = $knownDepths[$currentDepthOriginal]; |
|
170 | 112 | } elseif ($currentDepthOriginal > $lastDepthOriginal |
|
171 | 112 | && ($this->hasCustomTemplate() || 1 != $exceptionIterator->count())) { |
|
172 | 13 | ++$currentDepth; |
|
173 | } |
||
174 | |||
175 | 112 | if (!isset($knownDepths[$currentDepthOriginal])) { |
|
176 | 112 | $knownDepths[$currentDepthOriginal] = $currentDepth; |
|
177 | } |
||
178 | |||
179 | 112 | $lastDepth = $currentDepth; |
|
180 | 112 | $lastDepthOriginal = $currentDepthOriginal; |
|
181 | |||
182 | 112 | $childrenExceptions->attach( |
|
183 | 112 | $childException, |
|
184 | [ |
||
185 | 112 | 'depth' => $currentDepth, |
|
186 | 112 | 'depth_original' => $currentDepthOriginal, |
|
187 | 112 | 'previous_depth' => $lastDepth, |
|
188 | 112 | 'previous_depth_original' => $lastDepthOriginal, |
|
189 | ] |
||
190 | ); |
||
191 | } |
||
192 | |||
193 | 113 | return $childrenExceptions; |
|
194 | } |
||
195 | |||
196 | /** |
||
197 | * @return array |
||
198 | */ |
||
199 | 4 | public function getMessages() |
|
200 | { |
||
201 | 4 | $messages = [$this->getMessage()]; |
|
202 | 4 | foreach ($this as $exception) { |
|
203 | 4 | $messages[] = $exception->getMessage(); |
|
204 | } |
||
205 | |||
206 | 4 | if (count($messages) > 1) { |
|
207 | 4 | array_shift($messages); |
|
208 | } |
||
209 | |||
210 | 4 | return $messages; |
|
211 | } |
||
212 | |||
213 | /** |
||
214 | * @return string |
||
215 | */ |
||
216 | 106 | public function getFullMessage() |
|
217 | { |
||
218 | 106 | $marker = '-'; |
|
219 | 106 | $messages = []; |
|
220 | 106 | $exceptions = $this->getIterator(); |
|
221 | |||
222 | 106 | if ($this->hasCustomTemplate() || 1 != count($exceptions)) { |
|
223 | 11 | $messages[] = sprintf('%s %s', $marker, $this->getMessage()); |
|
224 | } |
||
225 | |||
226 | 106 | foreach ($exceptions as $exception) { |
|
227 | 105 | $depth = $exceptions[$exception]['depth']; |
|
228 | 105 | $prefix = str_repeat(' ', $depth * 2); |
|
229 | 105 | $messages[] = sprintf('%s%s %s', $prefix, $marker, $exception->getMessage()); |
|
230 | } |
||
231 | |||
232 | 106 | return implode(PHP_EOL, $messages); |
|
233 | } |
||
234 | |||
235 | /** |
||
236 | * @return SplObjectStorage |
||
237 | */ |
||
238 | 124 | public function getRelated() |
|
239 | { |
||
240 | 124 | if (!$this->exceptions instanceof SplObjectStorage) { |
|
241 | 124 | $this->exceptions = new SplObjectStorage(); |
|
242 | } |
||
243 | |||
244 | 124 | return $this->exceptions; |
|
245 | } |
||
246 | |||
247 | /** |
||
248 | * @param string $name |
||
249 | * @param mixed $value |
||
250 | * |
||
251 | * @return self |
||
252 | */ |
||
253 | 1 | public function setParam($name, $value) |
|
254 | { |
||
255 | 1 | if ('translator' === $name) { |
|
256 | 1 | foreach ($this->getRelated() as $exception) { |
|
257 | 1 | $exception->setParam($name, $value); |
|
258 | } |
||
259 | } |
||
260 | |||
261 | 1 | parent::setParam($name, $value); |
|
262 | |||
263 | 1 | return $this; |
|
264 | } |
||
265 | |||
266 | /** |
||
267 | * @return bool |
||
268 | */ |
||
269 | 9 | private function isRelated($name, ValidationException $exception) |
|
272 | } |
||
273 | |||
274 | /** |
||
275 | * @return ValidationException |
||
276 | */ |
||
277 | 9 | public function getRelatedByName($name) |
|
278 | { |
||
279 | 9 | if ($this->isRelated($name, $this)) { |
|
280 | 2 | return $this; |
|
281 | } |
||
282 | |||
283 | 9 | foreach ($this->getRecursiveIterator() as $exception) { |
|
284 | 9 | if ($this->isRelated($name, $exception)) { |
|
285 | 9 | return $exception; |
|
286 | } |
||
287 | } |
||
288 | 5 | } |
|
289 | |||
290 | /** |
||
291 | * @param array $exceptions |
||
292 | * |
||
293 | * @return self |
||
294 | */ |
||
295 | 120 | public function setRelated(array $exceptions) |
|
302 | } |
||
303 | } |
||
304 |