Respect /
Validation
We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.
| Conditions | 10 |
| Paths | 13 |
| Total Lines | 31 |
| Code Lines | 15 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 16 |
| CRAP Score | 10 |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 18 | 33 | public function validate($input): bool |
|
| 19 | { |
||
| 20 | 33 | if (!is_scalar($input)) { |
|
| 21 | 1 | return false; |
|
| 22 | } |
||
| 23 | |||
| 24 | // Code ported from jsfromhell.com |
||
| 25 | 32 | $cleanInput = preg_replace('/\D/', '', $input); |
|
| 26 | 32 | $b = [6, 5, 4, 3, 2, 9, 8, 7, 6, 5, 4, 3, 2]; |
|
| 27 | |||
| 28 | 32 | if ($cleanInput < 1) { |
|
| 29 | 1 | return false; |
|
| 30 | } |
||
| 31 | |||
| 32 | 31 | if (14 != mb_strlen($cleanInput)) { |
|
| 33 | 5 | return false; |
|
| 34 | } |
||
| 35 | |||
| 36 | 26 | for ($i = 0, $n = 0; $i < 12; $n += $cleanInput[$i] * $b[++$i]); |
|
| 37 | |||
| 38 | 26 | if ($cleanInput[12] != ((($n %= 11) < 2) ? 0 : 11 - $n)) { |
|
| 39 | 14 | return false; |
|
| 40 | } |
||
| 41 | |||
| 42 | 12 | for ($i = 0, $n = 0; $i <= 12; $n += $cleanInput[$i] * $b[$i++]); |
|
| 43 | |||
| 44 | 12 | if ($cleanInput[13] != ((($n %= 11) < 2) ? 0 : 11 - $n)) { |
|
| 45 | 1 | return false; |
|
| 46 | } |
||
| 47 | |||
| 48 | 11 | return true; |
|
| 49 | } |
||
| 51 |
