Respect /
Validation
We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.
| Conditions | 11 |
| Paths | 8 |
| Total Lines | 30 |
| Code Lines | 14 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 15 |
| CRAP Score | 11 |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 18 | 101 | public function validate($input): bool |
|
| 19 | { |
||
| 20 | 101 | if (!is_scalar($input)) { |
|
| 21 | 2 | return false; |
|
| 22 | } |
||
| 23 | |||
| 24 | // Canonicalize input |
||
| 25 | 99 | $input = preg_replace('{\D}', '', (string) $input); |
|
| 26 | |||
| 27 | // Validate length and invalid numbers |
||
| 28 | 99 | if ((11 != mb_strlen($input)) || (0 == intval($input))) { |
|
| 29 | 73 | return false; |
|
| 30 | } |
||
| 31 | |||
| 32 | // Validate check digits using a modulus 11 algorithm |
||
| 33 | 26 | for ($c = $s1 = $s2 = 0, $p = 9; $c < 9; $c++, $p--) { |
|
| 34 | 26 | $s1 += intval($input[$c]) * $p; |
|
| 35 | 26 | $s2 += intval($input[$c]) * (10 - $p); |
|
| 36 | } |
||
| 37 | |||
| 38 | 26 | if ($input[9] != (($dv1 = $s1 % 11) > 9) ? 0 : $dv1) { |
|
| 39 | 1 | return false; |
|
| 40 | } |
||
| 41 | |||
| 42 | 25 | if ($input[10] != (((($dv2 = ($s2 % 11) - (($dv1 > 9) ? 2 : 0)) < 0) |
|
| 43 | 25 | ? $dv2 + 11 : $dv2) > 9) ? 0 : $dv2) { |
|
| 44 | 1 | return false; |
|
| 45 | } |
||
| 46 | |||
| 47 | 24 | return true; |
|
| 48 | } |
||
| 50 |
