Each::__construct() - Code Metrics - Inspection of "Avoid using unset keys in IpException" - Respect/Validation - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — 1.1 (#1035)

by Henrique

created 2018-06-23 19:02 UTC

Each::__construct() A

↳ Parent: Each

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	5
ccs	4
cts	4
cp	1
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	2
crap	1

<?php

/*
 * This file is part of Respect/Validation.
 *
 * (c) Alexandre Gomes Gaigalas <[email protected]>
 *
 * For the full copyright and license information, please view the "LICENSE.md"
 * file that was distributed with this source code.
 */

namespace Respect\Validation\Rules;

use Respect\Validation\Exceptions\ValidationException;
use Respect\Validation\Validatable;

class Each extends IterableType
{
    public $itemValidator;
    public $keyValidator;

    public function __construct(Validatable $itemValidator = null, Validatable $keyValidator = null)
    {
        $this->itemValidator = $itemValidator;
        $this->keyValidator = $keyValidator;
    }

    public function assert($input)
    {
        $exceptions = [];

        if (!parent::validate($input)) {
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
            throw $this->reportError($input);
        }

        foreach ($input as $key => $item) {
            if (isset($this->itemValidator)) {
                try {
                    $this->itemValidator->assert($item);
                } catch (ValidationException $e) {
                    $exceptions[] = $e;
                }
            }

            if (isset($this->keyValidator)) {
                try {
                    $this->keyValidator->assert($key);
                } catch (ValidationException $e) {
                    $exceptions[] = $e;
                }
            }
        }

        if (!empty($exceptions)) {
            throw $this->reportError($input)->setRelated($exceptions);
        }

        return true;
    }

    public function check($input)
    {
        if (!parent::validate($input)) {
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
            throw $this->reportError($input);
        }

        foreach ($input as $key => $item) {
            if (isset($this->itemValidator)) {
                $this->itemValidator->check($item);
            }

            if (isset($this->keyValidator)) {
                $this->keyValidator->check($key);
            }
        }

        return true;
    }

    public function validate($input)
    {
        if (!parent::validate($input)) {
            return false;
        }

        foreach ($input as $key => $item) {
            if (isset($this->itemValidator) && !$this->itemValidator->validate($item)) {
                return false;
            }

            if (isset($this->keyValidator) && !$this->keyValidator->validate($key)) {
                return false;
            }
        }

        return true;
    }
}


1		<?php
2
3		/*
4		* This file is part of Respect/Validation.
5		*
6		* (c) Alexandre Gomes Gaigalas <[email protected]>
7		*
8		* For the full copyright and license information, please view the "LICENSE.md"
9		* file that was distributed with this source code.
10		*/
11
12		namespace Respect\Validation\Rules;
13
14		use Respect\Validation\Exceptions\ValidationException;
15		use Respect\Validation\Validatable;
16
17		class Each extends IterableType
18		{
19		public $itemValidator;
20		public $keyValidator;
21
22	7	public function __construct(Validatable $itemValidator = null, Validatable $keyValidator = null)
23		{
24	7	$this->itemValidator = $itemValidator;
25	7	$this->keyValidator = $keyValidator;
26	7	}
27
28	6	public function assert($input)
29		{
30	6	$exceptions = [];
31
32	6	if (!parent::validate($input)) {
		0 ignored issues – show Comprehensibility Bug introduced 2015-11-25 18:43 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`validate()` instead of `assert()`). Are you sure this is correct? If so, you might want to change this to `$this->validate()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
33	1	throw $this->reportError($input);
34		}
35
36	5	foreach ($input as $key => $item) {
37	5	if (isset($this->itemValidator)) {
38		try {
39	3	$this->itemValidator->assert($item);
40	3	} catch (ValidationException $e) {
41	1	$exceptions[] = $e;
42		}
43	3	}
44
45	5	if (isset($this->keyValidator)) {
46		try {
47	3	$this->keyValidator->assert($key);
48	3	} catch (ValidationException $e) {
49	1	$exceptions[] = $e;
50		}
51	3	}
52	5	}
53
54	5	if (!empty($exceptions)) {
55	2	throw $this->reportError($input)->setRelated($exceptions);
56		}
57
58	3	return true;
59		}
60
61	4	public function check($input)
62		{
63	4	if (!parent::validate($input)) {
		0 ignored issues – show Comprehensibility Bug introduced 2015-11-25 18:43 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`validate()` instead of `check()`). Are you sure this is correct? If so, you might want to change this to `$this->validate()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
64	1	throw $this->reportError($input);
65		}
66
67	3	foreach ($input as $key => $item) {
68	3	if (isset($this->itemValidator)) {
69	2	$this->itemValidator->check($item);
70	2	}
71
72	3	if (isset($this->keyValidator)) {
73	2	$this->keyValidator->check($key);
74	2	}
75	3	}
76
77	3	return true;
78		}
79
80	11	public function validate($input)
81		{
82	11	if (!parent::validate($input)) {
83	4	return false;
84		}
85
86	7	foreach ($input as $key => $item) {
87	7	if (isset($this->itemValidator) && !$this->itemValidator->validate($item)) {
88	1	return false;
89		}
90
91	6	if (isset($this->keyValidator) && !$this->keyValidator->validate($key)) {
92	1	return false;
93		}
94	5	}
95
96	5	return true;
97		}
98		}
99

Respect / Validation

Scrutinizer GitHub App not installed

Pull Request — 1.1 (#1035)

Each::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like