AbstractCreditCardBrand::validate() - Code Metrics - Inspection of "fix issue #650" - Respect/Validation - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#651)

by Reginaldo

created 2016-03-17 00:13 UTC

AbstractCreditCardBrand::validate() A

↳ Parent: AbstractCreditCardBrand

Complexity

Conditions	2
Paths	2

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	6
ccs	0
cts	3
cp	0
rs	9.4285
cc	2
eloc	3
nc	2
nop	1
crap	6

<?php

/*
 * This file is part of Respect/Validation.
 *
 * (c) Alexandre Gomes Gaigalas <[email protected]>
 *
 * For the full copyright and license information, please view the "LICENSE.md"
 * file that was distributed with this source code.
 */

namespace Respect\Validation\Rules;

abstract class AbstractCreditCardBrand extends CreditCard
{
    protected $pattern;

    private function verifyIfCardIsBrand($input)
    {
        return (preg_match($this->pattern, $input) > 0);
    }

    public function validate($input)
    {
        $input = preg_replace('([^0-9])', '', $input);

        return parent::verifyMod10($input) && $this->verifyIfCardIsBrand($input);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

}


1			<?php
2
3			/*
4			* This file is part of Respect/Validation.
5			*
6			* (c) Alexandre Gomes Gaigalas <[email protected]>
7			*
8			* For the full copyright and license information, please view the "LICENSE.md"
9			* file that was distributed with this source code.
10			*/
11
12			namespace Respect\Validation\Rules;
13
14			abstract class AbstractCreditCardBrand extends CreditCard
15			{
16			protected $pattern;
17
18			private function verifyIfCardIsBrand($input)
19			{
20			return (preg_match($this->pattern, $input) > 0);
21			}
22
23			public function validate($input)
24			{
25			$input = preg_replace('([^0-9])', '', $input);
26
27			return parent::verifyMod10($input) && $this->verifyIfCardIsBrand($input);
			0 ignored issues – show Comprehensibility Bug introduced 2016-03-17 00:20 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`verifyMod10()` instead of `validate()`). Are you sure this is correct? If so, you might want to change this to `$this->verifyMod10()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
28			}
29
30			}
31

Respect / Validation

Scrutinizer GitHub App not installed

Pull Request — master (#651)

AbstractCreditCardBrand::validate() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like