Factor::__construct() - Code Metrics - Inspection of "Remove method "validate()" to "isValid()"" - Respect/Validation - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#1087)

by Henrique

created 2018-09-03 10:45 UTC

Factor::__construct() A

↳ Parent: Factor

Complexity

Conditions	3
Paths	2

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	3

Importance

Changes

Metric	Value
eloc	4
dl	0
loc	8
c	0
b	0
f	0
ccs	5
cts	5
cp	1
rs	10
cc	3
nc	2
nop	1
crap	3

<?php

/*
 * This file is part of Respect/Validation.
 *
 * (c) Alexandre Gomes Gaigalas <[email protected]>
 *
 * For the full copyright and license information, please view the "LICENSE.md"
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace Respect\Validation\Rules;

use Respect\Validation\Exceptions\ComponentException;
use function Respect\Stringifier\stringify;

/**
 * @author David Meister <[email protected]>
 */
class Factor extends AbstractRule
{
    public $dividend;

    public function __construct($dividend)
    {
        if (!is_numeric($dividend) || (int) $dividend != $dividend) {
            $message = 'Dividend %s must be an integer';
            throw new ComponentException(sprintf($message, stringify($dividend)));
        }

        $this->dividend = (int) $dividend;
    }

    public function isValid($input): bool
    {
        // Every integer is a factor of zero, and zero is the only integer that
        // has zero for a factor.
        if (0 === $this->dividend) {
            return true;
        }

        // Factors must be integers that are not zero.
        if (!is_numeric($input) || (int) $input != $input || 0 == $input) {
            return false;
        }

        $input = (int) abs($input);
        $dividend = (int) abs($this->dividend);

        // The dividend divided by the input must be an integer if input is a
        // factor of the dividend.
        return is_integer($dividend / $input);
    }
}


1		<?php
2
3		/*
4		* This file is part of Respect/Validation.
5		*
6		* (c) Alexandre Gomes Gaigalas <[email protected]>
7		*
8		* For the full copyright and license information, please view the "LICENSE.md"
9		* file that was distributed with this source code.
10		*/
11
12		declare(strict_types=1);
13
14		namespace Respect\Validation\Rules;
15
16		use Respect\Validation\Exceptions\ComponentException;
17		use function Respect\Stringifier\stringify;
18
19		/**
20		* @author David Meister <[email protected]>
21		*/
22		class Factor extends AbstractRule
23		{
24		public $dividend;
25
26	321	public function __construct($dividend)
27		{
28	321	if (!is_numeric($dividend) \|\| (int) $dividend != $dividend) {
29	17	$message = 'Dividend %s must be an integer';
30	17	throw new ComponentException(sprintf($message, stringify($dividend)));
31		}
32
33	304	$this->dividend = (int) $dividend;
34	304	}
35
36	304	public function isValid($input): bool
37		{
38		// Every integer is a factor of zero, and zero is the only integer that
39		// has zero for a factor.
40	304	if (0 === $this->dividend) {
41	36	return true;
42		}
43
44		// Factors must be integers that are not zero.
45	268	if (!is_numeric($input) \|\| (int) $input != $input \|\| 0 == $input) {
46	40	return false;
47		}
48
49	228	$input = (int) abs($input);
50	228	$dividend = (int) abs($this->dividend);
51
52		// The dividend divided by the input must be an integer if input is a
53		// factor of the dividend.
54	228	return is_integer($dividend / $input);
55		}
56		}
57

Respect / Validation

Scrutinizer GitHub App not installed

Pull Request — master (#1087)

Factor::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like