Email::validate() - Code Metrics - Inspection of "Make sure that "Email" only validates strings" - Respect/Validation - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 1.1 ( 5a067f...c9850f )

by Henrique

created 2018-10-09 03:47 UTC

Email::validate() A

↳ Parent: Email

Complexity

Conditions	4
Paths	4

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	4.0218

Importance

Changes

Metric	Value
dl	0
loc	17
ccs	8
cts	9
cp	0.8889
rs	9.7
c	0
b	0
f	0
cc	4
nc	4
nop	1
crap	4.0218

<?php

/*
 * This file is part of Respect/Validation.
 *
 * (c) Alexandre Gomes Gaigalas <[email protected]>
 *
 * For the full copyright and license information, please view the "LICENSE.md"
 * file that was distributed with this source code.
 */

namespace Respect\Validation\Rules;

use Egulias\EmailValidator\EmailValidator;
use Egulias\EmailValidator\Validation\RFCValidation;

class Email extends AbstractRule
{
    public function __construct(EmailValidator $emailValidator = null)
    {
        $this->emailValidator = $emailValidator;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    public function getEmailValidator()
    {
        if (!$this->emailValidator instanceof EmailValidator
            && class_exists('Egulias\\EmailValidator\\EmailValidator')) {
            $this->emailValidator = new EmailValidator();
        }

        return $this->emailValidator;
    }

    public function validate($input)
    {
        if (!is_string($input)) {
            return false;
        }

        $emailValidator = $this->getEmailValidator();
        if (!$emailValidator instanceof EmailValidator) {
            return (bool) filter_var($input, FILTER_VALIDATE_EMAIL);
        }

        if (!class_exists('Egulias\\EmailValidator\\Validation\\RFCValidation')) {
            return $emailValidator->isValid($input);

        }

        return $emailValidator->isValid($input, new RFCValidation());
    }
}


1		<?php
2
3		/*
4		* This file is part of Respect/Validation.
5		*
6		* (c) Alexandre Gomes Gaigalas <[email protected]>
7		*
8		* For the full copyright and license information, please view the "LICENSE.md"
9		* file that was distributed with this source code.
10		*/
11
12		namespace Respect\Validation\Rules;
13
14		use Egulias\EmailValidator\EmailValidator;
15		use Egulias\EmailValidator\Validation\RFCValidation;
16
17		class Email extends AbstractRule
18		{
19	23	public function __construct(EmailValidator $emailValidator = null)
20		{
21	23	$this->emailValidator = $emailValidator;
		0 ignored issues – show Bug introduced 2015-11-25 18:43 UTC by Report Bug Copy Issue Report The property `emailValidator` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
22	23	}
23
24	19	public function getEmailValidator()
25		{
26	19	if (!$this->emailValidator instanceof EmailValidator
27	19	&& class_exists('Egulias\\EmailValidator\\EmailValidator')) {
28	1	$this->emailValidator = new EmailValidator();
29	1	}
30
31	19	return $this->emailValidator;
32		}
33
34	21	public function validate($input)
35		{
36	21	if (!is_string($input)) {
37	4	return false;
38		}
39
40	17	$emailValidator = $this->getEmailValidator();
41	17	if (!$emailValidator instanceof EmailValidator) {
42	16	return (bool) filter_var($input, FILTER_VALIDATE_EMAIL);
43		}
44
45	1	if (!class_exists('Egulias\\EmailValidator\\Validation\\RFCValidation')) {
46		return $emailValidator->isValid($input);
		0 ignored issues – show Bug introduced 2016-10-29 13:13 UTC by Report Bug Copy Issue Report The call to `isValid()` misses a required argument `$emailValidation`. This check looks for function calls that miss required arguments. Loading history...
47		}
48
49	1	return $emailValidator->isValid($input, new RFCValidation());
50		}
51		}
52

Respect / Validation

Scrutinizer GitHub App not installed

Push — 1.1 ( 5a067f...c9850f )

Email::validate() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like