We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.
Complex classes like NestedValidationException often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use NestedValidationException, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
18 | class NestedValidationException extends ValidationException implements IteratorAggregate |
||
19 | { |
||
20 | /** |
||
21 | * @var SplObjectStorage |
||
22 | */ |
||
23 | private $exceptions = []; |
||
24 | |||
25 | /** |
||
26 | * @param ValidationException $exception |
||
27 | * |
||
28 | * @return self |
||
29 | */ |
||
30 | 3 | public function addRelated(ValidationException $exception) |
|
36 | |||
37 | /** |
||
38 | * @param string $path |
||
39 | * @param ValidationException $exception |
||
40 | * |
||
41 | * @return ValidationException |
||
42 | */ |
||
43 | private function getExceptionForPath($path, ValidationException $exception) |
||
44 | { |
||
45 | if ($path === $exception->guessId()) { |
||
46 | return $exception; |
||
47 | } |
||
48 | |||
49 | if (!$exception instanceof self) { |
||
50 | return $exception; |
||
51 | } |
||
52 | |||
53 | foreach ($exception as $subException) { |
||
54 | return $subException; |
||
55 | } |
||
56 | |||
57 | return $exception; |
||
58 | } |
||
59 | |||
60 | /** |
||
61 | * @param array $paths |
||
62 | * |
||
63 | * @return string[] |
||
64 | */ |
||
65 | public function findMessages(array $paths) |
||
66 | { |
||
67 | $messages = []; |
||
68 | |||
69 | foreach ($paths as $key => $value) { |
||
70 | $numericKey = is_numeric($key); |
||
71 | $path = $numericKey ? $value : $key; |
||
72 | |||
73 | if (!($exception = $this->getRelatedByName($path))) { |
||
74 | $exception = $this->findRelated($path); |
||
75 | } |
||
76 | |||
77 | $path = str_replace('.', '_', $path); |
||
78 | |||
79 | if (!$exception) { |
||
80 | $messages[$path] = ''; |
||
81 | continue; |
||
82 | } |
||
83 | |||
84 | $exception = $this->getExceptionForPath($path, $exception); |
||
85 | if (!$numericKey) { |
||
86 | $exception->setTemplate($value); |
||
87 | } |
||
88 | |||
89 | $messages[$path] = $exception->getMainMessage(); |
||
90 | } |
||
91 | |||
92 | return $messages; |
||
93 | } |
||
94 | |||
95 | /** |
||
96 | * @return Exception |
||
97 | */ |
||
98 | 1 | public function findRelated($path) |
|
110 | |||
111 | /** |
||
112 | * @return RecursiveIteratorIterator |
||
113 | */ |
||
114 | 1 | private function getRecursiveIterator() |
|
124 | |||
125 | /** |
||
126 | * Returns weather an exception should be omitted or not. |
||
127 | * |
||
128 | * @param ExceptionInterface $exception |
||
129 | * |
||
130 | * @return bool |
||
131 | */ |
||
132 | private function isOmissible(ExceptionInterface $exception) |
||
144 | |||
145 | /** |
||
146 | * @return SplObjectStorage |
||
147 | */ |
||
148 | public function getIterator() |
||
149 | { |
||
150 | $childrenExceptions = new SplObjectStorage(); |
||
151 | |||
152 | $recursiveIteratorIterator = $this->getRecursiveIterator(); |
||
153 | $exceptionIterator = $recursiveIteratorIterator->getInnerIterator(); |
||
154 | |||
155 | $lastDepth = 0; |
||
156 | $lastDepthOriginal = 0; |
||
157 | $knownDepths = []; |
||
158 | foreach ($recursiveIteratorIterator as $childException) { |
||
159 | if ($this->isOmissible($childException)) { |
||
160 | continue; |
||
161 | } |
||
162 | |||
163 | $currentDepth = $lastDepth; |
||
164 | $currentDepthOriginal = $recursiveIteratorIterator->getDepth() + 1; |
||
165 | |||
166 | if (isset($knownDepths[$currentDepthOriginal])) { |
||
167 | $currentDepth = $knownDepths[$currentDepthOriginal]; |
||
168 | } elseif ($currentDepthOriginal > $lastDepthOriginal |
||
169 | && ($this->hasCustomTemplate() || $exceptionIterator->count() != 1)) { |
||
170 | ++$currentDepth; |
||
171 | } |
||
172 | |||
173 | if (!isset($knownDepths[$currentDepthOriginal])) { |
||
174 | $knownDepths[$currentDepthOriginal] = $currentDepth; |
||
175 | } |
||
176 | |||
177 | $lastDepth = $currentDepth; |
||
178 | $lastDepthOriginal = $currentDepthOriginal; |
||
179 | |||
180 | $childrenExceptions->attach( |
||
181 | $childException, |
||
182 | [ |
||
183 | 'depth' => $currentDepth, |
||
184 | 'depth_original' => $currentDepthOriginal, |
||
185 | 'previous_depth' => $lastDepth, |
||
186 | 'previous_depth_original' => $lastDepthOriginal, |
||
187 | ] |
||
188 | ); |
||
189 | } |
||
190 | |||
191 | return $childrenExceptions; |
||
192 | } |
||
193 | |||
194 | /** |
||
195 | * @return array |
||
196 | */ |
||
197 | public function getMessages() |
||
210 | |||
211 | /** |
||
212 | * @return string |
||
213 | */ |
||
214 | public function getFullMessage() |
||
232 | |||
233 | /** |
||
234 | * @return SplObjectStorage |
||
235 | */ |
||
236 | 3 | public function getRelated() |
|
244 | |||
245 | /** |
||
246 | * @param string $name |
||
247 | * @param mixed $value |
||
248 | * |
||
249 | * @return self |
||
250 | */ |
||
251 | public function setParam($name, $value) |
||
263 | |||
264 | /** |
||
265 | * @return bool |
||
266 | */ |
||
267 | 1 | private function isRelated($name, ValidationException $exception) |
|
271 | |||
272 | /** |
||
273 | * @return ValidationException |
||
274 | */ |
||
275 | 1 | public function getRelatedByName($name) |
|
287 | |||
288 | /** |
||
289 | * @param array $exceptions |
||
290 | * |
||
291 | * @return self |
||
292 | */ |
||
293 | public function setRelated(array $exceptions) |
||
301 | } |
||
302 |