Scrutinizer GitHub App not installed

We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.

Install GitHub App

Completed
Pull Request — master (#838)
by Jens
04:03
created

NestedValidationException   B

Complexity

Total Complexity 46

Size/Duplication

Total Lines 284
Duplicated Lines 0 %

Coupling/Cohesion

Components 1
Dependencies 2

Test Coverage

Coverage 24.14%

Importance

Changes 0
Metric Value
wmc 46
lcom 1
cbo 2
dl 0
loc 284
ccs 28
cts 116
cp 0.2414
rs 8.3999
c 0
b 0
f 0

14 Methods

Rating   Name   Duplication   Size   Complexity  
A addRelated() 0 6 1
A findRelated() 0 12 3
A getRecursiveIterator() 0 10 1
A getExceptionForPath() 0 16 4
B findMessages() 0 29 6
A isOmissible() 0 12 3
A getMessages() 0 13 3
A getFullMessage() 0 18 4
A getRelated() 0 8 2
A setParam() 0 12 3
A isRelated() 0 4 2
A getRelatedByName() 0 12 4
A setRelated() 0 8 2
C getIterator() 0 45 8

How to fix   Complexity   

Complex Class

Complex classes like NestedValidationException often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use NestedValidationException, and based on these observations, apply Extract Interface, too.

1
<?php
2
3
/*
4
 * This file is part of Respect/Validation.
5
 *
6
 * (c) Alexandre Gomes Gaigalas <[email protected]>
7
 *
8
 * For the full copyright and license information, please view the "LICENSE.md"
9
 * file that was distributed with this source code.
10
 */
11
12
namespace Respect\Validation\Exceptions;
13
14
use IteratorAggregate;
15
use RecursiveIteratorIterator;
16
use SplObjectStorage;
17
18
class NestedValidationException extends ValidationException implements IteratorAggregate
19
{
20
    /**
21
     * @var SplObjectStorage
22
     */
23
    private $exceptions = [];
24
25
    /**
26
     * @param ValidationException $exception
27
     *
28
     * @return self
29
     */
30 3
    public function addRelated(ValidationException $exception)
31
    {
32 3
        $this->getRelated()->attach($exception);
33
34 3
        return $this;
35
    }
36
37
    /**
38
     * @param string              $path
39
     * @param ValidationException $exception
40
     *
41
     * @return ValidationException
42
     */
43
    private function getExceptionForPath($path, ValidationException $exception)
44
    {
45
        if ($path === $exception->guessId()) {
46
            return $exception;
47
        }
48
49
        if (!$exception instanceof self) {
50
            return $exception;
51
        }
52
53
        foreach ($exception as $subException) {
54
            return $subException;
55
        }
56
57
        return $exception;
58
    }
59
60
    /**
61
     * @param array $paths
62
     *
63
     * @return string[]
64
     */
65
    public function findMessages(array $paths)
66
    {
67
        $messages = [];
68
69
        foreach ($paths as $key => $value) {
70
            $numericKey = is_numeric($key);
71
            $path = $numericKey ? $value : $key;
72
73
            if (!($exception = $this->getRelatedByName($path))) {
74
                $exception = $this->findRelated($path);
75
            }
76
77
            $path = str_replace('.', '_', $path);
78
79
            if (!$exception) {
80
                $messages[$path] = '';
81
                continue;
82
            }
83
84
            $exception = $this->getExceptionForPath($path, $exception);
85
            if (!$numericKey) {
86
                $exception->setTemplate($value);
87
            }
88
89
            $messages[$path] = $exception->getMainMessage();
90
        }
91
92
        return $messages;
93
    }
94
95
    /**
96
     * @return Exception
97
     */
98 1
    public function findRelated($path)
99
    {
100 1
        $target = $this;
101 1
        $pieces = explode('.', $path);
102
103 1
        while (!empty($pieces) && $target) {
104 1
            $piece = array_shift($pieces);
105 1
            $target = $target->getRelatedByName($piece);
106
        }
107
108 1
        return $target;
109
    }
110
111
    /**
112
     * @return RecursiveIteratorIterator
113
     */
114 1
    private function getRecursiveIterator()
115
    {
116 1
        $exceptionIterator = new RecursiveExceptionIterator($this);
117 1
        $recursiveIteratorIterator = new RecursiveIteratorIterator(
118 1
            $exceptionIterator,
119 1
            RecursiveIteratorIterator::SELF_FIRST
120
        );
121
122 1
        return $recursiveIteratorIterator;
123
    }
124
125
    /**
126
     * Returns weather an exception should be omitted or not.
127
     *
128
     * @param ExceptionInterface $exception
129
     *
130
     * @return bool
131
     */
132
    private function isOmissible(ExceptionInterface $exception)
133
    {
134
        if (!$exception instanceof self) {
135
            return false;
136
        }
137
138
        $relatedExceptions = $exception->getRelated();
139
        $relatedExceptions->rewind();
140
        $childException = $relatedExceptions->current();
141
142
        return $relatedExceptions->count() === 1 && !$childException instanceof NonOmissibleExceptionInterface;
143
    }
144
145
    /**
146
     * @return SplObjectStorage
147
     */
148
    public function getIterator()
149
    {
150
        $childrenExceptions = new SplObjectStorage();
151
152
        $recursiveIteratorIterator = $this->getRecursiveIterator();
153
        $exceptionIterator = $recursiveIteratorIterator->getInnerIterator();
154
155
        $lastDepth = 0;
156
        $lastDepthOriginal = 0;
157
        $knownDepths = [];
158
        foreach ($recursiveIteratorIterator as $childException) {
159
            if ($this->isOmissible($childException)) {
160
                continue;
161
            }
162
163
            $currentDepth = $lastDepth;
164
            $currentDepthOriginal = $recursiveIteratorIterator->getDepth() + 1;
165
166
            if (isset($knownDepths[$currentDepthOriginal])) {
167
                $currentDepth = $knownDepths[$currentDepthOriginal];
168
            } elseif ($currentDepthOriginal > $lastDepthOriginal
169
                && ($this->hasCustomTemplate() || $exceptionIterator->count() != 1)) {
170
                ++$currentDepth;
171
            }
172
173
            if (!isset($knownDepths[$currentDepthOriginal])) {
174
                $knownDepths[$currentDepthOriginal] = $currentDepth;
175
            }
176
177
            $lastDepth = $currentDepth;
178
            $lastDepthOriginal = $currentDepthOriginal;
179
180
            $childrenExceptions->attach(
181
                $childException,
182
                [
183
                    'depth' => $currentDepth,
184
                    'depth_original' => $currentDepthOriginal,
185
                    'previous_depth' => $lastDepth,
186
                    'previous_depth_original' => $lastDepthOriginal,
187
                ]
188
            );
189
        }
190
191
        return $childrenExceptions;
192
    }
193
194
    /**
195
     * @return array
196
     */
197
    public function getMessages()
198
    {
199
        $messages = [$this->getMessage()];
200
        foreach ($this as $exception) {
201
            $messages[] = $exception->getMessage();
202
        }
203
204
        if (count($messages) > 1) {
205
            array_shift($messages);
206
        }
207
208
        return $messages;
209
    }
210
211
    /**
212
     * @return string
213
     */
214
    public function getFullMessage()
215
    {
216
        $marker = '-';
217
        $messages = [];
218
        $exceptions = $this->getIterator();
219
220
        if ($this->hasCustomTemplate() || count($exceptions) != 1) {
221
            $messages[] = sprintf('%s %s', $marker, $this->getMessage());
222
        }
223
224
        foreach ($exceptions as $exception) {
225
            $depth = $exceptions[$exception]['depth'];
226
            $prefix = str_repeat(' ', $depth * 2);
227
            $messages[] = sprintf('%s%s %s', $prefix, $marker, $exception->getMessage());
228
        }
229
230
        return implode(PHP_EOL, $messages);
231
    }
232
233
    /**
234
     * @return SplObjectStorage
235
     */
236 3
    public function getRelated()
237
    {
238 3
        if (!$this->exceptions instanceof SplObjectStorage) {
239 3
            $this->exceptions = new SplObjectStorage();
240
        }
241
242 3
        return $this->exceptions;
243
    }
244
245
    /**
246
     * @param string $name
247
     * @param mixed  $value
248
     *
249
     * @return self
250
     */
251
    public function setParam($name, $value)
252
    {
253
        if ('translator' === $name) {
254
            foreach ($this->getRelated() as $exception) {
255
                $exception->setParam($name, $value);
256
            }
257
        }
258
259
        parent::setParam($name, $value);
260
261
        return $this;
262
    }
263
264
    /**
265
     * @return bool
266
     */
267 1
    private function isRelated($name, ValidationException $exception)
268
    {
269 1
        return $exception->getId() === $name || $exception->getName() === $name;
270
    }
271
272
    /**
273
     * @return ValidationException
274
     */
275 1
    public function getRelatedByName($name)
276
    {
277 1
        if ($this->isRelated($name, $this)) {
278
            return $this;
279
        }
280
281 1
        foreach ($this->getRecursiveIterator() as $exception) {
282 1
            if ($this->isRelated($name, $exception)) {
283 1
                return $exception;
284
            }
285
        }
286 1
    }
287
288
    /**
289
     * @param array $exceptions
290
     *
291
     * @return self
292
     */
293
    public function setRelated(array $exceptions)
294
    {
295
        foreach ($exceptions as $exception) {
296
            $this->addRelated($exception);
297
        }
298
299
        return $this;
300
    }
301
}
302