We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.
Complex classes like NestedValidationException often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use NestedValidationException, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
18 | class NestedValidationException extends ValidationException implements IteratorAggregate |
||
19 | { |
||
20 | /** |
||
21 | * @var SplObjectStorage |
||
22 | */ |
||
23 | private $exceptions = []; |
||
24 | |||
25 | /** |
||
26 | * @param ValidationException $exception |
||
27 | * |
||
28 | * @return self |
||
29 | */ |
||
30 | 3 | public function addRelated(ValidationException $exception) |
|
36 | |||
37 | /** |
||
38 | * @param string $path |
||
39 | * @param ValidationException $exception |
||
40 | * |
||
41 | * @return ValidationException |
||
42 | */ |
||
43 | private function getExceptionForPath($path, ValidationException $exception) |
||
59 | |||
60 | /** |
||
61 | * @param array $paths |
||
62 | * |
||
63 | * @return array |
||
64 | */ |
||
65 | public function findMessages(array $paths) |
||
94 | |||
95 | /** |
||
96 | * @return Exception |
||
97 | */ |
||
98 | 1 | public function findRelated($path) |
|
110 | |||
111 | /** |
||
112 | * @return RecursiveIteratorIterator |
||
113 | */ |
||
114 | 1 | private function getRecursiveIterator() |
|
124 | |||
125 | private function isSkippable(ValidationException $exception) |
||
141 | |||
142 | private function hasChildTemplate(self $exception) |
||
149 | |||
150 | /** |
||
151 | * @return SplObjectStorage |
||
152 | */ |
||
153 | public function getIterator() |
||
197 | |||
198 | /** |
||
199 | * @return array |
||
200 | */ |
||
201 | public function getMessages() |
||
214 | |||
215 | /** |
||
216 | * @return string |
||
217 | */ |
||
218 | public function getFullMessage() |
||
239 | |||
240 | /** |
||
241 | * @return SplObjectStorage |
||
242 | */ |
||
243 | 3 | public function getRelated() |
|
251 | |||
252 | /** |
||
253 | * @param string $name |
||
254 | * @param mixed $value |
||
255 | * |
||
256 | * @return self |
||
257 | */ |
||
258 | public function setParam($name, $value) |
||
270 | |||
271 | /** |
||
272 | * @return bool |
||
273 | */ |
||
274 | 1 | private function isRelated($name, ValidationException $exception) |
|
278 | |||
279 | /** |
||
280 | * @return ValidationException |
||
281 | */ |
||
282 | 1 | public function getRelatedByName($name) |
|
294 | |||
295 | /** |
||
296 | * @param array $exceptions |
||
297 | * |
||
298 | * @return self |
||
299 | */ |
||
300 | public function setRelated(array $exceptions) |
||
308 | } |
||
309 |
It seems like the type of the argument is not accepted by the function/method which you are calling.
In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.
We suggest to add an explicit type cast like in the following example: