Factor::__construct() - Code Metrics - Inspection of "Do not consider any float as integer" - Respect/Validation - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — 1.1 (#1036)

by Henrique

created 2018-06-23 19:14 UTC

Factor::__construct() A

↳ Parent: Factor

Complexity

Conditions	3
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	3

Importance

Changes

Metric	Value
dl	0
loc	9
ccs	6
cts	6
cp	1
rs	9.9666
c	0
b	0
f	0
cc	3
nc	2
nop	1
crap	3

<?php

/*
 * This file is part of Respect/Validation.
 *
 * (c) Alexandre Gomes Gaigalas <[email protected]>
 *
 * For the full copyright and license information, please view the "LICENSE.md"
 * file that was distributed with this source code.
 */

namespace Respect\Validation\Rules;

use Respect\Validation\Exceptions\ComponentException;
use Respect\Validation\Exceptions\ValidationException;

/**
 * @author David Meister <[email protected]>
 */
class Factor extends AbstractRule
{
    public $dividend;

    public function __construct($dividend)
    {
        if (!is_numeric($dividend) || (int) $dividend != $dividend) {
            $message = 'Dividend %s must be an integer';
            throw new ComponentException(sprintf($message, ValidationException::stringify($dividend)));
        }

        $this->dividend = (int) $dividend;
    }

    public function validate($input)
    {
        // Every integer is a factor of zero, and zero is the only integer that
        // has zero for a factor.
        if ($this->dividend === 0) {
            return true;
        }

        // Factors must be integers that are not zero.
        if (!is_numeric($input) || (int) $input != $input || $input == 0) {
            return false;
        }

        $input = (int) abs($input);
        $dividend = (int) abs($this->dividend);

        // The dividend divided by the input must be an integer if input is a
        // factor of the dividend.
        return is_integer($dividend / $input);
    }
}


1		<?php
2
3		/*
4		* This file is part of Respect/Validation.
5		*
6		* (c) Alexandre Gomes Gaigalas <[email protected]>
7		*
8		* For the full copyright and license information, please view the "LICENSE.md"
9		* file that was distributed with this source code.
10		*/
11
12		namespace Respect\Validation\Rules;
13
14		use Respect\Validation\Exceptions\ComponentException;
15		use Respect\Validation\Exceptions\ValidationException;
16
17		/**
18		* @author David Meister <[email protected]>
19		*/
20		class Factor extends AbstractRule
21		{
22		public $dividend;
23
24	321	public function __construct($dividend)
25		{
26	321	if (!is_numeric($dividend) \|\| (int) $dividend != $dividend) {
27	17	$message = 'Dividend %s must be an integer';
28	17	throw new ComponentException(sprintf($message, ValidationException::stringify($dividend)));
29		}
30
31	304	$this->dividend = (int) $dividend;
32	304	}
33
34	304	public function validate($input)
35		{
36		// Every integer is a factor of zero, and zero is the only integer that
37		// has zero for a factor.
38	304	if ($this->dividend === 0) {
39	36	return true;
40		}
41
42		// Factors must be integers that are not zero.
43	268	if (!is_numeric($input) \|\| (int) $input != $input \|\| $input == 0) {
44	40	return false;
45		}
46
47	228	$input = (int) abs($input);
48	228	$dividend = (int) abs($this->dividend);
49
50		// The dividend divided by the input must be an integer if input is a
51		// factor of the dividend.
52	228	return is_integer($dividend / $input);
53		}
54		}
55

Respect / Validation

Scrutinizer GitHub App not installed

Pull Request — 1.1 (#1036)

Factor::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like