We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.
Complex classes like NestedValidationException often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use NestedValidationException, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
18 | class NestedValidationException extends ValidationException implements IteratorAggregate |
||
19 | { |
||
20 | /** |
||
21 | * @var SplObjectStorage |
||
22 | */ |
||
23 | private $exceptions = []; |
||
24 | |||
25 | /** |
||
26 | * @param ValidationException $exception |
||
27 | * |
||
28 | * @return self |
||
29 | */ |
||
30 | 3 | public function addRelated(ValidationException $exception) |
|
36 | |||
37 | /** |
||
38 | * @param string $path |
||
39 | * @param ValidationException $exception |
||
40 | * |
||
41 | * @return ValidationException |
||
42 | */ |
||
43 | private function getExceptionForPath($path, ValidationException $exception) |
||
44 | { |
||
45 | if ($path === $exception->guessId()) { |
||
46 | return $exception; |
||
47 | } |
||
48 | |||
49 | if (!$exception instanceof self) { |
||
50 | return $exception; |
||
51 | } |
||
52 | |||
53 | foreach ($exception as $subException) { |
||
54 | return $subException; |
||
55 | } |
||
56 | |||
57 | return $exception; |
||
58 | } |
||
59 | |||
60 | /** |
||
61 | * @param array $paths |
||
62 | * |
||
63 | * @return string[] |
||
64 | */ |
||
65 | public function findMessages(array $paths) |
||
66 | { |
||
67 | $messages = []; |
||
68 | |||
69 | foreach ($paths as $key => $value) { |
||
70 | $numericKey = is_numeric($key); |
||
71 | $path = $numericKey ? $value : $key; |
||
72 | |||
73 | if (!($exception = $this->getRelatedByName($path))) { |
||
74 | $exception = $this->findRelated($path); |
||
75 | } |
||
76 | |||
77 | $path = str_replace('.', '_', $path); |
||
78 | |||
79 | if (!$exception) { |
||
80 | $messages[$path] = ''; |
||
81 | continue; |
||
82 | } |
||
83 | |||
84 | $exception = $this->getExceptionForPath($path, $exception); |
||
85 | if (!$numericKey) { |
||
86 | $exception->setTemplate($value); |
||
87 | } |
||
88 | |||
89 | $messages[$path] = $exception->getMainMessage(); |
||
90 | } |
||
91 | |||
92 | return $messages; |
||
93 | } |
||
94 | |||
95 | /** |
||
96 | * @return Exception |
||
97 | */ |
||
98 | 1 | public function findRelated($path) |
|
110 | |||
111 | /** |
||
112 | * @return RecursiveIteratorIterator |
||
113 | */ |
||
114 | 1 | private function getRecursiveIterator() |
|
124 | |||
125 | /** |
||
126 | * @return SplObjectStorage |
||
127 | */ |
||
128 | public function getIterator() |
||
174 | |||
175 | /** |
||
176 | * @return array |
||
177 | */ |
||
178 | public function getMessages() |
||
191 | |||
192 | /** |
||
193 | * @return string |
||
194 | */ |
||
195 | public function getFullMessage() |
||
213 | |||
214 | /** |
||
215 | * @return SplObjectStorage |
||
216 | */ |
||
217 | 3 | public function getRelated() |
|
225 | |||
226 | /** |
||
227 | * @param string $name |
||
228 | * @param mixed $value |
||
229 | * |
||
230 | * @return self |
||
231 | */ |
||
232 | public function setParam($name, $value) |
||
244 | |||
245 | /** |
||
246 | * @return bool |
||
247 | */ |
||
248 | 1 | private function isRelated($name, ValidationException $exception) |
|
252 | |||
253 | /** |
||
254 | * @return ValidationException |
||
255 | */ |
||
256 | 1 | public function getRelatedByName($name) |
|
268 | |||
269 | /** |
||
270 | * @param array $exceptions |
||
271 | * |
||
272 | * @return self |
||
273 | */ |
||
274 | public function setRelated(array $exceptions) |
||
282 | } |
||
283 |