Respect /
Validation
We could not synchronize checks via GitHub's checks API since Scrutinizer's GitHub App is not installed for this repository.
| Conditions | 8 |
| Paths | 6 |
| Total Lines | 24 |
| Code Lines | 14 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 14 |
| CRAP Score | 8.019 |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
| 1 | <?php |
||
| 23 | 7 | public function validate($input) |
|
| 24 | { |
||
| 25 | 7 | $weights = [7, 3, 1, 0, 7, 3, 1, 7, 3]; |
|
| 26 | 7 | if (!preg_match('/^[A-Z0-9]{9}$/', $input)) { |
|
| 27 | 1 | return false; |
|
| 28 | } |
||
| 29 | |||
| 30 | 6 | $controlNumber = 0; |
|
| 31 | 6 | for ($i = 0; $i < 9; ++$i) { |
|
| 32 | 6 | $value = ord($input[$i]); |
|
| 33 | 6 | if ($i < 3 && $value <= 57) { |
|
| 34 | return false; |
||
| 35 | } |
||
| 36 | |||
| 37 | 6 | if ($i > 2 && $value >= 65) { |
|
| 38 | 1 | return false; |
|
| 39 | } |
||
| 40 | |||
| 41 | 6 | $difference = $value <= 57 ? 48 : 55; // ASCII: "0" is 48 and "A" is 65 |
|
|
|
|||
| 42 | 6 | $controlNumber += ($value - $difference) * $weights[$i]; |
|
| 43 | 6 | } |
|
| 44 | |||
| 45 | 5 | return $controlNumber % 10 == $input[3]; |
|
| 46 | } |
||
| 47 | } |
||
| 48 |
Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it.
The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production.
This check looks for comments that seem to be mostly valid code and reports them.