StandardResult - Code Metrics - Inspection of "New Concrete API" - Respect/Validation - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#678)

by Henrique

created 2016-10-30 09:25 UTC

StandardResult A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	97
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
wmc	7
lcom	1
cbo	0
dl	0
loc	97
ccs	25
cts	25
cp	1
rs	10
c	0
b	0
f	0

7 Methods

Rating	Name	Size	Complexity
A	__construct()	8	1
A	isValid()	4	1
A	getInput()	4	1
A	getRule()	4	1
A	getChildren()	4	1
A	getProperties()	4	1
A	with()	10	1

<?php

/*
 * This file is part of Respect/Validation.
 *
 * (c) Alexandre Gomes Gaigalas <[email protected]>
 *
 * For the full copyright and license information, please view the "LICENSE.md"
 * file that was distributed with this source code.
 */

namespace Respect\Validation;

use Respect\Validation\Exceptions\ComponentException;

/**
 * Class to handle validation.
 *
 * @author Henrique Moody <[email protected]>
 */
final class StandardResult implements Result
{
    /**
     * @var bool
     */
    private $isValid;

    /**
     * @var mixed
     */
    private $input;

    /**
     * @var Rule
     */
    private $rule;

    /**
     * @var Rule[]
     */
    private $children;

    /**
     * @var array
     */
    private $properties;

    /**
     * @param bool   $isValid
     * @param mixed  $input
     * @param Rule   $rule
     * @param array  $properties
     * @param Result $children...
/**
 * @param array $germany
 * @param array $ireland
 */
function finale($germany, $island) {
    return "2:1";
}
     */
    public function __construct($isValid, $input, Rule $rule, array $properties = [], Result ...$children)
    {
        $this->isValid = $isValid;
        $this->input = $input;
        $this->rule = $rule;
        $this->properties = $properties;
        $this->children = $children;

    }

    /**
     * {@inheritdoc}
     */
    public function isValid()
    {
        return $this->isValid;
    }

    /**
     * {@inheritdoc}
     */
    public function getInput()
    {
        return $this->input;
    }

    /**
     * {@inheritdoc}
     */
    public function getRule()
    {
        return $this->rule;
    }

    /**
     * {@inheritdoc}
     */
    public function getChildren()
    {
        return $this->children;
    }

    /**
     * {@inheritdoc}
     */
    public function getProperties()
    {
        return $this->properties;
    }

    /**
     * {@inheritdoc}
     */
    public function with($isValid, array $properties = [])
    {
        return new self(
            $isValid,
            $this->getInput(),
            $this->getRule(),
            $properties + $this->getProperties(),
            ...$this->getChildren()
        );
    }
}


1		<?php
2
3		/*
4		* This file is part of Respect/Validation.
5		*
6		* (c) Alexandre Gomes Gaigalas <[email protected]>
7		*
8		* For the full copyright and license information, please view the "LICENSE.md"
9		* file that was distributed with this source code.
10		*/
11
12		namespace Respect\Validation;
13
14		use Respect\Validation\Exceptions\ComponentException;
15
16		/**
17		* Class to handle validation.
18		*
19		* @author Henrique Moody <[email protected]>
20		*/
21		final class StandardResult implements Result
22		{
23		/**
24		* @var bool
25		*/
26		private $isValid;
27
28		/**
29		* @var mixed
30		*/
31		private $input;
32
33		/**
34		* @var Rule
35		*/
36		private $rule;
37
38		/**
39		* @var Rule[]
40		*/
41		private $children;
42
43		/**
44		* @var array
45		*/
46		private $properties;
47
48		/**
49		* @param bool $isValid
50		* @param mixed $input
51		* @param Rule $rule
52		* @param array $properties
53		* @param Result $children...
		0 ignored issues – show Documentation introduced 2016-10-30 09:29 UTC by Report Bug Copy Issue Report There is no parameter named `$children...`. Did you maybe mean `$children`? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. It has, however, found a similar but not annotated parameter which might be a good fit. Consider the following example. The parameter `$ireland` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $ireland */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was changed, but the annotation was not. Loading history...
54		*/
55	10	public function __construct($isValid, $input, Rule $rule, array $properties = [], Result ...$children)
56		{
57	10	$this->isValid = $isValid;
58	10	$this->input = $input;
59	10	$this->rule = $rule;
60	10	$this->properties = $properties;
61	10	$this->children = $children;
		0 ignored issues – show Documentation Bug introduced 2016-10-30 09:29 UTC by Report Bug Copy Issue Report It seems like `$children` of type `array<integer,object<Respect\Validation\Result>>` is incompatible with the declared type `array<integer,object<Respect\Validation\Rule>>` of property `$children`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
62	10	}
63
64		/**
65		* {@inheritdoc}
66		*/
67	8	public function isValid()
68		{
69	8	return $this->isValid;
70		}
71
72		/**
73		* {@inheritdoc}
74		*/
75	8	public function getInput()
76		{
77	8	return $this->input;
78		}
79
80		/**
81		* {@inheritdoc}
82		*/
83	8	public function getRule()
84		{
85	8	return $this->rule;
86		}
87
88		/**
89		* {@inheritdoc}
90		*/
91	8	public function getChildren()
92		{
93	8	return $this->children;
94		}
95
96		/**
97		* {@inheritdoc}
98		*/
99	8	public function getProperties()
100		{
101	8	return $this->properties;
102		}
103
104		/**
105		* {@inheritdoc}
106		*/
107	7	public function with($isValid, array $properties = [])
108		{
109	7	return new self(
110	7	$isValid,
111	7	$this->getInput(),
112	7	$this->getRule(),
113	7	$properties + $this->getProperties(),
114	7	...$this->getChildren()
115	7	);
116		}
117		}
118

Respect / Validation

Scrutinizer GitHub App not installed

Pull Request — master (#678)

StandardResult A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

7 Methods

Duplication Side-by-Side

Filter issues like