Respect\Validation\Rules\Nif

Complexity

Total Complexity

7

Size/Duplication

Total Lines	58
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

46.67%

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
C	validate()	0	43	7

<?php

/*
 * This file is part of Respect/Validation.
 *
 * (c) Alexandre Gomes Gaigalas <alexandre@gaigalas.net>
 *
 * For the full copyright and license information, please view the "LICENSE.md"
 * file that was distributed with this source code.
 */

namespace Respect\Validation\Rules;

/**
 * Validates Spain's fiscal identification number (NIF).
 *
 * @author Julián Gutiérrez <juliangut@gmail.com>
 *
 * @see https://es.wikipedia.org/wiki/N%C3%BAmero_de_identificaci%C3%B3n_fiscal
 */
class Nif extends AbstractRule
{
    protected static $keyValues = [
        'K' => '',
        'L' => '',
        'M' => '',
        'X' => '0',
        'Y' => '1',
        'Z' => '2'
    ];

    /**
     * {@inheritdoc}
     */
    public function validate($input)
    {
        if (preg_match('/^(\d{8})([A-Z])$/', $input, $matches)) {
            // DNI
            $code = (int) $matches[1];
            $control = $matches[2];

            return substr('TRWAGMYFPDXBNJZSQVHLCKE', $code % 23, 1) === $control;
        } elseif (preg_match('/^([KLMXYZ])(\d{7})([A-Z])$/', $input, $matches)) {
            // NIE
            $code = (int) (static::$keyValues[$matches[1]] . $matches[2]);
            $control = $matches[3];

            return substr('TRWAGMYFPDXBNJZSQVHLCKE', $code % 23, 1) === $control;
        } elseif (preg_match('/^([ABCDEFGHJNPQRSUVW])(\d{7})([0-9A-Z])$/', $input, $matches)) {
            // CIF
            $control = $matches[3];

            $code = 0;
            array_walk(
                str_split($matches[2]),

str_split($matches[2]) cannot be passed to array_walk() as the parameter $array expects a reference.

                function ($value, $key) use (&$code) {
                    if (($key + 1) % 2 === 0) {
                        $code += $value;
                    } else {
                        $code += array_sum(str_split($value * 2));
                    }
                }
            );
            $controlKey = end(str_split($code));

str_split($code) cannot be passed to end() as the parameter $array expects a reference.

            if ($controlKey !== 0) {
                $controlKey = 10 - $controlKey;
            }

            if (is_numeric($control)) {
                $valid = $controlKey === (int) $control;

$valid is not used, you could remove the assignment.

            }

            return substr('JABCDEFGHI', $controlKey % 10, 1) === $control;
        }

        return false;
    }
}