Driver::__construct() - Code Metrics - Inspection of "Aws DynamoDb Driver" - Respect/Structural - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#7)

by Fábio da Silva

created 2016-02-28 18:52 UTC

Driver::__construct() A

↳ Parent: Driver

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	5
ccs	4
cts	4
cp	1
rs	9.4285
cc	1
eloc	3
nc	1
nop	1
crap	1

<?php

namespace Respect\Structural\Driver\DynamoDb;

use Aws\DynamoDb\DynamoDbClient;
use Aws\DynamoDb\Marshaler;
use Respect\Data\CollectionIterator;
use Respect\Data\Collections\Collection;
use Respect\Structural\Driver as BaseDriver;

class Driver implements BaseDriver
{
    /**
     * @var \Aws\DynamoDb\DynamoDbClient
     */
    private $connection;

    /**
     * @var \Aws\DynamoDb\Marshaler
     */
    private $marshaler;

    /**
     * Driver constructor.
     *
     * @param \Aws\DynamoDb\DynamoDbClient $connection
     * @param string                       $database
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     */
    public function __construct(DynamoDbClient $connection)
    {
        $this->connection = $connection;
        $this->marshaler = new Marshaler();
    }

    /**
     * @return \Aws\DynamoDb\DynamoDbClient
     */
    public function getConnection()
    {
        return $this->connection;
    }

    /**
     * @param \Iterator $cursor
     *
     * @return array
     */
    public function fetch(\Iterator $cursor)
    {
        $data = [];

        if ($cursor->valid()) {
            $data = $cursor->current();
            $cursor->next();
        }

        return $data;
    }

    /**
     * @param array $collection
     * @param array $query
     *
     * @return \Iterator
     */
    public function find($collection, array $query = [])
    {
        $expression = [
            'TableName' => $collection,
        ];

        if (!empty($query)) {
            $expression['ScanFilter'] = $query;
        }

        $result = $this->getConnection()->scan($expression);

        return $this->formatResults($result);
    }

    /**
     * @param Collection $collection
     *
     * @return array
     */
    public function generateQuery(Collection $collection)
    {
        return $this->parseConditions($collection);
    }

    /**
     * @param Collection $collection
     *
     * @return array
     */
    protected function parseConditions(Collection $collection)
    {
        $collections = iterator_to_array(
            CollectionIterator::recursive($collection)
        );

        $collections = array_slice($collections, 1);
        $condition = $this->getConditionArray($collection);

        foreach ($collections as $name => $coll) {
            $condition += $this->getConditionArray($coll);
        }

        return $condition;
    }

    /**
     * @param Collection $collection
     *
     * @return array
     */
    protected function getConditionArray(Collection $collection)
    {
        $condition = $collection->getCondition();

        if (!is_array($condition)) {
            $condition = ['_id' => $condition];
        }

        $conditions = [];

        foreach ($condition as $key => $value) {
            $conditions = [
                $key => [
                    'AttributeValueList' => [
                        $this->marshaler->marshalValue($value),
                    ],
                    'ComparisonOperator' => 'EQ',
                ],
            ];
        }

        return $conditions;
    }

    /**
     * @param Collection $collection
     * @param $document
     */
    public function insert($collection, $document)
    {
        $args = [
            'TableName' => $collection,
            'Item' => $this->marshaler->marshalItem($document),
        ];

        $this->getConnection()->putItem($args);
    }

    /**
     * @param Collection $collection
     * @param $criteria
     * @param $document
     */
    public function update($collection, $criteria, $document)
    {
        $args = [
            'TableName' => $collection,
            'Key' => $this->marshaler->marshalItem($criteria),
            'AttributeUpdates' => $this->formatAttributes($document),
        ];

        $this->getConnection()->updateItem($args);
    }

    /**
     * @param Collection $collection
     * @param $criteria
     */
    public function remove($collection, $criteria)
    {
        $args = [
            'TableName' => $collection,
            'Key' => $this->marshaler->marshalItem($criteria),
        ];

        $this->getConnection()->deleteItem($args);
    }

    /**
     * @param $values
     *
     * @return array
     */
    protected function formatAttributes($values)
    {
        $attributes = [];

        foreach ($values as $key => $value) {
            $attributes[$key] = [
                'Value' => $this->marshaler->marshalValue($value),
            ];
        }

        return $attributes;
    }

    protected function formatResults(\Aws\Result $result)
    {
        $items = new \ArrayIterator();

        if ($result['Count'] === 0) {
            return $items;
        }

        foreach ($result['Items'] as $item) {
            $items[] = $this->marshaler->unmarshalItem($item);
        }

        return $items;
    }
}


1		<?php
2
3		namespace Respect\Structural\Driver\DynamoDb;
4
5		use Aws\DynamoDb\DynamoDbClient;
6		use Aws\DynamoDb\Marshaler;
7		use Respect\Data\CollectionIterator;
8		use Respect\Data\Collections\Collection;
9		use Respect\Structural\Driver as BaseDriver;
10
11		class Driver implements BaseDriver
12		{
13		/**
14		* @var \Aws\DynamoDb\DynamoDbClient
15		*/
16		private $connection;
17
18		/**
19		* @var \Aws\DynamoDb\Marshaler
20		*/
21		private $marshaler;
22
23		/**
24		* Driver constructor.
25		*
26		* @param \Aws\DynamoDb\DynamoDbClient $connection
27		* @param string $database
		0 ignored issues – show Bug introduced 2016-02-28 18:58 UTC by Report Bug Copy Issue Report There is no parameter named `$database`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
28		*/
29	8	public function __construct(DynamoDbClient $connection)
30		{
31	8	$this->connection = $connection;
32	8	$this->marshaler = new Marshaler();
33	8	}
34
35		/**
36		* @return \Aws\DynamoDb\DynamoDbClient
37		*/
38	3	public function getConnection()
39		{
40	3	return $this->connection;
41		}
42
43		/**
44		* @param \Iterator $cursor
45		*
46		* @return array
47		*/
48	1	public function fetch(\Iterator $cursor)
49		{
50	1	$data = [];
51
52	1	if ($cursor->valid()) {
53	1	$data = $cursor->current();
54	1	$cursor->next();
55	1	}
56
57	1	return $data;
58		}
59
60		/**
61		* @param array $collection
62		* @param array $query
63		*
64		* @return \Iterator
65		*/
66	2	public function find($collection, array $query = [])
67		{
68		$expression = [
69	2	'TableName' => $collection,
70	2	];
71
72	2	if (!empty($query)) {
73	2	$expression['ScanFilter'] = $query;
74	2	}
75
76	2	$result = $this->getConnection()->scan($expression);
77
78	2	return $this->formatResults($result);
79		}
80
81		/**
82		* @param Collection $collection
83		*
84		* @return array
85		*/
86	3	public function generateQuery(Collection $collection)
87		{
88	3	return $this->parseConditions($collection);
89		}
90
91		/**
92		* @param Collection $collection
93		*
94		* @return array
95		*/
96	3	protected function parseConditions(Collection $collection)
97		{
98	3	$collections = iterator_to_array(
99	3	CollectionIterator::recursive($collection)
100	3	);
101
102	3	$collections = array_slice($collections, 1);
103	3	$condition = $this->getConditionArray($collection);
104
105	3	foreach ($collections as $name => $coll) {
106	1	$condition += $this->getConditionArray($coll);
107	3	}
108
109	3	return $condition;
110		}
111
112		/**
113		* @param Collection $collection
114		*
115		* @return array
116		*/
117	3	protected function getConditionArray(Collection $collection)
118		{
119	3	$condition = $collection->getCondition();
120
121	3	if (!is_array($condition)) {
122	2	$condition = ['_id' => $condition];
123	2	}
124
125	3	$conditions = [];
126
127	3	foreach ($condition as $key => $value) {
128		$conditions = [
129		$key => [
130		'AttributeValueList' => [
131	2	$this->marshaler->marshalValue($value),
132	2	],
133	2	'ComparisonOperator' => 'EQ',
134	2	],
135	2	];
136	3	}
137
138	3	return $conditions;
139		}
140
141		/**
142		* @param Collection $collection
143		* @param $document
144		*/
145		public function insert($collection, $document)
146		{
147		$args = [
148		'TableName' => $collection,
149		'Item' => $this->marshaler->marshalItem($document),
150		];
151
152		$this->getConnection()->putItem($args);
153		}
154
155		/**
156		* @param Collection $collection
157		* @param $criteria
158		* @param $document
159		*/
160		public function update($collection, $criteria, $document)
161		{
162		$args = [
163		'TableName' => $collection,
164		'Key' => $this->marshaler->marshalItem($criteria),
165		'AttributeUpdates' => $this->formatAttributes($document),
166		];
167
168		$this->getConnection()->updateItem($args);
169		}
170
171		/**
172		* @param Collection $collection
173		* @param $criteria
174		*/
175		public function remove($collection, $criteria)
176		{
177		$args = [
178		'TableName' => $collection,
179		'Key' => $this->marshaler->marshalItem($criteria),
180		];
181
182		$this->getConnection()->deleteItem($args);
183		}
184
185		/**
186		* @param $values
187		*
188		* @return array
189		*/
190		protected function formatAttributes($values)
191		{
192		$attributes = [];
193
194		foreach ($values as $key => $value) {
195		$attributes[$key] = [
196		'Value' => $this->marshaler->marshalValue($value),
197		];
198		}
199
200		return $attributes;
201		}
202
203	2	protected function formatResults(\Aws\Result $result)
204		{
205	2	$items = new \ArrayIterator();
206
207	2	if ($result['Count'] === 0) {
208	1	return $items;
209		}
210
211	1	foreach ($result['Items'] as $item) {
212	1	$items[] = $this->marshaler->unmarshalItem($item);
213	1	}
214
215	1	return $items;
216		}
217		}
218

Respect / Structural

Pull Request — master (#7)

Driver::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like