LastModified::by() - Code Metrics - Inspection of "Skip tests depending on XDebug" - Respect/Rest - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d34cec...faecd8 )

by Augusto

created 2016-05-13 03:17 UTC

LastModified::by() A

↳ Parent: LastModified

Complexity

Conditions	3
Paths	3

Size

Total Lines	16
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	3

Importance

Changes	3
Bugs	0	Features	0

Metric	Value
c	3
b	0
f	0
dl	0
loc	16
ccs	10
cts	10
cp	1
rs	9.4285
cc	3
eloc	9
nc	3
nop	2
crap	3

<?php
/*
 * This file is part of the Respect\Rest package.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Respect\Rest\Routines;

use DateTime;
use Respect\Rest\Request;

class LastModified extends AbstractRoutine implements ProxyableBy, Unique
{
    public function by(Request $request, $params)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if (!isset($_SERVER['IF_MODIFIED_SINCE'])) {
            return true;
        }

        $ifModifiedSince = new DateTime($_SERVER['IF_MODIFIED_SINCE']);
        $lastModifiedOn = call_user_func($this->callback, $params);

        header('Last-Modified: '.$lastModifiedOn->format(DateTime::RFC2822));
        if ($lastModifiedOn <= $ifModifiedSince) {
            header('HTTP/1.1 304 Not Modified');

            return false;
        }
    }
}


1		<?php
2		/*
3		* This file is part of the Respect\Rest package.
4		*
5		* For the full copyright and license information, please view the LICENSE
6		* file that was distributed with this source code.
7		*/
8
9		namespace Respect\Rest\Routines;
10
11		use DateTime;
12		use Respect\Rest\Request;
13
14		class LastModified extends AbstractRoutine implements ProxyableBy, Unique
15		{
16	4	public function by(Request $request, $params)
		0 ignored issues – show Coding Style introduced 2015-12-08 16:07 UTC by Report Bug Copy Issue Report `by` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
17		{
18	4	if (!isset($_SERVER['IF_MODIFIED_SINCE'])) {
19	1	return true;
20		}
21
22	4	$ifModifiedSince = new DateTime($_SERVER['IF_MODIFIED_SINCE']);
23	4	$lastModifiedOn = call_user_func($this->callback, $params);
24
25	4	header('Last-Modified: '.$lastModifiedOn->format(DateTime::RFC2822));
26	4	if ($lastModifiedOn <= $ifModifiedSince) {
27	3	header('HTTP/1.1 304 Not Modified');
28
29	3	return false;
30		}
31	2	}
32		}
33

Respect / Rest

Push — master ( d34cec...faecd8 )

LastModified::by() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like