UserAgent - Code Metrics - Inspection of "Skip tests depending on XDebug" - Respect/Rest - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d34cec...faecd8 )

by Augusto

created 2016-05-13 03:17 UTC

UserAgent A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	39
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes	3
Bugs	0	Features	0

Metric	Value
wmc	9
c	3
b	0
f	0
lcom	1
cbo	1
dl	0
loc	39
ccs	19
cts	19
cp	1
rs	10

6 Methods

Rating	Name	Size	Complexity
A	identifyRequested()	4	1
A	considerProvisions()	4	1
A	notifyDeclined()	4	1
A	notifyApproved()	5	1
A	authorize()	8	3
A	through()	6	2

<?php
/*
 * This file is part of the Respect\Rest package.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Respect\Rest\Routines;

use SplObjectStorage;
use Respect\Rest\Request;

/** Handles User Agent filters */
class UserAgent extends AbstractCallbackMediator implements ProxyableThrough, Unique
{
    const ACCEPT_HEADER = 'HTTP_USER_AGENT';
    private $negotiated = false;

    protected function identifyRequested(Request $request, $params)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        return array($_SERVER[self::ACCEPT_HEADER]);
    }
    protected function considerProvisions($requested)
    {
        return $this->getKeys();
    }
    protected function notifyApproved($requested, $provided, Request $request, $params)
    {
        $this->negotiated = new SplObjectStorage();

        $this->negotiated[$request] = $this->getCallback($provided);
    }
    protected function notifyDeclined($requested, $provided, Request $request, $params)
    {
        $this->negotiated = false;
    }

    protected function authorize($requested, $provided)
    {
        if ($provided === '*' || preg_match("#$provided#", $requested)) {
            return true;
        }

        return false;
    }

    public function through(Request $request, $params)
    {
        if (false !== $this->negotiated) {
            return $this->negotiated[$request];
        }
    }
}


1		<?php
2		/*
3		* This file is part of the Respect\Rest package.
4		*
5		* For the full copyright and license information, please view the LICENSE
6		* file that was distributed with this source code.
7		*/
8
9		namespace Respect\Rest\Routines;
10
11		use SplObjectStorage;
12		use Respect\Rest\Request;
13
14		/** Handles User Agent filters */
15		class UserAgent extends AbstractCallbackMediator implements ProxyableThrough, Unique
16		{
17		const ACCEPT_HEADER = 'HTTP_USER_AGENT';
18		private $negotiated = false;
19
20	4	protected function identifyRequested(Request $request, $params)
		0 ignored issues – show Coding Style introduced 2015-12-08 16:07 UTC by Report Bug Copy Issue Report `identifyRequested` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
21		{
22	4	return array($_SERVER[self::ACCEPT_HEADER]);
23		}
24	4	protected function considerProvisions($requested)
25		{
26	4	return $this->getKeys();
27		}
28	3	protected function notifyApproved($requested, $provided, Request $request, $params)
29		{
30	3	$this->negotiated = new SplObjectStorage();
		0 ignored issues – show Documentation Bug introduced 2015-12-08 16:07 UTC by Report Bug Copy Issue Report It seems like `new \SplObjectStorage()` of type `object<SplObjectStorage>` is incompatible with the declared type `boolean` of property `$negotiated`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
31	3	$this->negotiated[$request] = $this->getCallback($provided);
32	3	}
33	1	protected function notifyDeclined($requested, $provided, Request $request, $params)
34		{
35	1	$this->negotiated = false;
36	1	}
37
38	5	protected function authorize($requested, $provided)
39		{
40	5	if ($provided === '*' \|\| preg_match("#$provided#", $requested)) {
41	4	return true;
42		}
43
44	3	return false;
45		}
46
47	4	public function through(Request $request, $params)
48		{
49	4	if (false !== $this->negotiated) {
50	3	return $this->negotiated[$request];
51		}
52	1	}
53		}
54

Respect / Rest

Push — master ( d34cec...faecd8 )

UserAgent A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

6 Methods

Duplication Side-by-Side

Filter issues like