ContentType::notifyApproved() - Code Metrics - Respect/Rest - Measure and Improve Code Quality continuously with Scrutinizer

ContentType::notifyApproved() A
last analyzed 2019-03-22 22:45 UTC

↳ Parent: ContentType

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	5
ccs	4
cts	4
cp	1
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	4
crap	1

<?php
/*
 * This file is part of the Respect\Rest package.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Respect\Rest\Routines;

use SplObjectStorage;
use Respect\Rest\Request;

/** Handles content type content negotiation */
class ContentType extends AbstractCallbackMediator implements ProxyableBy, Unique
{
    protected $contentMap = array();
    protected $negotiated = null;

    protected function identifyRequested(Request $request, $params)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        return isset($_SERVER['CONTENT_TYPE']) ? array($_SERVER['CONTENT_TYPE']) : array();
    }
    protected function considerProvisions($requested)
    {
        return $this->getKeys();
    }
    protected function notifyApproved($requested, $provided, Request $request, $params)
    {
        $this->negotiated = new SplObjectStorage();
        $this->negotiated[$request] = $this->getCallback($provided);
    }
    protected function notifyDeclined($requested, $provided, Request $request, $params)
    {
        $this->negotiated = false;
    }

    public function by(Request $request, $params)
    {
        if (false !== $this->negotiated) {
            return call_user_func($this->negotiated[$request]);
        }
    }
}


1		<?php
2		/*
3		* This file is part of the Respect\Rest package.
4		*
5		* For the full copyright and license information, please view the LICENSE
6		* file that was distributed with this source code.
7		*/
8
9		namespace Respect\Rest\Routines;
10
11		use SplObjectStorage;
12		use Respect\Rest\Request;
13
14		/** Handles content type content negotiation */
15		class ContentType extends AbstractCallbackMediator implements ProxyableBy, Unique
16		{
17		protected $contentMap = array();
18		protected $negotiated = null;
19
20	2	protected function identifyRequested(Request $request, $params)
		0 ignored issues – show Coding Style introduced 2017-10-11 18:44 UTC by Report Bug Copy Issue Report `identifyRequested` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
21		{
22	2	return isset($_SERVER['CONTENT_TYPE']) ? array($_SERVER['CONTENT_TYPE']) : array();
23		}
24	2	protected function considerProvisions($requested)
25		{
26	2	return $this->getKeys();
27		}
28	2	protected function notifyApproved($requested, $provided, Request $request, $params)
29		{
30	2	$this->negotiated = new SplObjectStorage();
31	2	$this->negotiated[$request] = $this->getCallback($provided);
32	2	}
33	1	protected function notifyDeclined($requested, $provided, Request $request, $params)
34		{
35	1	$this->negotiated = false;
36	1	}
37
38	2	public function by(Request $request, $params)
39		{
40	2	if (false !== $this->negotiated) {
41	2	return call_user_func($this->negotiated[$request]);
42		}
43	1	}
44		}
45

Respect / Rest

ContentType::notifyApproved() A last analyzed 2019-03-22 22:45 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

ContentType::notifyApproved() A
last analyzed 2019-03-22 22:45 UTC