OCA\Analytics\Datasource\Json::readData()

Complexity

Conditions	17
Paths	288

Size

Total Lines	76
Code Lines	56

Duplication

Lines	0
Ratio	0 %

Importance

Changes	4
Bugs	0	Features	0

<?php
    public function readData($option): array
    {
        $string = $option['url'];
        $path = $option['path'];
        $auth = $option['auth'];
        $post = ($option['method'] === 'POST') ? true : false;
        $contentType = ($option['content-type'] && $option['content-type'] !== '') ? $option['content-type'] : 'application/json';
        $data = array();

        $ch = curl_init();
        if ($ch !== false) {
            curl_setopt($ch, CURLOPT_SSL_VERIFYPEER, true);
            curl_setopt($ch, CURLOPT_URL, $string);
            curl_setopt($ch, CURLOPT_POST, $post);
            curl_setopt($ch, CURLOPT_RETURNTRANSFER, TRUE);
            curl_setopt($ch, CURLOPT_HTTPHEADER, array(
                'OCS-APIRequest: true',
                'Content-Type: ' . $contentType
            ));
            curl_setopt($ch, CURLOPT_USERPWD, $auth);
            curl_setopt($ch, CURLOPT_VERBOSE, true);
            if ($option['body'] && $option['body'] !== '') {
                curl_setopt($ch, CURLOPT_POSTFIELDS, $option['body']);
            }
            $curlResult = curl_exec($ch);
            $http_code = curl_getinfo($ch, CURLINFO_HTTP_CODE);
            curl_close($ch);
        } else {
            $curlResult = '';
        }

        $json = json_decode($curlResult, true);

It seems like $curlResult can also be of type true; however, parameter $json of json_decode() does only seem to accept string, maybe add an additional type check?

        // check if an array of values should be extracted
        preg_match_all("/(?<={).*(?=})/", $path, $matches);
        if (count($matches[0]) > 0) {
            // array extraction
            $paths = explode(',', $matches[0][0]);
            foreach ($json as $rowArray) {
                $dim1 = $rowArray[$paths[0]] ?: $paths[0];
                $dim2 = $rowArray[$paths[1]] ?: $paths[1];
                $val = $rowArray[$paths[2]] ?: $paths[2];
                array_push($data, [$dim1, $dim2, $val]);
            }
        } else {
            // single value extraction
            $paths = explode(',', $path);
            foreach ($paths as $singlePath) {
                $array = $this->get_nested_array_value($json, $singlePath);

                if (is_array($array)) {
                    foreach ($array as $key => $value) {
                        $pathArray = explode('/', $singlePath);
                        $group = end($pathArray);
                        array_push($data, [$group, $key, $value]);
                    }
                } else {
                    $pathArray = explode('/', $singlePath);
                    $key = end($pathArray);
                    array_push($data, ['', $key, $array]);
                }
            }
        }


        $header = array();
        $header[0] = '';
        $header[1] = 'Key';
        $header[2] = 'Value';

        return [
            'header' => $header,
            'dimensions' => array_slice($header, 0, count($header) - 1),
            'data' => $data,
            'rawdata' => $curlResult,
            'error' => ($http_code>=200 && $http_code<300) ? 0 : 'HTTP response code: '.$http_code,

The variable $http_code does not seem to be defined for all execution paths leading up to this point.

        ];
}