Json::readData() - Code Metrics - Inspection of "Same filter logic for all data sources #139" - Rello/analytics - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( b84320...92b80c )

by Marcel

created 2021-04-10 18:49 UTC

Json::readData() B

↳ Parent: Json

Complexity

Conditions	5
Paths	6

Size

Total Lines	52
Code Lines	39

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	5
eloc	39
c	1
b	0
f	0
nc	6
nop	1
dl	0
loc	52
rs	8.9848

How to fix Long Method

<?php
/**
 * Analytics
 *
 * This file is licensed under the Affero General Public License version 3 or
 * later. See the LICENSE.md file.
 *
 * @author Marcel Scherello <[email protected]>
 * @copyright 2021 Marcel Scherello
 */

namespace OCA\Analytics\Datasource;

use OCP\IL10N;
use OCP\ILogger;

class Json implements IDatasource
{
    private $logger;
    private $l10n;

    public function __construct(
        IL10N $l10n,
        ILogger $logger
    )
    {
        $this->l10n = $l10n;
        $this->logger = $logger;
    }

    /**
     * @return string Display Name of the datasource
     */
    public function getName(): string
    {
        return $this->l10n->t('JSON');
    }

    /**
     * @return int digit unique datasource id
     */
    public function getId(): int
    {
        return 6;
    }

    /**
     * @return array available options of the datasoure
     */
    public function getTemplate(): array
    {
        $template = array();
        array_push($template, ['id' => 'url', 'name' => 'JSON Url', 'placeholder' => 'url']);
        array_push($template, ['id' => 'auth', 'name' => $this->l10n->t('Authentication'), 'placeholder' => 'User:Password']);
        array_push($template, ['id' => 'path', 'name' => $this->l10n->t('JSON path'), 'placeholder' => 'x/y/z']);
        array_push($template, ['id' => 'timestamp', 'name' => $this->l10n->t('Timestamp of dataload'), 'placeholder' => 'false/true', 'type' => 'tf']);
        return $template;
    }

    /**
     * Read the Data
     * @param $option
     * @return array available options of the datasoure
     */
    public function readData($option): array
    {
        $string = $option['url'];
        $path = $option['path'];
        $auth = $option['auth'];
        $data = array();

        $ch = curl_init();
        if ($ch !== false) {
            curl_setopt($ch, CURLOPT_SSL_VERIFYPEER, true);
            curl_setopt($ch, CURLOPT_URL, $string);
            curl_setopt($ch, CURLOPT_RETURNTRANSFER, TRUE);
            curl_setopt($ch, CURLOPT_HTTPHEADER, array(
                'OCS-APIRequest: true'
            ));
            curl_setopt($ch, CURLOPT_USERPWD, $auth);
            curl_setopt($ch, CURLOPT_VERBOSE, true);
            $curlResult = curl_exec($ch);
            curl_close($ch);
        } else {
            $curlResult = '';
        }

        $json = json_decode($curlResult, true);
        $json = json_decode(/** @scrutinizer ignore-type */ $curlResult, true);
        $paths = explode(',', $path);

        foreach ($paths as $singlePath) {
            $array = $this->get_nested_array_value($json, $singlePath);

            if (is_array($array)) {
                foreach ($array as $key => $value) {
                    $pathArray = explode('/', $singlePath);
                    $group = end($pathArray);
                    array_push($data, [$group, $key, $value]);
                }
            } else {
                $pathArray = explode('/', $singlePath);
                $key = end($pathArray);
                array_push($data, ['', $key, $array]);
            }
        }

        $header = array();
        $header[0] = '';
        $header[1] = 'Key';
        $header[2] = 'Value';

        return [
            'header' => $header,
            'dimensions' => array_slice($header, 0, count($header) - 1),
            'data' => $data,
            'error' => 0,
        ];
    }

    /**
     * get array object from string
     *
     * @NoAdminRequired
     * @param $array
     * @param $path
     * @param string $delimiter
     * @return array|string
     */
    private function get_nested_array_value(&$array, $path, $delimiter = '/')
    {
        $pathParts = explode($delimiter, $path);

        $current = &$array;
        foreach ($pathParts as $key) {
            $current = &$current[$key];
        }
        return $current;
    }

}

Rello / analytics

Push — master ( b84320...92b80c )

Json::readData() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like