OCA\Analytics\Datasource\ExternalFile::readData()

Complexity

Conditions	11
Paths	40

Size

Total Lines	67
Code Lines	44

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function readData($option): array
    {
        //$this->logger->error('dataset path: ' . $datasetMetadata['link']);

        $data = array();
        $header = array();
        $headerrow = 0;
        $selectedColumns = array();

        $ch = curl_init();
        if ($ch !== false) {
            curl_setopt($ch, CURLOPT_SSL_VERIFYPEER, FALSE);
            curl_setopt($ch, CURLOPT_HEADER, false);
            curl_setopt($ch, CURLOPT_FOLLOWLOCATION, true);
            curl_setopt($ch, CURLOPT_URL, $option['link']);
            curl_setopt($ch, CURLOPT_REFERER, $option['link']);
            curl_setopt($ch, CURLOPT_RETURNTRANSFER, TRUE);
            curl_setopt($ch, CURLOPT_USERAGENT, 'Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.13) Gecko/20080311 Firefox/2.0.0.13');
            $curlResult = curl_exec($ch);
            curl_close($ch);
        } else {
            $curlResult = '';
        }

        $rows = str_getcsv($curlResult, "\n");

It seems like $curlResult can also be of type true; however, parameter $string of str_getcsv() does only seem to accept string, maybe add an additional type check?

        // remove x number of rows from the beginning
        if (isset($option['offset']) and is_numeric($option['offset'])) {
            $rows = array_slice($rows, $option['offset']);
        }

        // ensure that all values are integers
        if (isset($option['columns'])) {
            $new = array();
            $selectedColumns = str_getcsv($option['columns'], ',');
            foreach ($selectedColumns as $value) {
                if (is_numeric($value)) {
                    array_push($new, $value);
                }
            }
            $selectedColumns = $new;
        }

        $delimiter = $this->detectDelimiter($rows[0]);

        foreach ($rows as &$row) {
            $row = str_getcsv($row, $delimiter);
            $rowMinimized = array();

            if (count($selectedColumns) !== 0) {
                foreach ($selectedColumns as $selectedColumn) {
                    array_push($rowMinimized, $row[$selectedColumn - 1]);
                }
            } else {
                $rowMinimized = $row;
            }

            if ($headerrow === 0) {
                $header = $rowMinimized;
                $headerrow = 1;
            } else {
                array_push($data, $rowMinimized);
            }
        }
        return [
            'header' => $header,
            'data' => $data
        ];
}