OCA\Analytics\Controller\DataSourceController

Complexity

Total Complexity

11

Size/Duplication

Total Lines	97
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	24	1
A	getTemplates()	0	9	1
A	EventTest()	0	8	2
B	read()	0	12	7

<?php
/**
 * Analytics
 *
 * This file is licensed under the Affero General Public License version 3 or
 * later. See the LICENSE.md file.
 *
 * @author Marcel Scherello <audioplayer@scherello.de>
 * @copyright 2020 Marcel Scherello
 */

namespace OCA\Analytics\Controller;

use OCA\Analytics\Datasource\DatasourceEvent;
use OCA\Analytics\Datasource\ExternalFileService;
use OCA\Analytics\Datasource\FileService;
use OCA\Analytics\Datasource\GithubService;
use OCA\Analytics\Datasource\JsonService;
use OCA\Analytics\Datasource\RegexService;
use OCA\Analytics\Datasource\SurveyService;

The type OCA\Analytics\Datasource\SurveyService was not found. Maybe you did not declare it correctly or list all dependencies?

use OCP\AppFramework\Controller;
use OCP\Files\NotFoundException;
use OCP\ILogger;
use OCP\IRequest;
use Symfony\Component\EventDispatcher\EventDispatcherInterface;

class DataSourceController extends Controller
{
    private $logger;
    private $GithubService;
    private $FileService;
    private $ExternalFileService;
    private $RegexService;
    private $JsonService;
    private $SurveyService;
    private $userId;
    /** @var EventDispatcherInterface */
    protected $dispatcher;

    const DATASET_TYPE_GROUP = 0;
    const DATASET_TYPE_INTERNAL_FILE = 1;
    const DATASET_TYPE_INTERNAL_DB = 2;
    const DATASET_TYPE_GIT = 3;
    const DATASET_TYPE_EXTERNAL_FILE = 4;
    const DATASET_TYPE_REGEX = 5;
    const DATASET_TYPE_JSON = 6;
    const DATASET_TYPE_SURVEY = 7;

    public function __construct(
        string $AppName,
        IRequest $request,
        $userId,
        ILogger $logger,
        GithubService $GithubService,
        FileService $FileService,
        RegexService $RegexService,
        JsonService $JsonService,
        SurveyService $SurveyService,
        ExternalFileService $ExternalFileService,
        EventDispatcherInterface $dispatcher
    )
    {
        parent::__construct($AppName, $request);
        $this->userId = $userId;
        $this->logger = $logger;
        $this->ExternalFileService = $ExternalFileService;
        $this->GithubService = $GithubService;
        $this->RegexService = $RegexService;
        $this->FileService = $FileService;
        $this->JsonService = $JsonService;
        $this->SurveyService = $SurveyService;
        $this->dispatcher = $dispatcher;
    }

    /**
     * Get the data from a datasource;
     *
     * @NoAdminRequired
     * @param int $datasource
     * @param $option
     * @return array|NotFoundException
     * @throws NotFoundException
     */
    public function read(int $datasource, $option)
    {
        //$this->logger->debug('DataSourceController 66: Datasource Id: ' . $datasource . ', Option: ' . json_encode($option));
        if ($datasource === self::DATASET_TYPE_INTERNAL_FILE) $result = $this->FileService->read($option);
        elseif ($datasource === self::DATASET_TYPE_GIT) $result = $this->GithubService->read($option);
        elseif ($datasource === self::DATASET_TYPE_EXTERNAL_FILE) $result = $this->ExternalFileService->read($option);
        elseif ($datasource === self::DATASET_TYPE_REGEX) $result = $this->RegexService->read($option);
        elseif ($datasource === self::DATASET_TYPE_JSON) $result = $this->JsonService->read($option);
        elseif ($datasource === self::DATASET_TYPE_SURVEY) $result = $this->SurveyService->read($option);
        else $result = new NotFoundException();

        return $result;
    }

    /**
     * template for options & settings
     *
     * @NoAdminRequired
     * @param int $datasource
     * @return array
     */
    public function getTemplates()
    {
        $result[self::DATASET_TYPE_INTERNAL_FILE] = $this->FileService->getTemplate();

$result was never initialized. Although not strictly required by PHP, it is generally a good practice to add $result = array(); before regardless.

        $result[self::DATASET_TYPE_GIT] = $this->GithubService->getTemplate();
        $result[self::DATASET_TYPE_EXTERNAL_FILE] = $this->ExternalFileService->getTemplate();
        $result[self::DATASET_TYPE_REGEX] = $this->RegexService->getTemplate();
        $result[self::DATASET_TYPE_JSON] = $this->JsonService->getTemplate();
        $result[self::DATASET_TYPE_SURVEY] = $this->SurveyService->getTemplate();
        return $result;
    }

    public function EventTest()
    {
        $event = new DatasourceEvent(DatasourceEvent::class);
        $this->dispatcher->dispatch(DatasourceEvent::class, $event);

OCA\Analytics\Datasource\DatasourceEvent::class of type string is incompatible with the type object expected by parameter $event of Symfony\Contracts\EventDispatcher\EventDispatcherInterface::dispatch().

The call to Symfony\Contracts\EventDispatcher\EventDispatcherInterface::dispatch() has too many arguments starting with $event.

        $datasources = [];

The assignment to $datasources is dead and can be removed.

        foreach ($event->getDataSources() as $datasource) {
            $datasource->getName();

The method getName() does not exist on Closure.

        }
    }
}