OCA\data\Service\GithubService::read()

Complexity

Conditions	5
Paths	2

Size

Total Lines	47
Code Lines	29

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function read($datasetMetadata)
    {
        $string = 'https://api.github.com/repos/' . $datasetMetadata['link'] . '/releases';

        $ch = curl_init();
        curl_setopt($ch, CURLOPT_SSL_VERIFYPEER, FALSE);

It seems like $ch can also be of type false; however, parameter $ch of curl_setopt() does only seem to accept resource, maybe add an additional type check?

        curl_setopt($ch, CURLOPT_HEADER, false);
        curl_setopt($ch, CURLOPT_FOLLOWLOCATION, true);
        curl_setopt($ch, CURLOPT_URL, $string);
        curl_setopt($ch, CURLOPT_REFERER, $string);
        curl_setopt($ch, CURLOPT_RETURNTRANSFER, TRUE);
        curl_setopt($ch, CURLOPT_USERAGENT, 'Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.13) Gecko/20080311 Firefox/2.0.0.13');
        $result = curl_exec($ch);

It seems like $ch can also be of type false; however, parameter $ch of curl_exec() does only seem to accept resource, maybe add an additional type check?

        curl_close($ch);

It seems like $ch can also be of type false; however, parameter $ch of curl_close() does only seem to accept resource, maybe add an additional type check?

        #echo $result;

        $jason_a = json_decode($result, true);
        $i = 0;

        //$tagName = $jason_a[0]['tag_name'];
        //$tagVariable = 'tag_name';
        //$tagName = $jason_a[0][$tagVariable];
        //$count = $jason_a[0] . assets . download_cont;
        //$this->logger->error($tagName . $count);

        $data = array();
        foreach ($jason_a as $item) {
            if ($i === 15) break;
            $nc_value = 0;
            foreach ($item['assets'] as $asset) {
                if (substr($asset['name'], -2) == 'gz') $nc_value = $asset['download_count'];
            }
            array_push($data, ['dimension2' => $item['tag_name'], 'dimension3' => $nc_value]);
            $i++;
        }

        $header = array();
        $header['dimension1'] = '';
        $header['dimension2'] = 'Version';
        $header['dimension3'] = 'Count';

        $result = [
            'header' => $header,
            'data' => $data
        ];

        return $result;
    }
}