Issues in MainCommand.php (master) - Issues in master - ReDnAxE/project-quality-inspector - Measure and Improve Code Quality continuously with Scrutinizer

Issues (45)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Command/MainCommand.php (2 issues)

Labels

Severity

Major 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/*
 * This file is part of project-quality-inspector.
 *
 * (c) Alexandre GESLIN <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace ProjectQualityInspector\Command;

use ProjectQualityInspector\Application\Output\UIHelper;
use ProjectQualityInspector\Application\Output\JunitHelper;
use ProjectQualityInspector\Application\Output\HtmlReportHelper;
use ProjectQualityInspector\Exception\RuleViolationException;
use ProjectQualityInspector\Loader\RulesLoader;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;

/**
 * Main command
 */
class MainCommand extends Command
{
    const SUCCESS_EXIT   = 0;
    const FAILURE_EXIT   = 1;

    protected function configure()
    {
        $this->setName('run')
            ->setDescription('The Project quality tool')
            ->addArgument('applicationType', InputArgument::REQUIRED, 'The application type (symfony or angularjs, etc...)')
            ->addOption('rules', '-r', InputOption::VALUE_IS_ARRAY | InputOption::VALUE_REQUIRED, 'select rules to load')
            ->addOption('baseDir', '-b', InputOption::VALUE_REQUIRED, 'Change the base directory of application')
            ->addOption('configFile', '-c', InputOption::VALUE_REQUIRED, 'Change the base directory of application')
            ->addOption('junitFile', '-j', InputOption::VALUE_REQUIRED, 'Generate a JUnit file')
            ->addOption('htmlFile', '-f', InputOption::VALUE_REQUIRED, 'Generate a HTML file');
    }

    /**
     * @param InputInterface $input
     * @param OutputInterface $output
     * @return int
     */
    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $exitCode = $this::SUCCESS_EXIT;

        $applicationType = $input->getArgument('applicationType');
        $baseDir = $this->resolveBaseDirOption($input);

        //TODO: check if absolute baseDir
        $configFile = $input->getOption('configFile') ? getcwd() . '/' . $input->getOption('configFile') : $this->findConfigFile();
        //TODO: check if absolute baseDir
        $junitFile = $input->getOption('junitFile') ? getcwd() . '/' . $input->getOption('junitFile') : null;
        $htmlFile = $input->getOption('htmlFile') ? getcwd() . '/' . $input->getOption('htmlFile') : null;

        $rulesLoader = new RulesLoader();

        try {
            $rules = $rulesLoader->load($configFile, $applicationType, $baseDir, $input->getOption('rules'));
        } catch (\InvalidArgumentException $e) {
            UIHelper::displayException($e, $output);

            return $this::FAILURE_EXIT;
        }

        UIHelper::displayStartingBlock($output, $configFile, $this->getApplication()->getVersion());

        foreach ($rules as $rule) {
            try {
                $rule->evaluate();
                UIHelper::displayRuleSuccess($rule, $output);
            } catch (RuleViolationException $e) {
                UIHelper::displayRuleViolation($e, $output);
            } catch (\InvalidArgumentException $e) {
                UIHelper::displayException($e, $output);
            }
        }

        if ($junitFile) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            JunitHelper::generateJunitFile($rules, $junitFile);
        }

        if ($htmlFile) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            HtmlReportHelper::generateHtmlFile($rules, $htmlFile);
        }

        return $exitCode;
    }

    /**
     * @return string
     */
    protected function findConfigFile()
    {
        $configsToSearch = [
            getcwd() . '/pqi.yml',
            __DIR__ . '/../../pqi.yml'
        ];

        return (file_exists($configsToSearch[0])) ? $configsToSearch[0] : $configsToSearch[1];
    }

    /**
     * @param InputInterface $input
     * @return string
     */
    protected function resolveBaseDirOption(InputInterface $input)
    { 
        //TODO: check if absolute baseDir
        $baseDir = $input->getOption('baseDir') ? getcwd() . DIRECTORY_SEPARATOR . $input->getOption('baseDir') : getcwd();

        return $baseDir;
    }
}

1			<?php
2			/*
3			* This file is part of project-quality-inspector.
4			*
5			* (c) Alexandre GESLIN <[email protected]>
6			*
7			* For the full copyright and license information, please view the LICENSE
8			* file that was distributed with this source code.
9			*/
10
11			namespace ProjectQualityInspector\Command;
12
13			use ProjectQualityInspector\Application\Output\UIHelper;
14			use ProjectQualityInspector\Application\Output\JunitHelper;
15			use ProjectQualityInspector\Application\Output\HtmlReportHelper;
16			use ProjectQualityInspector\Exception\RuleViolationException;
17			use ProjectQualityInspector\Loader\RulesLoader;
18			use Symfony\Component\Console\Command\Command;
19			use Symfony\Component\Console\Input\InputArgument;
20			use Symfony\Component\Console\Input\InputInterface;
21			use Symfony\Component\Console\Input\InputOption;
22			use Symfony\Component\Console\Output\OutputInterface;
23
24			/**
25			* Main command
26			*/
27			class MainCommand extends Command
28			{
29			const SUCCESS_EXIT = 0;
30			const FAILURE_EXIT = 1;
31
32			protected function configure()
33			{
34			$this->setName('run')
35			->setDescription('The Project quality tool')
36			->addArgument('applicationType', InputArgument::REQUIRED, 'The application type (symfony or angularjs, etc...)')
37			->addOption('rules', '-r', InputOption::VALUE_IS_ARRAY \| InputOption::VALUE_REQUIRED, 'select rules to load')
38			->addOption('baseDir', '-b', InputOption::VALUE_REQUIRED, 'Change the base directory of application')
39			->addOption('configFile', '-c', InputOption::VALUE_REQUIRED, 'Change the base directory of application')
40			->addOption('junitFile', '-j', InputOption::VALUE_REQUIRED, 'Generate a JUnit file')
41			->addOption('htmlFile', '-f', InputOption::VALUE_REQUIRED, 'Generate a HTML file');
42			}
43
44			/**
45			* @param InputInterface $input
46			* @param OutputInterface $output
47			* @return int
48			*/
49			protected function execute(InputInterface $input, OutputInterface $output)
50			{
51			$exitCode = $this::SUCCESS_EXIT;
52
53			$applicationType = $input->getArgument('applicationType');
54			$baseDir = $this->resolveBaseDirOption($input);
55
56			//TODO: check if absolute baseDir
57			$configFile = $input->getOption('configFile') ? getcwd() . '/' . $input->getOption('configFile') : $this->findConfigFile();
58			//TODO: check if absolute baseDir
59			$junitFile = $input->getOption('junitFile') ? getcwd() . '/' . $input->getOption('junitFile') : null;
60			$htmlFile = $input->getOption('htmlFile') ? getcwd() . '/' . $input->getOption('htmlFile') : null;
61
62			$rulesLoader = new RulesLoader();
63
64			try {
65			$rules = $rulesLoader->load($configFile, $applicationType, $baseDir, $input->getOption('rules'));
66			} catch (\InvalidArgumentException $e) {
67			UIHelper::displayException($e, $output);
68
69			return $this::FAILURE_EXIT;
70			}
71
72			UIHelper::displayStartingBlock($output, $configFile, $this->getApplication()->getVersion());
73
74			foreach ($rules as $rule) {
75			try {
76			$rule->evaluate();
77			UIHelper::displayRuleSuccess($rule, $output);
78			} catch (RuleViolationException $e) {
79			UIHelper::displayRuleViolation($e, $output);
80			} catch (\InvalidArgumentException $e) {
81			UIHelper::displayException($e, $output);
82			}
83			}
84
85			if ($junitFile) {
			0 ignored issues – show Bug Best Practice introduced 2017-06-19 08:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$junitFile` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
86			JunitHelper::generateJunitFile($rules, $junitFile);
87			}
88
89			if ($htmlFile) {
			0 ignored issues – show Bug Best Practice introduced 2017-06-19 08:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$htmlFile` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
90			HtmlReportHelper::generateHtmlFile($rules, $htmlFile);
91			}
92
93			return $exitCode;
94			}
95
96			/**
97			* @return string
98			*/
99			protected function findConfigFile()
100			{
101			$configsToSearch = [
102			getcwd() . '/pqi.yml',
103			__DIR__ . '/../../pqi.yml'
104			];
105
106			return (file_exists($configsToSearch[0])) ? $configsToSearch[0] : $configsToSearch[1];
107			}
108
109			/**
110			* @param InputInterface $input
111			* @return string
112			*/
113			protected function resolveBaseDirOption(InputInterface $input)
114			{
115			//TODO: check if absolute baseDir
116			$baseDir = $input->getOption('baseDir') ? getcwd() . DIRECTORY_SEPARATOR . $input->getOption('baseDir') : getcwd();
117
118			return $baseDir;
119			}
120			}

ReDnAxE / project-quality-inspector

Issues (45)

Security Analysis no request data

src/Command/MainCommand.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like