Issues in ProfilerProvider.php (add-psalm-taint-annotations) - Issues in add-psalm-taint-annotations - Ray-Di/Ray.AuraSqlModule - Measure and Improve Code Quality continuously with Scrutinizer

Issues (19)

src/ProfilerProvider.php (1 issue)

Labels

Severity

Major 1

<?php

declare(strict_types=1);

namespace Ray\AuraSqlModule;

use Aura\Sql\Profiler\Profiler;
use Override;
use Psr\Log\LoggerInterface;
use Ray\Di\Provider;

final class ProfilerProvider implements Provider
{
    public function __construct(private LoggerInterface $logger)
    {
    }

    #[Override]
    public function get(): Profiler
    {
        $profiler = new Profiler($this->logger);
        $profiler->setLogFormat('{duration}: {function} {statement}:{values}');
        $profiler->setActive(true);

        return $profiler;
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Ray\AuraSqlModule;
6
7			use Aura\Sql\Profiler\Profiler;
8			use Override;
9			use Psr\Log\LoggerInterface;
10			use Ray\Di\Provider;
11
12			final class ProfilerProvider implements Provider
13			{
14			public function __construct(private LoggerInterface $logger)
15			{
16			}
17
18			#[Override]
19			public function get(): Profiler
20			{
21			$profiler = new Profiler($this->logger);
22			$profiler->setLogFormat('{duration}: {function} {statement}:{values}');
23			$profiler->setActive(true);
24
25			return $profiler;
			0 ignored issues – show Bug Best Practice introduced 2022-04-26 01:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `return $profiler` returns the type `Aura\Sql\Profiler\Profiler` which is incompatible with the return type mandated by `Ray\Di\ProviderInterface::get()` of `Ray\Di\T`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
26			}
27			}
28

Ray-Di / Ray.AuraSqlModule

Issues (19)

src/ProfilerProvider.php (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like