AuraSqlModule::changeHost() - Code Metrics - Inspection of "add ExtendPdo constructor parameters $options, $at..." - Ray-Di/Ray.AuraSqlModule - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — options ( 54df3e )

by Akihito

created 2019-08-16 11:45 UTC

AuraSqlModule::changeHost() A

↳ Parent: AuraSqlModule

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
dl	0
loc	10
ccs	0
cts	6
cp	0
rs	9.9332
c	0
b	0
f	0
cc	2
nc	2
nop	2
crap	6

<?php
/**
 * This file is part of the Ray.AuraSqlModule package.
 *
 * @license http://opensource.org/licenses/MIT MIT
 */
namespace Ray\AuraSqlModule;

use Aura\Sql\ConnectionLocator;
use Aura\Sql\ExtendedPdo;
use Aura\Sql\ExtendedPdoInterface;
use Ray\AuraSqlModule\Pagerfanta\AuraSqlPagerModule;
use Ray\Di\AbstractModule;
use Ray\Di\Scope;

class AuraSqlModule extends AbstractModule
{
    const PARSE_PDO_DSN_REGEX = '/(.*?)\:(?:(host|server)=.*?;)?(.*)/i';

    /**
     * @var string
     */
    private $dsn;

    /**
     * @var string
     */
    private $user;

    /**
     * @var string
     */
    private $password;

    /**
     * @var string
     */
    private $slave;

    /**
     * @var array
     */
    private $options;

    /**
     * @var array
     */
    private $attributes;

    /**
     * @param string $dsn
     * @param string $user
     * @param string $password
     * @param string $slave    comma separated slave host list
     * @param array  $options
     */
    public function __construct(string $dsn, string $user = '', string $password = '', string $slave = '', array $options = [], array $attributes)
    {
        $this->dsn = $dsn;
        $this->user = $user;
        $this->password = $password;
        $this->slave = $slave;
        $this->options = $options;
        $this->attributes = $attributes;
        parent::__construct();
    }

    /**
     * {@inheritdoc}
     */
    protected function configure()
    {
        $this->slave ? $this->configureMasterSlaveDsn() : $this->configureSingleDsn();
        // @Transactional
        $this->install(new TransactionalModule);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->install(new AuraSqlPagerModule());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        \preg_match(self::PARSE_PDO_DSN_REGEX, $this->dsn, $parts);
        $dbType = $parts[1] ?? '';
        $this->install(new AuraSqlQueryModule($dbType));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    private function configureSingleDsn()
    {
        $this->bind(ExtendedPdoInterface::class)->toConstructor(ExtendedPdo::class, 'dsn=pdo_dsn,username=pdo_user,password=pdo_pass,options=pdo_option')->in(Scope::SINGLETON);
        $this->bind()->annotatedWith('pdo_dsn')->toInstance($this->dsn);
        $this->bind()->annotatedWith('pdo_user')->toInstance($this->user);
        $this->bind()->annotatedWith('pdo_pass')->toInstance($this->password);
        $this->bind()->annotatedWith('pdo_option')->toInstance($this->options);
        $this->bind()->annotatedWith('pdo_attributes')->toInstance($this->options);
    }

    private function configureMasterSlaveDsn()
    {
        $locator = new ConnectionLocator;
        $locator->setWrite('master', new Connection($this->dsn, $this->user, $this->password));
        $i = 1;
        $slaves = \explode(',', $this->slave);
        foreach ($slaves as $slave) {
            $slaveDsn = $this->changeHost($this->dsn, $slave);
            $name = 'slave' . (string) $i++;
            $locator->setRead($name, new Connection($slaveDsn, $this->user, $this->password));
        }
        $this->install(new AuraSqlReplicationModule($locator));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    private function changeHost($dsn, $host) : string
    {
        \preg_match(self::PARSE_PDO_DSN_REGEX, $dsn, $parts);
        if (! $parts) {

            return $dsn;
        }
        $dsn = \sprintf('%s:%s=%s;%s', $parts[1], $parts[2], $host, $parts[3]);

        return $dsn;
    }
}


1			<?php
2			/**
3			* This file is part of the Ray.AuraSqlModule package.
4			*
5			* @license http://opensource.org/licenses/MIT MIT
6			*/
7			namespace Ray\AuraSqlModule;
8
9			use Aura\Sql\ConnectionLocator;
10			use Aura\Sql\ExtendedPdo;
11			use Aura\Sql\ExtendedPdoInterface;
12			use Ray\AuraSqlModule\Pagerfanta\AuraSqlPagerModule;
13			use Ray\Di\AbstractModule;
14			use Ray\Di\Scope;
15
16			class AuraSqlModule extends AbstractModule
17			{
18			const PARSE_PDO_DSN_REGEX = '/(.?)\:(?:(host\|server)=.?;)?(.*)/i';
19
20			/**
21			* @var string
22			*/
23			private $dsn;
24
25			/**
26			* @var string
27			*/
28			private $user;
29
30			/**
31			* @var string
32			*/
33			private $password;
34
35			/**
36			* @var string
37			*/
38			private $slave;
39
40			/**
41			* @var array
42			*/
43			private $options;
44
45			/**
46			* @var array
47			*/
48			private $attributes;
49
50			/**
51			* @param string $dsn
52			* @param string $user
53			* @param string $password
54			* @param string $slave comma separated slave host list
55			* @param array $options
56			*/
57			public function __construct(string $dsn, string $user = '', string $password = '', string $slave = '', array $options = [], array $attributes)
58			{
59			$this->dsn = $dsn;
60			$this->user = $user;
61			$this->password = $password;
62			$this->slave = $slave;
63			$this->options = $options;
64			$this->attributes = $attributes;
65			parent::__construct();
66			}
67
68			/**
69			* {@inheritdoc}
70			*/
71			protected function configure()
72			{
73			$this->slave ? $this->configureMasterSlaveDsn() : $this->configureSingleDsn();
74			// @Transactional
75			$this->install(new TransactionalModule);
			0 ignored issues – show Documentation introduced 2018-04-24 01:25 UTC by Report Bug Copy Issue Report `new \Ray\AuraSqlModule\TransactionalModule()` is of type `object<Ray\AuraSqlModule\TransactionalModule>`, but the function expects a `object<self>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
76			$this->install(new AuraSqlPagerModule());
			0 ignored issues – show Documentation introduced 2018-04-24 01:25 UTC by Report Bug Copy Issue Report `new \Ray\AuraSqlModule\P...ta\AuraSqlPagerModule()` is of type `object<Ray\AuraSqlModule...nta\AuraSqlPagerModule>`, but the function expects a `object<self>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
77			\preg_match(self::PARSE_PDO_DSN_REGEX, $this->dsn, $parts);
78			$dbType = $parts[1] ?? '';
79			$this->install(new AuraSqlQueryModule($dbType));
			0 ignored issues – show Documentation introduced 2018-04-24 01:25 UTC by Report Bug Copy Issue Report `new \Ray\AuraSqlModule\AuraSqlQueryModule($dbType)` is of type `object<Ray\AuraSqlModule\AuraSqlQueryModule>`, but the function expects a `object<self>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
80			}
81
82			private function configureSingleDsn()
83			{
84			$this->bind(ExtendedPdoInterface::class)->toConstructor(ExtendedPdo::class, 'dsn=pdo_dsn,username=pdo_user,password=pdo_pass,options=pdo_option')->in(Scope::SINGLETON);
85			$this->bind()->annotatedWith('pdo_dsn')->toInstance($this->dsn);
86			$this->bind()->annotatedWith('pdo_user')->toInstance($this->user);
87			$this->bind()->annotatedWith('pdo_pass')->toInstance($this->password);
88			$this->bind()->annotatedWith('pdo_option')->toInstance($this->options);
89			$this->bind()->annotatedWith('pdo_attributes')->toInstance($this->options);
90			}
91
92			private function configureMasterSlaveDsn()
93			{
94			$locator = new ConnectionLocator;
95			$locator->setWrite('master', new Connection($this->dsn, $this->user, $this->password));
96			$i = 1;
97			$slaves = \explode(',', $this->slave);
98			foreach ($slaves as $slave) {
99			$slaveDsn = $this->changeHost($this->dsn, $slave);
100			$name = 'slave' . (string) $i++;
101			$locator->setRead($name, new Connection($slaveDsn, $this->user, $this->password));
102			}
103			$this->install(new AuraSqlReplicationModule($locator));
			0 ignored issues – show Documentation introduced 2018-04-24 01:25 UTC by Report Bug Copy Issue Report `new \Ray\AuraSqlModule\A...icationModule($locator)` is of type `object<Ray\AuraSqlModule...raSqlReplicationModule>`, but the function expects a `object<self>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
104			}
105
106			private function changeHost($dsn, $host) : string
107			{
108			\preg_match(self::PARSE_PDO_DSN_REGEX, $dsn, $parts);
109			if (! $parts) {
			0 ignored issues – show Bug Best Practice introduced 2017-03-07 09:41 UTC by Report Bug Copy Issue Report The expression `$parts` of type `string[]` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
110			return $dsn;
111			}
112			$dsn = \sprintf('%s:%s=%s;%s', $parts[1], $parts[2], $host, $parts[3]);
113
114			return $dsn;
115			}
116			}
117

Ray-Di / Ray.AuraSqlModule

Push — options ( 54df3e )

AuraSqlModule::changeHost() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like