1 | <?php |
||
16 | class AuraSqlModule extends AbstractModule |
||
17 | { |
||
18 | const PARSE_PDO_DSN_REGEX = '/(.*?)\:(?:(host|server)=.*?;)?(.*)/i'; |
||
19 | |||
20 | /** |
||
21 | * @var string |
||
22 | */ |
||
23 | private $dsn; |
||
24 | |||
25 | /** |
||
26 | * @var string |
||
27 | */ |
||
28 | private $user; |
||
29 | |||
30 | /** |
||
31 | * @var string |
||
32 | */ |
||
33 | private $password; |
||
34 | |||
35 | /** |
||
36 | * @var string |
||
37 | */ |
||
38 | private $slave; |
||
39 | |||
40 | /** |
||
41 | * @param string $dsn |
||
42 | * @param string $user |
||
43 | * @param string $password |
||
44 | * @param string $slave comma separated slave host list |
||
45 | */ |
||
46 | 8 | public function __construct($dsn, $user = '', $password = '', $slave = null) |
|
54 | |||
55 | /** |
||
56 | * {@inheritdoc} |
||
57 | */ |
||
58 | 8 | protected function configure() |
|
59 | { |
||
60 | 8 | $this->slave ? $this->configureMasterSlaveDsn() : $this->configureSingleDsn(); |
|
61 | // @Transactional |
||
62 | 8 | $this->install(new TransactionalModule); |
|
63 | 8 | $this->install(new AuraSqlPagerModule()); |
|
64 | 8 | preg_match(self::PARSE_PDO_DSN_REGEX, $this->dsn, $parts); |
|
65 | 8 | $dbType = isset($parts[1]) ? $parts[1] : ''; |
|
66 | 8 | $this->install(new AuraSqlQueryModule($dbType)); |
|
67 | 8 | } |
|
68 | |||
69 | 6 | private function configureSingleDsn() |
|
77 | |||
78 | 2 | private function configureMasterSlaveDsn() |
|
91 | |||
92 | /** |
||
93 | * @param string $dsn |
||
94 | * @param string $host |
||
95 | * |
||
96 | * @return string |
||
97 | */ |
||
98 | 2 | private function changeHost($dsn, $host) |
|
108 | } |
||
109 |
This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent.
Consider making the comparison explicit by using
empty(..)
or! empty(...)
instead.