Connection::__construct() - Code Metrics - Inspection of "Slave can also be specified by environment variabl..." - Ray-Di/Ray.AuraSqlModule - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — 1.x (#69)

by Akihito

created 2022-09-29 01:11 UTC

Connection::__construct() A

↳ Parent: Connection

Complexity

Conditions	1
Paths	1

Size

Total Lines	12
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	3
Bugs	0	Features	1

Metric	Value
cc	1
eloc	5
c	3
b	0
f	1
nc	1
nop	5
dl	0
loc	12
ccs	0
cts	0
cp	0
crap	2
rs	10

<?php

declare(strict_types=1);

namespace Ray\AuraSqlModule;

use Aura\Sql\ExtendedPdo;

class Connection
{
    private string $dsn;
    private string $username;
    private string $password;

    /** @var array<string> */
    private array $options;

    /** @var array<string> */
    private array $queries;
    private ?ExtendedPdo $pdo = null;

    /**
     * @phpstan-param array<string> $options
     * @phpstan-param array<string> $queries
     */
    public function __construct(
        string $dsn,
        string $username = '',
        string $password = '',
        array $options = [],
        array $queries = []
    ) {
        $this->dsn = $dsn;
        $this->username = $username;
        $this->password = $password;
        $this->options = $options;
        $this->queries = $queries;
    }

    public function __invoke(): ExtendedPdo
    {
        if ($this->pdo instanceof ExtendedPdo) {
            return $this->pdo;
        }

        $this->pdo = new ExtendedPdo($this->dsn, $this->username, $this->password, $this->options, $this->queries);

        return $this->pdo;

    }

    public function isSame(string $dsn, string $username, string $password): bool
    {
        return $dsn === $this->dsn &&
            $username === $this->username &&
            $password === $this->password;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Ray\AuraSqlModule;
6
7		use Aura\Sql\ExtendedPdo;
8
9		class Connection
10		{
11		private string $dsn;
12		private string $username;
13		private string $password;
14
15		/** @var array<string> */
16		private array $options;
17
18		/** @var array<string> */
19		private array $queries;
20		private ?ExtendedPdo $pdo = null;
21
22		/**
23		* @phpstan-param array<string> $options
24		* @phpstan-param array<string> $queries
25		*/
26		public function __construct(
27		string $dsn,
28		string $username = '',
29		string $password = '',
30		array $options = [],
31		array $queries = []
32		) {
33		$this->dsn = $dsn;
34		$this->username = $username;
35		$this->password = $password;
36		$this->options = $options;
37		$this->queries = $queries;
38		}
39
40		public function __invoke(): ExtendedPdo
41		{
42		if ($this->pdo instanceof ExtendedPdo) {
43		return $this->pdo;
44		}
45
46		$this->pdo = new ExtendedPdo($this->dsn, $this->username, $this->password, $this->options, $this->queries);
47
48	9	return $this->pdo;
		0 ignored issues – show Bug Best Practice introduced 2022-09-29 01:13 UTC by Report Bug Copy Issue Report The expression `return $this->pdo` returns the type `null` which is incompatible with the type-hinted return `Aura\Sql\ExtendedPdo`. Loading history...
49		}
50	9
51	9	public function isSame(string $dsn, string $username, string $password): bool
52	9	{
53	9	return $dsn === $this->dsn &&
54	9	$username === $this->username &&
55	9	$password === $this->password;
56		}
57		}
58

Ray-Di / Ray.AuraSqlModule

Pull Request — 1.x (#69)

Connection::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like