AuraSqlQueryUpdateProvider::get()   A
last analyzed

Complexity

Conditions 1
Paths 1

Size

Total Lines 3
Code Lines 1

Duplication

Lines 0
Ratio 0 %

Importance

Changes 1
Bugs 0 Features 1
Metric Value
cc 1
eloc 1
c 1
b 0
f 1
nc 1
nop 0
dl 0
loc 3
rs 10
1
<?php
2
3
declare(strict_types=1);
4
5
namespace Ray\AuraSqlModule;
6
7
use Aura\SqlQuery\Common\UpdateInterface;
8
use Aura\SqlQuery\QueryFactory;
9
use Ray\AuraSqlModule\Annotation\AuraSqlQueryConfig;
10
use Ray\Di\ProviderInterface;
11
12
/** @implements ProviderInterface<UpdateInterface> */
13
class AuraSqlQueryUpdateProvider implements ProviderInterface
14
{
15
    private string $db;
16
17
    /**
18
     * @param string $db The database type
19
     *
20
     * @AuraSqlQueryConfig
21
     */
22
    #[AuraSqlQueryConfig]
23
    public function __construct($db)
24
    {
25
        $this->db = $db;
26
    }
27
28
    /**
29
     * {@inheritDoc}
30
     */
31
    public function get(): UpdateInterface
32
    {
33
        return (new QueryFactory($this->db))->newUpdate();
0 ignored issues
show
Bug Best Practice introduced by
The expression return new Aura\SqlQuery...$this->db)->newUpdate() returns the type Aura\SqlQuery\Common\UpdateInterface which is incompatible with the return type mandated by Ray\Di\ProviderInterface::get() of Ray\Di\T.

In the issue above, the returned value is violating the contract defined by the mentioned interface.

Let's take a look at an example:

interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
Loading history...
34
    }
35
}
36