Issues in Saving.php (master) - Issues in master - Raphhh/samurai - Measure and Improve Code Quality continuously with Scrutinizer

Issues (12)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Module/Task/Saving.php (1 issue)

Labels

Coding Style 1

Severity

Informational 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace Samurai\Module\Task;

use Samurai\Module\Module;
use Samurai\Task\ITask;
use Samurai\Task\Task;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Console\Question\ConfirmationQuestion;

/**
 * Class Saving
 * @package Samurai\Module\Task
 * @author Raphaël Lefebvre <[email protected]>
 */
class Saving extends Task
{
    /**
     * @param InputInterface $input
     * @param OutputInterface $output
     * @return bool
     */
    public function execute(InputInterface $input, OutputInterface $output)
    {
        $module = $this->buildModuleFromInput($input);
        if($this->canBeSaved($input, $output, $module)){
            $this->getService('module_procedure')->setOutput($output);
            if(!$this->getService('module_procedure')->import($module)){
                return ITask::BLOCKING_ERROR_CODE;
            }
        }
        return ITask::NO_ERROR_CODE;
    }

    /**
     * @param InputInterface $input
     * @return Module
     */
    private function buildModuleFromInput(InputInterface $input)
    {
        $module = new Module();
        $module->setName($input->getArgument('name'));
        $module->setPackage($input->getArgument('package'));
        $module->setVersion($input->getArgument('version'));
        $module->setDescription($input->getArgument('description'));
        $module->setSource($input->getArgument('source'));
        $module->setIsEnable(true);
        return $module;
    }

    /**
     * @param InputInterface $input
     * @param OutputInterface $output
     * @param Module $newModule
     * @return bool
     */
    private function canBeSaved(InputInterface $input, OutputInterface $output, Module $newModule)
    {
        return !$this->getService('module_manager')->has($newModule->getName())
            || $this->confirmOverride($input, $output, $this->getInitialModule($newModule), $newModule);
    }

    /**
     * @param InputInterface $input
     * @param OutputInterface $output
     * @param Module $oldModule
     * @param Module $newModule
     * @return mixed
     */
    private function confirmOverride(InputInterface $input, OutputInterface $output, Module $oldModule, Module $newModule)

    {
        return $this->getService('helper_set')->get('question')->ask(
            $input,
            $output,
            $this->buildQuestion($oldModule, $newModule)
        );
    }

    /**
     * @param Module $oldModule
     * @param Module $newModule
     * @return ConfirmationQuestion
     * @internal param Module $module
     */
    private function buildQuestion(Module $oldModule, Module $newModule)
    {
        return new ConfirmationQuestion(
            sprintf(
                '<question>Do you want to override the module "%s" with "%s"?</question>[y]',
                trim($oldModule->getPackage() . ' ' . $oldModule->getVersion()),
                trim($newModule->getPackage() . ' ' . $newModule->getVersion())
            )
        );
    }

    /**
     * @param Module $newModule
     * @return Module
     */
    private function getInitialModule(Module $newModule)
    {
        return $this->getService('module_manager')->get($newModule->getName());
    }
}


1			<?php
2			namespace Samurai\Module\Task;
3
4			use Samurai\Module\Module;
5			use Samurai\Task\ITask;
6			use Samurai\Task\Task;
7			use Symfony\Component\Console\Input\InputInterface;
8			use Symfony\Component\Console\Output\OutputInterface;
9			use Symfony\Component\Console\Question\ConfirmationQuestion;
10
11			/**
12			* Class Saving
13			* @package Samurai\Module\Task
14			* @author Raphaël Lefebvre <[email protected]>
15			*/
16			class Saving extends Task
17			{
18			/**
19			* @param InputInterface $input
20			* @param OutputInterface $output
21			* @return bool
22			*/
23	4		public function execute(InputInterface $input, OutputInterface $output)
24			{
25	4		$module = $this->buildModuleFromInput($input);
26	4		if($this->canBeSaved($input, $output, $module)){
27	3		$this->getService('module_procedure')->setOutput($output);
28	3		if(!$this->getService('module_procedure')->import($module)){
29			return ITask::BLOCKING_ERROR_CODE;
30			}
31	3		}
32	4		return ITask::NO_ERROR_CODE;
33			}
34
35			/**
36			* @param InputInterface $input
37			* @return Module
38			*/
39	4	View Code Duplication	private function buildModuleFromInput(InputInterface $input)
40			{
41	4		$module = new Module();
42	4		$module->setName($input->getArgument('name'));
43	4		$module->setPackage($input->getArgument('package'));
44	4		$module->setVersion($input->getArgument('version'));
45	4		$module->setDescription($input->getArgument('description'));
46	4		$module->setSource($input->getArgument('source'));
47	4		$module->setIsEnable(true);
48	4		return $module;
49			}
50
51			/**
52			* @param InputInterface $input
53			* @param OutputInterface $output
54			* @param Module $newModule
55			* @return bool
56			*/
57	4		private function canBeSaved(InputInterface $input, OutputInterface $output, Module $newModule)
58			{
59	4		return !$this->getService('module_manager')->has($newModule->getName())
60	4		\|\| $this->confirmOverride($input, $output, $this->getInitialModule($newModule), $newModule);
61			}
62
63			/**
64			* @param InputInterface $input
65			* @param OutputInterface $output
66			* @param Module $oldModule
67			* @param Module $newModule
68			* @return mixed
69			*/
70	2		private function confirmOverride(InputInterface $input, OutputInterface $output, Module $oldModule, Module $newModule)
			0 ignored issues – show Coding Style introduced 2016-04-29 15:56 UTC by Report Bug Copy Issue Report Show Similar Issues like this This line exceeds maximum limit of 120 characters; contains 122 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
71			{
72	2		return $this->getService('helper_set')->get('question')->ask(
73	2		$input,
74	2		$output,
75	2		$this->buildQuestion($oldModule, $newModule)
76	2		);
77			}
78
79			/**
80			* @param Module $oldModule
81			* @param Module $newModule
82			* @return ConfirmationQuestion
83			* @internal param Module $module
84			*/
85	2		private function buildQuestion(Module $oldModule, Module $newModule)
86			{
87	2		return new ConfirmationQuestion(
88	2		sprintf(
89	2		'<question>Do you want to override the module "%s" with "%s"?</question>[y]',
90	2		trim($oldModule->getPackage() . ' ' . $oldModule->getVersion()),
91	2		trim($newModule->getPackage() . ' ' . $newModule->getVersion())
92	2		)
93	2		);
94			}
95
96			/**
97			* @param Module $newModule
98			* @return Module
99			*/
100	4		private function getInitialModule(Module $newModule)
101	4		{
102	2		return $this->getService('module_manager')->get($newModule->getName());
103			}
104			}
105

Raphhh / samurai

Issues (12)

Security Analysis no request data

src/Module/Task/Saving.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like