Issues in Running.php (master) - Issues in master - Raphhh/samurai - Measure and Improve Code Quality continuously with Scrutinizer

Issues (12)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Module/Task/Running.php (1 issue)

Labels

Coding Style 1

Severity

Informational 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace Samurai\Module\Task;

use Samurai\Module\Module;
use Samurai\Module\Modules;
use Samurai\Module\Planner\ModulePlannerBuilder;
use Samurai\Module\Planner\ModulesPlannerBuilder;
use Samurai\Module\Planner\PlannerAdapter;
use Samurai\Task\ITask;
use Samurai\Task\Task;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;

/**
 * Class Running
 * @package Samurai\Module\Task
 * @author Raphaël Lefebvre <[email protected]>
 */
class Running extends Task
{
    /**
     * @param InputInterface $input
     * @param OutputInterface $output
     * @return int|null
     */
    public function execute(InputInterface $input, OutputInterface $output)
    {
        if($input->getArgument('name')){
            if(!$this->getService('module_manager')->has($input->getArgument('name'))){
                $output->writeln(sprintf('<error>Module "%s" not found!</error>', $input->getArgument('name')));
                return ITask::BLOCKING_ERROR_CODE;
            }
            return $this->runModule($input, $output, $this->getService('module_manager')->get($input->getArgument('name')));

        }
        return $this->runModules($input, $output, $this->getService('module_manager')->getAll());
    }

    /**
     * @param InputInterface $input
     * @param OutputInterface $output
     * @param Modules $modules
     * @return int|null
     */
    protected function runModules(InputInterface $input, OutputInterface $output, Modules $modules)
    {
        $modules = $this->filter($modules);
        $output->writeln(sprintf('<info>Running %d module(s)</info>', count($modules)));
        $planner = new PlannerAdapter(
            new ModulesPlannerBuilder($this->getServices(), $modules, $this->getService('helper_set')->get('question')),
            $this->getService('helper_set')->get('question')
        );
        return $planner->execute($input, $output);
    }

    /**
     * @param InputInterface $input
     * @param OutputInterface $output
     * @param Module $module
     * @return int|null
     */
    private function runModule(InputInterface $input, OutputInterface $output, Module $module)
    {
        $output->writeln('<info>Running the module "'.$module->getName().'"</info>');
        $planner = new PlannerAdapter(
            new ModulePlannerBuilder($this->getServices(), $module),
            $this->getService('helper_set')->get('question')
        );
        return $planner->execute($input, $output);
    }

    /**
     * @param Modules $modules
     * @return Modules
     */
    private function filter(Modules $modules)
    {
        return new Modules(array_filter($modules->getArrayCopy(), function(Module $module){
            return $module->isEnable();
        }));
    }
}


1		<?php
2		namespace Samurai\Module\Task;
3
4		use Samurai\Module\Module;
5		use Samurai\Module\Modules;
6		use Samurai\Module\Planner\ModulePlannerBuilder;
7		use Samurai\Module\Planner\ModulesPlannerBuilder;
8		use Samurai\Module\Planner\PlannerAdapter;
9		use Samurai\Task\ITask;
10		use Samurai\Task\Task;
11		use Symfony\Component\Console\Input\InputInterface;
12		use Symfony\Component\Console\Output\OutputInterface;
13
14		/**
15		* Class Running
16		* @package Samurai\Module\Task
17		* @author Raphaël Lefebvre <[email protected]>
18		*/
19		class Running extends Task
20		{
21		/**
22		* @param InputInterface $input
23		* @param OutputInterface $output
24		* @return int\|null
25		*/
26	3	public function execute(InputInterface $input, OutputInterface $output)
27		{
28	2	if($input->getArgument('name')){
29	1	if(!$this->getService('module_manager')->has($input->getArgument('name'))){
30		$output->writeln(sprintf('<error>Module "%s" not found!</error>', $input->getArgument('name')));
31		return ITask::BLOCKING_ERROR_CODE;
32		}
33	1	return $this->runModule($input, $output, $this->getService('module_manager')->get($input->getArgument('name')));
		0 ignored issues – show Coding Style introduced 2016-04-29 15:56 UTC by Report Bug Copy Issue Report Show Similar Issues like this This line exceeds maximum limit of 120 characters; contains 124 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
34		}
35	1	return $this->runModules($input, $output, $this->getService('module_manager')->getAll());
36	3	}
37
38		/**
39		* @param InputInterface $input
40		* @param OutputInterface $output
41		* @param Modules $modules
42		* @return int\|null
43		*/
44	2	protected function runModules(InputInterface $input, OutputInterface $output, Modules $modules)
45		{
46	2	$modules = $this->filter($modules);
47	2	$output->writeln(sprintf('<info>Running %d module(s)</info>', count($modules)));
48	2	$planner = new PlannerAdapter(
49	2	new ModulesPlannerBuilder($this->getServices(), $modules, $this->getService('helper_set')->get('question')),
50	2	$this->getService('helper_set')->get('question')
51	2	);
52	2	return $planner->execute($input, $output);
53		}
54
55		/**
56		* @param InputInterface $input
57		* @param OutputInterface $output
58		* @param Module $module
59		* @return int\|null
60		*/
61	1	private function runModule(InputInterface $input, OutputInterface $output, Module $module)
62		{
63	1	$output->writeln('<info>Running the module "'.$module->getName().'"</info>');
64	1	$planner = new PlannerAdapter(
65	1	new ModulePlannerBuilder($this->getServices(), $module),
66	1	$this->getService('helper_set')->get('question')
67	1	);
68	1	return $planner->execute($input, $output);
69		}
70
71		/**
72		* @param Modules $modules
73		* @return Modules
74		*/
75		private function filter(Modules $modules)
76		{
77	2	return new Modules(array_filter($modules->getArrayCopy(), function(Module $module){
78	2	return $module->isEnable();
79	2	}));
80		}
81		}
82

Raphhh / samurai

Issues (12)

Security Analysis no request data

src/Module/Task/Running.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like