Issues in PlannerAdapter.php (master) - Issues in master - Raphhh/samurai - Measure and Improve Code Quality continuously with Scrutinizer

Issues (12)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Module/Planner/PlannerAdapter.php (1 issue)

Labels

Coding Style 1

Severity

Informational 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace Samurai\Module\Planner;

use Samurai\Task\ITask;
use Samurai\Task\Planner;
use Symfony\Component\Console\Helper\QuestionHelper;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Console\Question\ConfirmationQuestion;

/**
 * Class PlannerAdapter
 * @package Samurai\Module\Planner
 * @author Raphaël Lefebvre <[email protected]>
 */
class PlannerAdapter implements ITask
{
    /**
     * @var Planner
     */
    private $planner;

    /**
     * @var IPlannerBuilder
     */
    private $plannerBuilder;

    /**
     * @var QuestionHelper
     */
    private $questionHelper;

    /**
     * @param IPlannerBuilder $plannerBuilder
     * @param QuestionHelper $questionHelper
     */
    public function __construct(IPlannerBuilder $plannerBuilder, QuestionHelper $questionHelper)
    {
        $this->plannerBuilder = $plannerBuilder;
        $this->questionHelper = $questionHelper;
    }

    /**
     * @param InputInterface $input
     * @param OutputInterface $output
     * @return int|null
     */
    public function execute(InputInterface $input, OutputInterface $output)
    {
        if(!$this->questionHelper->ask($input, $output, $this->buildQuestion())){
            return ITask::NO_ERROR_CODE;
        }
        if(!$this->plannerBuilder->count()){
            $output->writeln('<error>Nothing to run</error>');
            return ITask::NON_BLOCKING_ERROR_CODE;
        }
        return $this->getPlanner()->execute($input, $output);
    }

    /**
     * Getter of $planner
     *
     * @return Planner
     */
    private function getPlanner()
    {
        if($this->planner == null){
            $this->setPlanner($this->plannerBuilder->create());
        }
        return $this->planner;
    }

    /**
     * Setter of $planner
     *
     * @param Planner $planner
     */
    private function setPlanner(Planner $planner)
    {
        $this->planner = $planner;
    }

    /**
     * @return ConfirmationQuestion
     */
    private function buildQuestion()
    {
        if($this->plannerBuilder->getName()){
            return new ConfirmationQuestion('<question>Do you want to execute the module "' . $this->plannerBuilder->getName() . '"?[y]</question>');

        }
        return new ConfirmationQuestion('<question>Do you want to execute the modules?[y]</question>');
    }
}


1		<?php
2		namespace Samurai\Module\Planner;
3
4		use Samurai\Task\ITask;
5		use Samurai\Task\Planner;
6		use Symfony\Component\Console\Helper\QuestionHelper;
7		use Symfony\Component\Console\Input\InputInterface;
8		use Symfony\Component\Console\Output\OutputInterface;
9		use Symfony\Component\Console\Question\ConfirmationQuestion;
10
11		/**
12		* Class PlannerAdapter
13		* @package Samurai\Module\Planner
14		* @author Raphaël Lefebvre <[email protected]>
15		*/
16		class PlannerAdapter implements ITask
17		{
18		/**
19		* @var Planner
20		*/
21		private $planner;
22
23		/**
24		* @var IPlannerBuilder
25		*/
26		private $plannerBuilder;
27
28		/**
29		* @var QuestionHelper
30		*/
31		private $questionHelper;
32
33		/**
34		* @param IPlannerBuilder $plannerBuilder
35		* @param QuestionHelper $questionHelper
36		*/
37	4	public function __construct(IPlannerBuilder $plannerBuilder, QuestionHelper $questionHelper)
38		{
39	4	$this->plannerBuilder = $plannerBuilder;
40	4	$this->questionHelper = $questionHelper;
41	4	}
42
43		/**
44		* @param InputInterface $input
45		* @param OutputInterface $output
46		* @return int\|null
47		*/
48	4	public function execute(InputInterface $input, OutputInterface $output)
49	2	{
50	4	if(!$this->questionHelper->ask($input, $output, $this->buildQuestion())){
51	2	return ITask::NO_ERROR_CODE;
52		}
53	3	if(!$this->plannerBuilder->count()){
54		$output->writeln('<error>Nothing to run</error>');
55		return ITask::NON_BLOCKING_ERROR_CODE;
56		}
57	3	return $this->getPlanner()->execute($input, $output);
58		}
59
60		/**
61		* Getter of $planner
62		*
63		* @return Planner
64		*/
65	3	private function getPlanner()
66		{
67	3	if($this->planner == null){
68	3	$this->setPlanner($this->plannerBuilder->create());
69	3	}
70	3	return $this->planner;
71		}
72
73		/**
74		* Setter of $planner
75		*
76		* @param Planner $planner
77		*/
78	3	private function setPlanner(Planner $planner)
79		{
80	3	$this->planner = $planner;
81	3	}
82
83		/**
84		* @return ConfirmationQuestion
85		*/
86	4	private function buildQuestion()
87		{
88	4	if($this->plannerBuilder->getName()){
89	2	return new ConfirmationQuestion('<question>Do you want to execute the module "' . $this->plannerBuilder->getName() . '"?[y]</question>');
		0 ignored issues – show Coding Style introduced 2016-04-29 15:56 UTC by Report Bug Copy Issue Report Show Similar Issues like this This line exceeds maximum limit of 120 characters; contains 149 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
90		}
91	3	return new ConfirmationQuestion('<question>Do you want to execute the modules?[y]</question>');
92		}
93		}
94

Raphhh / samurai

Issues (12)

Security Analysis no request data

src/Module/Planner/PlannerAdapter.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like