Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
13 | class ModuleProcedure |
||
14 | { |
||
15 | /** |
||
16 | * @var ModuleManager |
||
17 | */ |
||
18 | private $moduleManager; |
||
19 | |||
20 | /** |
||
21 | * @var Composer |
||
22 | */ |
||
23 | private $composer; |
||
24 | |||
25 | /** |
||
26 | * @var BalloonFactory |
||
27 | */ |
||
28 | private $balloonFactory; |
||
29 | |||
30 | /** |
||
31 | * @var ModulesSorter |
||
32 | */ |
||
33 | private $modulesSorter; |
||
34 | |||
35 | /** |
||
36 | * @var OutputInterface |
||
37 | */ |
||
38 | private $output; |
||
39 | |||
40 | /** |
||
41 | * @param ModuleManager $moduleManager |
||
42 | * @param Composer $composer |
||
43 | * @param BalloonFactory $balloonFactory |
||
44 | * @param ModulesSorter $modulesSorter |
||
45 | */ |
||
46 | 14 | public function __construct( |
|
57 | |||
58 | /** |
||
59 | * Getter of $output |
||
60 | * |
||
61 | * @return OutputInterface |
||
62 | */ |
||
63 | 13 | public function getOutput() |
|
67 | |||
68 | /** |
||
69 | * Setter of $output |
||
70 | * |
||
71 | * @param OutputInterface $output |
||
72 | */ |
||
73 | 13 | public function setOutput(OutputInterface $output) |
|
77 | |||
78 | /** |
||
79 | * @param Module $module |
||
80 | * @param bool $mustSortModules |
||
81 | * @return bool |
||
82 | */ |
||
83 | 6 | View Code Duplication | public function import(Module $module, $mustSortModules = true) |
99 | |||
100 | /** |
||
101 | * @param Module $module |
||
102 | * @param bool $mustSortModules |
||
103 | * @return bool |
||
104 | */ |
||
105 | 3 | View Code Duplication | public function update(Module $module, $mustSortModules = true) |
121 | |||
122 | /** |
||
123 | * @param Module $module |
||
124 | * @param bool $mustSortModules |
||
125 | * @return bool |
||
126 | */ |
||
127 | 4 | public function remove(Module $module, $mustSortModules = true) |
|
156 | |||
157 | /** |
||
158 | * @param Module $module |
||
159 | */ |
||
160 | 1 | private function rollbackImport(Module $module) |
|
166 | |||
167 | /** |
||
168 | * @param Module $module |
||
169 | * @param bool $mustSortModules |
||
170 | * @return bool |
||
171 | */ |
||
172 | 7 | private function installModule(Module $module, $mustSortModules) |
|
187 | |||
188 | /** |
||
189 | * @param Modules $dependencies |
||
190 | * @return bool |
||
191 | */ |
||
192 | 7 | private function importDependencies(Modules $dependencies) |
|
203 | |||
204 | /** |
||
205 | * @param Module $module |
||
206 | * @return bool |
||
207 | */ |
||
208 | 6 | private function importModule(Module $module) |
|
215 | |||
216 | /** |
||
217 | * @param Module $module |
||
218 | * @return bool |
||
219 | */ |
||
220 | 3 | private function updateModule(Module $module) |
|
224 | |||
225 | /** |
||
226 | * @param Module $module |
||
227 | * @return bool |
||
228 | */ |
||
229 | 4 | private function removeModule(Module $module) |
|
233 | |||
234 | /** |
||
235 | * @param Module $module |
||
236 | * @return array |
||
237 | */ |
||
238 | 7 | private function retrieveOriginalModuleData(Module $module) |
|
242 | |||
243 | /** |
||
244 | * @param Module $module |
||
245 | * @param array $moduleData |
||
246 | * @return Module |
||
247 | */ |
||
248 | 7 | private function completeModuleParams(Module $module, array $moduleData) |
|
264 | |||
265 | /** |
||
266 | * @param Module $module |
||
267 | * @return string |
||
268 | */ |
||
269 | 7 | private function buildConfigPath(Module $module) |
|
276 | |||
277 | /** |
||
278 | * |
||
279 | */ |
||
280 | 8 | private function sort() |
|
285 | |||
286 | /** |
||
287 | * @param string $message |
||
288 | */ |
||
289 | 13 | private function log($message) |
|
295 | } |
||
296 |
Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line.