Puppy\Config\FileReader\YmlFileReader

Complexity

Total Complexity

4

Size/Duplication

Total Lines	32
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	2
A	getFileExtension()	0	4	1
A	read()	0	4	1

<?php
namespace Puppy\Config\FileReader;

use Symfony\Component\Yaml\Parser;

/**
 * Class YmlFileReader
 * @package Puppy\Config\FileReader
 * @author Raphaël Lefebvre <raphael@raphaellefebvre.be>
 */
class YmlFileReader implements IFileReader
{
    /**
     * @var Parser
     */
    private $yaml;

    /**
     * @param Parser $yaml

Should the type for parameter $yaml not be null|Parser?

     */
    public function __construct(Parser $yaml = null)
    {
        $this->yaml = $yaml ? : new Parser();
    }

    /**
     * @return string
     */
    public function getFileExtension()
    {
        return '.yml';
    }

    /**
     * @param $filePath
     * @return array

Should the return type not be array|string|\stdClass? Also, consider making the array more specific, something like array<String>, or String[].

     */
    public function read($filePath)
    {
        return $this->yaml->parse(file_get_contents($filePath), true);
    }
}