Balloon\Manager\FileManager

Complexity

Total Complexity

35

Size/Duplication

Total Lines	248
Duplicated Lines	7.26 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	12
Bugs	0	Features	7

19 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	has()	0	4	1
A	get()	0	7	2
A	getList()	9	9	2
A	find()	9	9	2
A	getAll()	0	11	3
A	set()	0	4	1
A	add()	0	11	2
B	retrieveKey()	0	19	7
A	addList()	0	8	2
A	modify()	0	9	2
A	modifyList()	0	8	2
A	remove()	0	6	1
A	removeList()	0	8	2
A	removeAll()	0	4	1
A	getFileReader()	0	4	1
A	getPrimaryKey()	0	4	1
A	setPrimaryKey()	0	4	1
A	setFileReader()	0	4	1

<?php
namespace Balloon\Manager;

use Balloon\Reader\IFileReader;

/**
 * Class FileManager
 * @package Balloon\Manager
 * @author Raphaël Lefebvre <raphael@raphaellefebvre.be>
 */
class FileManager implements IFileManager
{
    /**
     * @var IFileReader
     */
    private $fileReader;

    /**
     * @var string
     */
    private $primaryKey;

    /**
     * @param IFileReader $fileReader
     * @param string $primaryKey
     */
    public function __construct(IFileReader $fileReader, $primaryKey = '')
    {
        $this->setFileReader($fileReader);
        $this->setPrimaryKey($primaryKey);
    }

    /**
     * @param mixed $id
     * @return bool
     */
    public function has($id)
    {
        return array_key_exists($id, $this->getAll());
    }

    /**
     * @param mixed $id
     * @return mixed|null
     */
    public function get($id)
    {
        if($this->has($id)){
            return $this->getAll()[$id];
        }
        return null;
    }

    /**
     * @param array $ids
     * @return mixed

Consider making the return type a bit more specific; maybe use object|array.

     */
    public function getList(array $ids)

This method seems to be duplicated in your project.

    {
        $all = $this->getAll();
        $result = array_intersect_key((array)$all, $ids);
        if(is_object($all)){
            return new $all($result);
        }
        return $result;
    }

    /**
     * @param callable $filter

Should the type for parameter $filter not be null|callable? Also, consider making the array more specific, something like array<String>, or String[].

     * @return mixed

Consider making the return type a bit more specific; maybe use object|array.

     */
    public function find(callable $filter = null)

This method seems to be duplicated in your project.

    {
        $all = $this->getAll();
        $result = array_filter((array)$all, $filter);
        if(is_object($all)){
            return new $all($result);
        }
        return $result;
    }

    /**
     * @return mixed

Consider making the return type a bit more specific; maybe use array|object.

     */
    public function getAll()
    {
        $result = $this->fileReader->read();
        if(is_null($result)){
            return [];
        }
        if(is_scalar($result)){
            return (array)$result;
        }
        return $result;
    }

    /**
     * @param mixed $dataList
     * @return int
     */
    public function set($dataList)
    {
        return $this->fileReader->write($dataList);
    }

    /**
     * @param mixed $data
     * @return int
     */
    public function add($data)
    {
        $dataList = $this->getAll();
        $key = $this->retrieveKey($data);
        if($key){
            $dataList[$key] = $data;
        }else{
            $dataList[] = $data;
        }
        return $this->set($dataList);
    }

    /**
     * @param mixed $data
     * @return mixed
     */
    private function retrieveKey($data)
    {
        if($this->getPrimaryKey()){
            $pk = $this->getPrimaryKey();

Avoid variables with short names like $pk. Configured minimum length is 3.

            if(is_array($data)){
                if(array_key_exists($pk, $data)) {
                    return $data[$pk];
                }
            }elseif(is_object($data)){
                if(method_exists($data, 'get'.$pk)){
                    return $data->{'get'.$pk}();
                }
                if(property_exists($data, $pk)) {
                    return $data->{$pk};
                }
            }
        }
        return null;
    }

    /**
     * @param mixed $dataList
     * @return int
     */
    public function addList($dataList)
    {
        $result = 0;
        foreach($dataList as $data){
            $result = $this->add($data);
        }
        return $result;
    }

    /**
     * @param mixed $id
     * @param mixed $data
     * @return int
     */
    public function modify($id, $data)
    {
        $dataList = $this->getAll();
        if(isset($dataList[$id])){
            $dataList[$id] = $data;
            return $this->set($dataList);
        }
        return 0;
    }

    /**
     * @param mixed $dataList
     * @return int
     */
    public function modifyList($dataList)
    {
        $result = 0;
        foreach($dataList as $id => $data){
            $result = $this->modify($id, $data);
        }
        return $result;
    }

    /**
     * @param mixed $id
     * @return int
     */
    public function remove($id)
    {
        $dataList = $this->getAll();
        unset($dataList[$id]);
        return $this->set($dataList);
    }

    /**
     * @param array $ids
     * @return int
     */
    public function removeList(array $ids)
    {
        $result = 0;
        foreach($ids as $id){
            $result = $this->remove($id);
        }
        return $result;
    }

    /**
     * @return int
     */
    public function removeAll()
    {
        return $this->set(null);
    }

    /**
     * Getter of $fileReader
     *
     * @return IFileReader
     */
    protected function getFileReader()
    {
        return $this->fileReader;
    }

    /**
     * Getter of $primaryKey
     *
     * @return string
     */
    protected function getPrimaryKey()
    {
        return $this->primaryKey;
    }

    /**
     * Setter of $primaryKey
     *
     * @param string $primaryKey
     */
    private function setPrimaryKey($primaryKey)
    {
        $this->primaryKey = (string)$primaryKey;
    }

    /**
     * Setter of $fileReader
     *
     * @param IFileReader $fileReader
     */
    private function setFileReader(IFileReader $fileReader)
    {
        $this->fileReader = $fileReader;
    }
}