CreditSearch::search() - Code Metrics - Inspection of "commentary validation" - ROAResearch/yii2-workflow - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Pull Request — master (#5)

by aguevaraIL

created 2020-08-27 18:20 UTC

CreditSearch::search() A

↳ Parent: CreditSearch

Complexity

Conditions	2
Paths	2

Size

Total Lines	16
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	1	Features	0

Metric	Value
cc	2
eloc	10
c	2
b	1
f	0
nc	2
nop	2
dl	0
loc	16
rs	9.9332

<?php

namespace app\api\models;

use roaresearch\yii2\roa\ResourceSearch;
use roaresearch\yii2\workflow\models\Stage;
use yii\data\ActiveDataProvider;

class CreditSearch extends Credit implements ResourceSearch
{
    /**
     * @inhertidoc
     */
    public function attributes()
    {
        return array_merge(parent::attributes(), ['activeStage']);
    }

    /**
     * @inhertidoc
     */
    protected $autogenerateInitialWorklog = false;

    /**
     * @inhertidoc
     */
    public function rules()
    {
        return [
            [['created_by'], 'integer'],
            [
                ['activeStage'],
                'each',
                'allowMessageFromRule' => true,
                'rule' => [
                    'integer',
                    'message' => '{value} is not an integer',
                ],
            ],
        ];
    }

    /**
     * @inhertidoc
     */
    public function search(
        array $params,
        ?string $formName = ''
    ): ?ActiveDataProvider {
        $this->load($params, $formName);
        if (!$this->validate()) {
            return null;
        }

        $class = get_parent_class();
        return new ActiveDataProvider([
            'query' => $class::find()
                ->joinWith('activeWorkLog')
                ->andFilterWhere([
                    'credit.created_by' => $this->created_by,

                    'activeWorkLog.stage_id' => $this->activeStage,

                ])
        ]);
    }
}


1			<?php
2
3			namespace app\api\models;
4
5			use roaresearch\yii2\roa\ResourceSearch;
6			use roaresearch\yii2\workflow\models\Stage;
7			use yii\data\ActiveDataProvider;
8
9			class CreditSearch extends Credit implements ResourceSearch
10			{
11			/**
12			* @inhertidoc
13			*/
14			public function attributes()
15			{
16			return array_merge(parent::attributes(), ['activeStage']);
17			}
18
19			/**
20			* @inhertidoc
21			*/
22			protected $autogenerateInitialWorklog = false;
23
24			/**
25			* @inhertidoc
26			*/
27			public function rules()
28			{
29			return [
30			[['created_by'], 'integer'],
31			[
32			['activeStage'],
33			'each',
34			'allowMessageFromRule' => true,
35			'rule' => [
36			'integer',
37			'message' => '{value} is not an integer',
38			],
39			],
40			];
41			}
42
43			/**
44			* @inhertidoc
45			*/
46			public function search(
47			array $params,
48			?string $formName = ''
49			): ?ActiveDataProvider {
50			$this->load($params, $formName);
51			if (!$this->validate()) {
52			return null;
53			}
54
55			$class = get_parent_class();
56			return new ActiveDataProvider([
57			'query' => $class::find()
58			->joinWith('activeWorkLog')
59			->andFilterWhere([
60			'credit.created_by' => $this->created_by,
			0 ignored issues – show Bug Best Practice introduced 2020-03-10 11:48 UTC by Report Bug Copy Issue Report The property `created_by` does not exist on `app\api\models\CreditSearch`. Since you implemented `__get`, consider adding a @property annotation. Loading history...
61			'activeWorkLog.stage_id' => $this->activeStage,
			0 ignored issues – show Bug Best Practice introduced 2020-03-10 11:35 UTC by Report Bug Copy Issue Report The property `activeStage` does not exist on `app\api\models\CreditSearch`. Since you implemented `__get`, consider adding a @property annotation. Loading history...
62			])
63			]);
64			}
65			}
66

ROAResearch / yii2-workflow

Pull Request — master (#5)

CreditSearch::search() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like