app\models\User

Complexity

Total Complexity

22

Size/Duplication

Total Lines	180
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

18 Methods

Rating	Name	Duplication	Size	Complexity
A	getUserDetails()	0	7	2
A	checkUserCredentials()	0	8	2
A	findByUsername()	0	3	1
A	getId()	0	3	1
A	validatePassword()	0	3	1
A	removePasswordResetToken()	0	3	1
A	generatePasswordResetToken()	0	3	1
A	validateAuthKey()	0	3	1
A	generateAuthKey()	0	3	1
A	tableName()	0	3	1
A	getAuthKey()	0	3	1
A	findByPasswordResetToken()	0	9	2
A	getAccessTokens()	0	4	1
A	rules()	0	4	1
A	isPasswordResetTokenValid()	0	10	2
A	setPassword()	0	3	1
A	findIdentityByAccessToken()	0	5	1
A	findIdentity()	0	3	1

<?php

namespace app\models;

use OAuth2\Storage\UserCredentialsInterface;
use roaresearch\yii2\oauth2server\models\OauthAccessTokens as AccessToken;
use Yii;
use yii\web\IdentityInterface;

class User extends \yii\db\ActiveRecord implements UserCredentialsInterface, IdentityInterface
{
    public static function tableName()
    {
        return '{{%user}}';
    }

    /**
     * @inheritdoc
     */
    public static function findIdentity($id)
    {
        return static::findOne(['id' => $id]);

The expression return static::findOne(array('id' => $id)) returns the type yii\db\ActiveRecord which is incompatible with the return type mandated by yii\web\IdentityInterface::findIdentity() of null|yii\web\IdentityInterface.

    }

    /**
     * @inheritdoc
     */
    public static function findIdentityByAccessToken($token, $type = null)
    {
        return static::find()->joinWith('accessTokens', false)

The expression return static::find()->joinWith('accessTokens', false)->andWhere(array('access_token' => $token))->one() also could return the type array|yii\db\ActiveRecord which is incompatible with the return type mandated by yii\web\IdentityInterface::findIdentityByAccessToken() of null|yii\web\IdentityInterface.

            ->andWhere(['access_token' => $token])
            ->one();
    }

    /**
     * Finds user by username
     *
     * @param string $username
     * @return static|null
     */
    public static function findByUsername($username)
    {
        return static::findOne(['username' => $username]);
    }

    /**
     * Finds user by password reset token
     *
     * @param string $token password reset token
     * @return static|null
     */
    public static function findByPasswordResetToken($token)
    {
        if (!static::isPasswordResetTokenValid($token)) {
            return null;
        }

        return static::findOne([
            'password_reset_token' => $token,
            'status' => self::STATUS_ACTIVE,

The constant app\models\User::STATUS_ACTIVE was not found. Maybe you did not declare it correctly or list all dependencies?

        ]);
    }

    /**
     * Finds out if password reset token is valid
     *
     * @param string $token password reset token
     * @return bool
     */
    public static function isPasswordResetTokenValid($token)
    {
        if (empty($token)) {
            return false;
        }

        $timestamp = (int)substr($token, strrpos($token, '_') + 1);
        $expire = Yii::$app->params['user.passwordResetTokenExpire'];

        return $timestamp + $expire >= time();
    }

    /**
     * @inheritdoc
     */
    public function getId()
    {
        return $this->getPrimaryKey();

The expression return $this->getPrimaryKey() also could return the type array which is incompatible with the return type mandated by yii\web\IdentityInterface::getId() of integer|string.

    }

    /**
     * @inheritdoc
     */
    public function getAuthKey()
    {
        return $this->auth_key;
    }

    /**
     * @inheritdoc
     */
    public function validateAuthKey($authKey)
    {
        return $this->getAuthKey() === $authKey;
    }

    /**
     * Validates password
     *
     * @param string $password password to validate
     * @return bool if password provided is valid for current user
     */
    public function validatePassword($password)
    {
        return Yii::$app->security->validatePassword($password, $this->password_hash);
    }

    /**
     * Generates password hash from password and sets it to the model
     *
     * @param string $password
     */
    public function setPassword($password)
    {
        $this->password_hash = Yii::$app->security->generatePasswordHash($password);

The property password_hash does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    }

    /**
     * Generates "remember me" authentication key
     */
    public function generateAuthKey()
    {
        $this->auth_key = Yii::$app->security->generateRandomString();

The property auth_key does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    }

    /**
     * Generates new password reset token
     */
    public function generatePasswordResetToken()
    {
        $this->password_reset_token = Yii::$app->security->generateRandomString() . '_' . time();

The property password_reset_token does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    }

    /**
     * Removes password reset token
     */
    public function removePasswordResetToken()
    {
        $this->password_reset_token = null;

The property password_reset_token does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    }

    /**
     * @inheritdoc
     */
    public function checkUserCredentials($username, $password)
    {
        $user = static::findByUsername($username);
        if (empty($user)) {
            return false;
        }

        return $user->validatePassword($password);
    }

    /**
     * @inheritdoc
     */
    public function getUserDetails($username = null)
    {
        $user = $username
            ? static::findByUsername($username)
            : $this;

        return ['user_id' => $user->id];

The property id does not exist on app\models\User. Since you implemented __get, consider adding a @property annotation.

    }

    /**
     * @return \yii\db\ActiveQuery
     */
    public function getAccessTokens()
    {
        return $this->hasMany(AccessToken::class, ['user_id' => 'id'])
            ->andOnCondition(['client_id' => 'testclient']);
    }


    public function rules()
    {
        return [
            [['username'], 'string'],
        ];
    }
}