roaresearch\yii2\roa\actions\ProfileUpdate

Complexity

Total Complexity

4

Size/Duplication

Total Lines	43
Duplicated Lines	0 %

Test Coverage

Coverage

87.5%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	init()	0	2	1
A	run()	0	16	3

<?php

namespace roaresearch\yii2\roa\actions;

use Yii;
use yii\{base\Model, db\ActiveRecordInterface, web\ServerErrorHttpException};

class ProfileUpdate extends \yii\rest\Action
{
    use LoadFileTrait;

    /**
     * @var string the scenario to be assigned to the model before it is validated and updated.
     */
    public string $scenario = Model::SCENARIO_DEFAULT;

    /**
     * @var string[] that defines which columns will be recibe files
     */
    public array $fileAttributes = [];

    /**
     * @inheritdoc
     */
    public function init()
    {
    }

    /**
     * Updates the information of the logged user.
     *
     * @return ActiveRecordInterface
     * @throws ServerErrorHttpException if there is any error when updating the model
     */
    public function run(): ActiveRecordInterface
    {
        /* @var $model ActiveRecordInterface */
        $model = Yii::$app->user->identity;
        $model->scenario = $this->scenario;

Accessing scenario on the interface yii\db\ActiveRecordInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        $model->load(
            Yii::$app->getRequest()->getBodyParams() + $this->parseFileAttributes(),
            ''
        );
        if ($model->save() === false && !$model->hasErrors()) {
            throw new ServerErrorHttpException(
                'Failed to update the object for unknown reason.'
            );
        }

        return $model;
    }
}