roaresearch\yii2\roa\actions\Update

Complexity

Total Complexity

2

Size/Duplication

Total Lines	27
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	proct()	0	9	2

<?php

namespace roaresearch\yii2\roa\actions;

use roaresearch\yii2\roa\hal\ARContract;
use Yii;
use yii\{base\Model, web\ServerErrorHttpException};

/**
 * Action to update the attributes in a record.
 * @author Angel (Faryshta) Guevara <aguevara@alquimiadigital.mx>
 */
class Update extends ProctRecordAction
{
    use LoadFileTrait;

    /**
     * @inheritdoc
     */
    protected string $errorMessage = 'Update failed for unknown reasons.';

    /**
     * @var string the scenario to be assigned to the model before it is
     * validated and updated.
     */
    public string $scenario = Model::SCENARIO_DEFAULT;

    /**
     * @inheritdoc
     */
    protected function proct(ARContract $model, array $params): bool
    {
        $model->scenario = $this->scenario;

Accessing scenario on the interface roaresearch\yii2\roa\hal\ARContract suggest that you code against a concrete implementation. How about adding an instanceof check?

        $model->load(

The method load() does not exist on roaresearch\yii2\roa\hal\ARContract.

            Yii::$app->request->getBodyParams() + $this->parseFileAttributes(),
            ''
        );

        return false !== $model->save() || $model->hasErrors();

The method hasErrors() does not exist on roaresearch\yii2\roa\hal\ARContract.

    }
}