roaresearch\yii2\roa\hal\EmbeddableTrait

Complexity

Total Complexity

23

Size/Duplication

Total Lines	155
Duplicated Lines	24.52 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
B	toArray()	0	50	10
A	getExpandEnvelope()	0	4	1
A	resolveFieldList()	17	17	5
A	resolveExpandList()	21	21	5
A	processField()	0	6	2

<?php

namespace roaresearch\yii2\roa\hal;

use yii\base\Arrayable;
use yii\base\ArrayableTrait;
use yii\helpers\ArrayHelper;
use yii\web\Link;
use yii\web\Linkable;

/**
 * Interface to get a the information of a file associated to a model.
 *
 * @author Angel (Faryshta) Guevara <aguevara@alquimiadigital.mx>
 */
trait EmbeddableTrait
{
    use ArrayableTrait;

    /**
     * @inheritdoc
     */
    public abstract function fields();

The return type could not be reliably inferred; please add a @return annotation.

    /**
     * @inheritdoc
     */
    public abstract function extraFields();

The return type could not be reliably inferred; please add a @return annotation.

    /**
     * @inheritdoc
     */
    public function toArray(
        array $fields = [],
        array $expand = [],
        $recursive = true
    ) {
        $data = [];
        foreach ($this->resolveFieldList($fields) as $field => $definition) {
            $data[$field] = $this->processField($field, $definition);
        }

        foreach ($this->resolveExpandList($expand) as $field => $definition) {
            $attribute = $this->processField($field, $definition);

            if ($recursive) {
                $nestedFields = $this->extractFieldsFor($fields, $field);
                $nestedExpand = $this->extractFieldsFor($expand, $field);
                if ($attribute instanceof Arrayable) {
                    $attribute = $attribute->toArray(
                        $nestedFields,
                        $nestedExpand
                    );
                } elseif (is_array($attribute)) {
                    $attribute = array_map(
                        function ($item) use ($nestedFields, $nestedExpand) {
                            if ($item instanceof Arrayable) {
                                return $item->toArray(
                                    $nestedFields,
                                    $nestedExpand
                                );
                            }
                            return $item;
                        },
                        $attribute
                    );
                }
            }

            if ($envelope = $this->getExpandEnvelope()) {
                $data[$envelope][$field] = $attribute;
            } else {
                $data[$field] = $attribute;
            }
        }

        if ($this instanceof Linkable) {
            $data['_links'] = Link::serialize($this->getLinks());
        }

        return $recursive ? ArrayHelper::toArray($data) : $data;
    }

    /**
     * @return string property which will contain all the expanded parameters.
     */
    public function getExpandEnvelope(): string
    {
        return Embeddable::EMBEDDED_PROPERTY;
    }

    /**
     * Determines which fields can be returned by [[toArray()]].
     * This method will first extract the root fields from the given fields.
     * Then it will check the requested root fields against those declared in
     * [[fields()]] to determine which fields can be returned.
     *
     * @param array $fields the fields being requested for exporting
     * @return array the list of fields to be exported. The array keys are the
     * field names, and the array values are the corresponding object property
     * names or PHP callables returning the field values.
     */
    protected function resolveFieldList($fields): array

This method seems to be duplicated in your project.

    {
        $fields = $this->extractRootFields($fields);

Consider using a different name than the parameter $fields. This often makes code more readable.

        $result = [];

        foreach ($this->fields() as $field => $definition) {
                if (is_int($field)) {
                    $field = $definition;
                }

                if (empty($fields) || in_array($field, $fields, true)) {
                    $result[$field] = $definition;
                }
        }

        return $result;
    }

    /**
     * Determines which expand fields can be returned by [[toArray()]].
     * This method will first extract the root fields from the given expand.
     * Then it will check the requested root fields against those declared in
     * [[extraFields()]] to determine which fields can be returned.
     *
     * @param array $expand the expand fields being requested for exporting
     * @return array the list of fields to be exported. The array keys are the
     * field names, and the array values are the corresponding object property
     * names or PHP callables returning the field values.
     */
    protected function resolveExpandList($expand): array

This method seems to be duplicated in your project.

    {
        if (empty($expand)) {
            return [];
        }

        $fields = $this->extractRootFields($expand);
        $result = [];

        foreach ($this->extraFields() as $field => $definition) {
                if (is_int($field)) {
                    $field = $definition;
                }

                if (in_array($field, $fields, true)) {
                    $result[$field] = $definition;
                }
        }

        return $result;
    }

    /**
     * @param string $field name of the field to be resolved.
     * @param string|callable $definition the field definition, it its an string
     * it will be used as a property name, or a callable with signature.
     *
     * ```php
     * function ($model, string $field)
     * ```
     * @return mixed data obtained from the model.
     */
    protected function processField($field, $definition)
    {
        return is_string($definition)
            ? $this->$definition
            : $definition($this, $field);
    }
}