roaresearch\yii2\roa\actions\Update::run()

Complexity

Conditions	3
Paths	2

Size

Total Lines	16
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	3.0067

Importance

Changes

0

<?php
    public function run($id)
    {
        /* @var $model \yii\db\ActiveRecordInterface */
        $model = $this->findModel($id);
        $request = Yii::$app->getRequest();
        $this->checkAccess($model, $request->getQueryParams());
        $model->scenario = $this->scenario;

Accessing scenario on the interface yii\db\ActiveRecordInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        $model->load(
            $request->getBodyParams() + $this->parseFileAttributes(),
            ''
        );
        if ($model->save() === false && !$model->hasErrors()) {
            throw new ServerErrorHttpException('Failed to update the object for unknown reason.');
        }

        return $model;
    }