AuthForm::rules() - Code Metrics - Inspection of "Fixauth8" - ROAResearch/yii2-oauth2-server - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#6)

by Angel

created 2022-10-28 20:05 UTC

AuthForm::rules() A

↳ Parent: AuthForm

Complexity

Conditions	3
Paths	1

Size

Total Lines	57
Code Lines	35

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	3
eloc	35
nc	1
nop	0
dl	0
loc	57
rs	9.36
c	0
b	0
f	0

How to fix Long Method

<?php

namespace roaresearch\yii2\oauth2server\models;

use Yii;
use yii\db\IntegrityException;

class AuthForm extends \yii\base\Model
{
    public ?bool $authorized = null;
    public ?string $client_id = null;
    public ?string $scopes = null;
    public ?string $response_type = null;
    public ?string $state = null;
    public ?string $redirect_uri = null;

    protected ?OauthClients $clientModel = null;
    protected array $scopesList = [];

    public function rules()
    {
        $validatedClient = fn () => !$this->hasErrors('client_id');

        return [
            [
                [
                    'authorized',
                    'client_id',
                    'response_type',
                    'state',
                    'redirect_uri',
                ],
                'required',
            ],
            [['authorized'], 'boolean'],
            [['redirect_uri'], 'url'],
            [
                [
                    'client_id',
                    'scopes',
                    'response_type',
                    'state',
                    'redirect_uri',
                ],
                'string',
            ],
            [
                ['client_id'],
                'exist',
                'targetClass' => OauthClients::class,
            ],
            [
                ['scopes'],
                function ($attribute) {
                    try {
                         $this->getScopesList();
                    } catch (IntegrityException $e) {
                         $this->addError($atribute, $e->getMessage());

                    }
                },
                'when' => $validatedClient,
            ],
            [
                ['redirect_uri'],
                function ($attribute) {
                    if (
                        !$this->getClientModel()
                            ->validateUri($this->redirect_uri)
                            ->validateUri(/** @scrutinizer ignore-type */ $this->redirect_uri)
                    ) {
                        $this->addError(
                            $attribute,
                            "Redirection URI not recognized by client."
                        );
                    }
                },
                'when' => $validatedClient,
            ],
        ];
    }

    public function getClientModel(): ?OauthClients
    {
        if (empty($this->client_id) || isset($this->clientModel)) {
            return $this->clientModel;
        }

        $this->clientModel = OauthClients::findOne($this->client_id)
            ?: throw new IntegrityException(
                "Unknown client '{$this->client_id}'"
            );

        return $this->clientModel;
    }

    public function getScopesList(): array
    {
        if (empty($this->scopes) || !empty($this->scopesList)) {
            return $this->scopesList;
        }

        $clientModel = $this->getClientModel();
        foreach (explode(' ', $this->scopes) as $scope) {
            $this->scopesList[$scope] = $clientModel->assureScope($scope);
        }

        return $this->scopesList;
    }
}


ROAResearch / yii2-oauth2-server

Pull Request — master (#6)

AuthForm::rules() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like