MigrationsLoader::getFilesPath() - Code Metrics - Inspection of "Created more loaders." - RFreij/laravel-modulize-api - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 762407...a7439c )

by Roy

created 2019-02-20 05:07 UTC

MigrationsLoader::getFilesPath() A

↳ Parent: MigrationsLoader

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	1
dl	0
loc	3
rs	10
c	0
b	0
f	0

<?php

namespace LaravelModulize\Services\Loaders;

use Illuminate\Support\Collection;
use LaravelModulize\Contracts\LoadsFiles;
use Illuminate\Contracts\Foundation\Application;
use LaravelModulize\Contracts\ModulizerRepositoryInterface;

class MigrationsLoader extends BaseFileLoader implements LoadsFiles
{
    /**
     * Load the files to load and register them
     *
     * @param string $module
     * @return void
     */
    public function loadFiles(string $module): void
    {
        if (!$this->getFilesToLoad($module)->isEmpty()) {
            $this->repo->migrations[] = $this->getFilesPath($module);

        }
    }

    /**
     * Retrieve the path where the files to load should be at
     *
     * @param string $module
     * @return string
     */
    public function getFilesPath(string $module): string
    {
        return $this->repo->getModulePath($module) . "/database/migrations";
    }

    /**
     * Retrieve the namespace to be used when registering the files
     *
     * @param string $module
     * @return string
     */
    public function getNamespace(string $module): string
    {
        return $this->repo
            ->getModuleNamespace($module);
    }

}


1			<?php
2
3			namespace LaravelModulize\Services\Loaders;
4
5			use Illuminate\Support\Collection;
6			use LaravelModulize\Contracts\LoadsFiles;
7			use Illuminate\Contracts\Foundation\Application;
8			use LaravelModulize\Contracts\ModulizerRepositoryInterface;
9
10			class MigrationsLoader extends BaseFileLoader implements LoadsFiles
11			{
12			/**
13			* Load the files to load and register them
14			*
15			* @param string $module
16			* @return void
17			*/
18			public function loadFiles(string $module): void
19			{
20			if (!$this->getFilesToLoad($module)->isEmpty()) {
21			$this->repo->migrations[] = $this->getFilesPath($module);
			0 ignored issues – show Bug introduced 2019-02-20 05:12 UTC by Report Bug Copy Issue Report Accessing `migrations` on the interface `LaravelModulize\Contract...izerRepositoryInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? Loading history...
22			}
23			}
24
25			/**
26			* Retrieve the path where the files to load should be at
27			*
28			* @param string $module
29			* @return string
30			*/
31			public function getFilesPath(string $module): string
32			{
33			return $this->repo->getModulePath($module) . "/database/migrations";
34			}
35
36			/**
37			* Retrieve the namespace to be used when registering the files
38			*
39			* @param string $module
40			* @return string
41			*/
42			public function getNamespace(string $module): string
43			{
44			return $this->repo
45			->getModuleNamespace($module);
46			}
47
48			}
49

RFreij / laravel-modulize-api

Push — master ( 762407...a7439c )

MigrationsLoader::getFilesPath() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like