RestResponse::getPaginatorRouteGenerator() - Code Metrics - Inspection of "Fixes after real world use cases" - R3VoLuT1OneR/laravel-doctrine-rest - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 99f6c2...5bcbf0 )

by Pavel

created 2017-11-09 22:32 UTC

RestResponse::getPaginatorRouteGenerator() A

↳ Parent: RestResponse

Complexity

Conditions	2
Paths	2

Size

Total Lines	16
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
cc	2
eloc	8
nc	2
nop	1
dl	0
loc	16
ccs	0
cts	9
cp	0
crap	6
rs	9.4285
c	0
b	0
f	0

<?php namespace Pz\LaravelDoctrine\Rest;

use Illuminate\Routing\UrlGenerator;
use Pz\Doctrine\Rest\Response\FractalResponse;
use Pz\Doctrine\Rest\RestRequestInterface;
use Pz\LaravelDoctrine\Rest\Request\IndexRestRequest;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;

class RestResponse extends FractalResponse
{
    /**
     * @param RestRequestInterface $request
     * @throws NotFoundHttpException
     * @return void
     */
    public function notFound(RestRequestInterface $request)
    {
        throw new NotFoundHttpException();
    }

    /**
     * @param RestRequest $request
     *
     * @return \Closure
     */
    protected function getPaginatorRouteGenerator($request)
    {
        if ($request instanceof IndexRestRequest) {
            $request = clone $request;

            return function(int $page) use ($request) {
                $request->query->set('page', [
                    'offset' => ($page - 1) * $request->getLimit(),
                    'limit' => $request->getLimit(),
                ]);

                return $request->getUri();
            };
        }

        return function() {};
    }

    /**
     * @return UrlGenerator
     */
    private function urlGenerator()

    {
        return app(UrlGenerator::class);
    }
}


1			<?php namespace Pz\LaravelDoctrine\Rest;
2
3			use Illuminate\Routing\UrlGenerator;
4			use Pz\Doctrine\Rest\Response\FractalResponse;
5			use Pz\Doctrine\Rest\RestRequestInterface;
6			use Pz\LaravelDoctrine\Rest\Request\IndexRestRequest;
7			use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
8
9			class RestResponse extends FractalResponse
10			{
11			/**
12			* @param RestRequestInterface $request
13			* @throws NotFoundHttpException
14			* @return void
15			*/
16			public function notFound(RestRequestInterface $request)
17			{
18			throw new NotFoundHttpException();
19			}
20
21			/**
22			* @param RestRequest $request
23			*
24			* @return \Closure
25			*/
26			protected function getPaginatorRouteGenerator($request)
27			{
28			if ($request instanceof IndexRestRequest) {
29			$request = clone $request;
30
31			return function(int $page) use ($request) {
32			$request->query->set('page', [
33			'offset' => ($page - 1) * $request->getLimit(),
34			'limit' => $request->getLimit(),
35			]);
36
37			return $request->getUri();
38			};
39			}
40
41			return function() {};
42			}
43
44			/**
45			* @return UrlGenerator
46			*/
47			private function urlGenerator()
			0 ignored issues – show Unused Code introduced 2017-11-09 22:38 UTC by Report Bug Copy Issue Report The method `urlGenerator()` is not used, and could be removed. This check looks for private methods that have been defined, but are not used inside the class. Loading history...
48			{
49			return app(UrlGenerator::class);
50			}
51			}
52

R3VoLuT1OneR / laravel-doctrine-rest

Push — master ( 99f6c2...5bcbf0 )

RestResponse::getPaginatorRouteGenerator() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like