IndexRestRequest::getOrderBy() - Code Metrics - Inspection of "Move to JsonAPI params" - R3VoLuT1OneR/laravel-doctrine-rest - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 81fe53...e7743d )

by Pavel

created 2017-11-01 22:45 UTC

IndexRestRequest::getOrderBy() B

↳ Parent: IndexRestRequest

Complexity

Conditions	5
Paths	5

Size

Total Lines	21
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	30

Importance

Changes

Metric	Value
cc	5
eloc	11
nc	5
nop	0
dl	0
loc	21
ccs	0
cts	16
cp	0
crap	30
rs	8.7624
c	0
b	0
f	0

<?php namespace Pz\LaravelDoctrine\Rest\Request;

use Illuminate\Validation\Factory;
use Doctrine\ORM\Query\Expr\OrderBy;

use Pz\LaravelDoctrine\Rest\RestRequest;
use Pz\Doctrine\Rest\Request\IndexRequestInterface;

class IndexRestRequest extends RestRequest implements IndexRequestInterface
{
    /**
     * @return array
     */
    public function rules()
    {
        return [
            // Query
            'filter'        => 'string',

            // Pagination
            'page'          => 'array',
            'page.offset'   => 'required_with:page|numeric',
            'page.limit'    => 'required_with:page|numeric',

            // Sorting
            'sort'          => 'string',
        ];
    }

    /**
     * @return string
     */
    public function ability()
    {
         return 'index';
    }

    /**
     * @return int
     */
    public function getStart()
    {
        return $this->input('page.offset', 0);
    }

    /**
     * @return int
     */
    public function getLimit()
    {
        return $this->input('page.limit', 50);
    }

    /**
     * @return array|null
     */
    public function getOrderBy()
    {
        if ($fields = explode(',', $this->get('sort'))) {
            $orderBy = [];

            foreach ($fields as $field) {
                if (empty($field)) continue;

                $direction = 'ASC';
                if ($field[0] === '-') {
                    $field = substr($field, 1);
                    $direction = 'DESC';
                }

                $orderBy[$field] = $direction;
            }

            return $orderBy;
        }

        return null;
    }

    /**
     * @return mixed|null
     */
    public function getQuery()
    {
        if ($query = $this->get('filter')) {
            if (is_string($query) && (null !== ($json = json_decode($query, true)))) {
                return $json;
            }

            return $query;
        }

        return null;
    }
}


1			<?php namespace Pz\LaravelDoctrine\Rest\Request;
2
3			use Illuminate\Validation\Factory;
4			use Doctrine\ORM\Query\Expr\OrderBy;
5
6			use Pz\LaravelDoctrine\Rest\RestRequest;
7			use Pz\Doctrine\Rest\Request\IndexRequestInterface;
8
9			class IndexRestRequest extends RestRequest implements IndexRequestInterface
10			{
11			/**
12			* @return array
13			*/
14			public function rules()
15			{
16			return [
17			// Query
18			'filter' => 'string',
19
20			// Pagination
21			'page' => 'array',
22			'page.offset' => 'required_with:page\|numeric',
23			'page.limit' => 'required_with:page\|numeric',
24
25			// Sorting
26			'sort' => 'string',
27			];
28			}
29
30			/**
31			* @return string
32			*/
33			public function ability()
34			{
35			return 'index';
36			}
37
38			/**
39			* @return int
40			*/
41			public function getStart()
42			{
43			return $this->input('page.offset', 0);
44			}
45
46			/**
47			* @return int
48			*/
49			public function getLimit()
50			{
51			return $this->input('page.limit', 50);
52			}
53
54			/**
55			* @return array\|null
56			*/
57			public function getOrderBy()
58			{
59			if ($fields = explode(',', $this->get('sort'))) {
60			$orderBy = [];
61
62			foreach ($fields as $field) {
63			if (empty($field)) continue;
64
65			$direction = 'ASC';
66			if ($field[0] === '-') {
67			$field = substr($field, 1);
68			$direction = 'DESC';
69			}
70
71			$orderBy[$field] = $direction;
72			}
73
74			return $orderBy;
75			}
76
77			return null;
78			}
79
80			/**
81			* @return mixed\|null
82			*/
83			public function getQuery()
84			{
85			if ($query = $this->get('filter')) {
86			if (is_string($query) && (null !== ($json = json_decode($query, true)))) {
87			return $json;
88			}
89
90			return $query;
91			}
92
93			return null;
94			}
95			}
96

R3VoLuT1OneR / laravel-doctrine-rest

Push — master ( 81fe53...e7743d )

IndexRestRequest::getOrderBy() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like