DeleteAction::delete() - Code Metrics - Inspection of "Aditional commit" - R3VoLuT1OneR/doctrine-rest - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 5f574e...cd391d )

by Pavel

created 2017-10-25 20:21 UTC

DeleteAction::delete() A

↳ Parent: DeleteAction

Complexity

Conditions	2
Paths	1

Size

Total Lines	12
Code Lines	6

Duplication

Lines	12
Ratio	100 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
cc	2
eloc	6
nc	1
nop	1
dl	12
loc	12
ccs	0
cts	7
cp	0
crap	6
rs	9.4285
c	0
b	0
f	0

<?php namespace Pz\Doctrine\Rest\Action;

use Pz\Doctrine\Rest\Request\DeleteRequestInterface;
use Pz\Doctrine\Rest\RestRepository;
use Pz\Doctrine\Rest\RestResponseInterface;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
filter:
    dependency_paths: ["lib/*"]

trait DeleteAction

{
    /**
     * Doctrine repository from where get data.
     *
     * @return RestRepository
     */
    abstract protected function repository();

    /**
     * @return RestResponseInterface
     */
    abstract protected function response();

    /**
     * @param DeleteRequestInterface $request
     *
     * @return array
     */
    public function delete(DeleteRequestInterface $request)
    {
        if (null === ($entity = $this->repository()->find($request->getId()))) {
            throw new NotFoundHttpException();
        }

        $request->authorize($entity);

        $this->repository()->em()->remove($entity);
        $this->repository()->em()->flush();

        return $this->response()->delete($request, $entity);
    }
}


1		<?php namespace Pz\Doctrine\Rest\Action;
2
3		use Pz\Doctrine\Rest\Request\DeleteRequestInterface;
4		use Pz\Doctrine\Rest\RestRepository;
5		use Pz\Doctrine\Rest\RestResponseInterface;
6		use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
		0 ignored issues – show Bug introduced 2017-10-25 20:23 UTC by Report Bug Copy Issue Report The type `Symfony\Component\HttpKe...n\NotFoundHttpException` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
7
8	View Code Duplication	trait DeleteAction
		0 ignored issues – show Duplication introduced 2017-10-25 20:23 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
9		{
10		/**
11		* Doctrine repository from where get data.
12		*
13		* @return RestRepository
14		*/
15		abstract protected function repository();
16
17		/**
18		* @return RestResponseInterface
19		*/
20		abstract protected function response();
21
22		/**
23		* @param DeleteRequestInterface $request
24		*
25		* @return array
26		*/
27		public function delete(DeleteRequestInterface $request)
28		{
29		if (null === ($entity = $this->repository()->find($request->getId()))) {
30		throw new NotFoundHttpException();
31		}
32
33		$request->authorize($entity);
34
35		$this->repository()->em()->remove($entity);
36		$this->repository()->em()->flush();
37
38		return $this->response()->delete($request, $entity);
39		}
40		}
41

R3VoLuT1OneR / doctrine-rest

Push — master ( 5f574e...cd391d )

DeleteAction::delete() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like