RelatedAction::related() - Code Metrics - Inspection of "Full test coverage" - R3VoLuT1OneR/doctrine-rest - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 2001b3...f7416c )

by Pavel

created 2018-04-16 12:29 UTC

RelatedAction::related() A

↳ Parent: RelatedAction

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	0
dl	0
loc	3
ccs	2
cts	2
cp	1
crap	1
rs	10
c	0
b	0
f	0

<?php namespace Pz\Doctrine\Rest\Traits;

use Pz\Doctrine\Rest\Exceptions\RestException;
use Pz\Doctrine\Rest\RestRepository;

trait RelatedAction
{
    /**
     * @var RestRepository
     */
    protected $related;

    /**
     * @var string
     */
    protected $field;

    /**
     * @var string
     */
    protected $mappedBy;

    /**
     * Related repository.
     *
     * @return RestRepository
     */
    public function related()
    {
        return $this->related;
    }

    /**
     * `field` on base entity that identify relation.
     *
     * @return string
     */
    public function field()
    {
        return $this->field;
    }

    /**
     * @return string
     */
    public function mappedBy()
    {
        return $this->mappedBy;
    }

    /**
     * @param $item
     *
     * @return null|object
     * @throws RestException
     */
    protected function getRelatedEntity($item)
    {
        if (!isset($item['id']) || !isset($item['type'])) {
            throw RestException::createUnprocessable('Relation item without identifiers.')
                ->error(
                    'invalid-data',
                    ['pointer' => $this->field()],
                    'Relation item without `id` or `type`.'
                );
        }

        if ($this->related()->getResourceKey() !== $item['type']) {
            throw RestException::createUnprocessable('Different resource type in delete request.')
                ->error('invalid-data', ['pointer' => $this->field()], 'Type is not in sync with relation.');
        }

        return $this->related()->findById($item['id']);

    }
}


1		<?php namespace Pz\Doctrine\Rest\Traits;
2
3		use Pz\Doctrine\Rest\Exceptions\RestException;
4		use Pz\Doctrine\Rest\RestRepository;
5
6		trait RelatedAction
7		{
8		/**
9		* @var RestRepository
10		*/
11		protected $related;
12
13		/**
14		* @var string
15		*/
16		protected $field;
17
18		/**
19		* @var string
20		*/
21		protected $mappedBy;
22
23		/**
24		* Related repository.
25		*
26		* @return RestRepository
27		*/
28	7	public function related()
29		{
30	7	return $this->related;
31		}
32
33		/**
34		* `field` on base entity that identify relation.
35		*
36		* @return string
37		*/
38	10	public function field()
39		{
40	10	return $this->field;
41		}
42
43		/**
44		* @return string
45		*/
46	5	public function mappedBy()
47		{
48	5	return $this->mappedBy;
49		}
50
51		/**
52		* @param $item
53		*
54		* @return null\|object
55		* @throws RestException
56		*/
57	7	protected function getRelatedEntity($item)
58		{
59	7	if (!isset($item['id']) \|\| !isset($item['type'])) {
60	1	throw RestException::createUnprocessable('Relation item without identifiers.')
61	1	->error(
62	1	'invalid-data',
63	1	['pointer' => $this->field()],
64	1	'Relation item without `id` or `type`.'
65		);
66		}
67
68	7	if ($this->related()->getResourceKey() !== $item['type']) {
69	1	throw RestException::createUnprocessable('Different resource type in delete request.')
70	1	->error('invalid-data', ['pointer' => $this->field()], 'Type is not in sync with relation.');
71		}
72
73	6	return $this->related()->findById($item['id']);
		0 ignored issues – show Bug Best Practice introduced 2018-04-16 11:32 UTC by Report Bug Copy Issue Report The expression `return $this->related()->findById($item['id'])` returns the type `Pz\Doctrine\Rest\Contracts\JsonApiResource` which is incompatible with the documented return type `object\|null`. Loading history...
74		}
75		}
76

R3VoLuT1OneR / doctrine-rest

Push — master ( 2001b3...f7416c )

RelatedAction::related() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like