BasicFeaturesControllerTest::testControllerWithControllerBasicFeaturesTraitHasMethods() - Code Metrics - Inspection of "Initialisation" - QualityCodePhp/ApiFeaturesBundle - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Pull Request — master (#1)

by Flavien

created 2017-01-02 18:19 UTC

testControllerWithControllerBasicFeaturesTraitHasMethods() A

↳ Parent: BasicFeaturesControllerTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	7
rs	9.4285
c	0
b	0
f	0
nc	1
cc	1
eloc	3
nop	0

<?php

namespace QualityCode\ApiFeaturesBundle\Tests\Unit\Controller;

use QualityCode\ApiFeaturesBundle\Tests\App\Controller\BasicFeaturesController;
use Symfony\Component\HttpFoundation\JsonResponse;

class BasicFeaturesControllerTest extends \PHPUnit_Framework_TestCase
{
    private $controller = null;

    protected function setUp()
    {
        $this->controller = new BasicFeaturesController();
    }

    protected function tearDown()
    {
        $this->controller = null;
    }

    public function testControllerWithControllerBasicFeaturesTraitHasMethods()
    {
        $traitName = "\QualityCode\ApiFeaturesBundle\Controller\ControllerBasicFeaturesTrait";
        $behavior = $this->getMockForTrait($traitName);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        //$this->assertInstanceOf(JsonResponse::class, $this->controller->barAction());

    }
}


1			<?php
2
3			namespace QualityCode\ApiFeaturesBundle\Tests\Unit\Controller;
4
5			use QualityCode\ApiFeaturesBundle\Tests\App\Controller\BasicFeaturesController;
6			use Symfony\Component\HttpFoundation\JsonResponse;
7
8			class BasicFeaturesControllerTest extends \PHPUnit_Framework_TestCase
9			{
10			private $controller = null;
11
12			protected function setUp()
13			{
14			$this->controller = new BasicFeaturesController();
15			}
16
17			protected function tearDown()
18			{
19			$this->controller = null;
20			}
21
22			public function testControllerWithControllerBasicFeaturesTraitHasMethods()
23			{
24			$traitName = "\QualityCode\ApiFeaturesBundle\Controller\ControllerBasicFeaturesTrait";
25			$behavior = $this->getMockForTrait($traitName);
			0 ignored issues – show Unused Code introduced 2017-01-02 18:28 UTC by Report Bug Copy Issue Report `$behavior` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
26
27			//$this->assertInstanceOf(JsonResponse::class, $this->controller->barAction());
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-01-02 18:28 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
28			}
29			}
30

QualityCodePhp / ApiFeaturesBundle

Pull Request — master (#1)

testControllerWithControllerBasicFeaturesTraitHasMethods() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like