Qoraiche\MailEclipse\Http\Controllers\TemplatesController

Complexity

Total Complexity

11

Size/Duplication

Total Lines	68
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	select()	0	5	1
A	update()	0	3	1
A	view()	0	9	2
A	index()	0	7	1
A	delete()	0	9	2
A	__construct()	0	6	1
A	create()	0	3	1
A	new()	0	7	2

<?php

namespace Qoraiche\MailEclipse\Http\Controllers;

use Illuminate\Http\Request;
use Illuminate\Routing\Controller;
use Illuminate\Support\Facades\App;
use Qoraiche\MailEclipse\Facades\MailEclipse;
use Qoraiche\MailEclipse\Utils\TemplateSkeletons;

class TemplatesController extends Controller
{
    public function __construct()
    {
        abort_unless(
            App::environment(config('maileclipse.allowed_environments', ['local'])),

It seems like Illuminate\Support\Facades\App::environment(config('maileclipse.allowed_environments', array('local'))) can also be of type string; however, parameter $boolean of abort_unless() does only seem to accept boolean, maybe add an additional type check?

            403,
            'Environment Not Allowed'
        );
    }

    public function index()
    {
        $skeletons = TemplateSkeletons::skeletons();

        $templates = MailEclipse::getTemplates();

        return View(MailEclipse::VIEW_NAMESPACE.'::sections.templates', compact('skeletons', 'templates'));
    }

    public function new($type, $name, $skeleton)
    {
        $type = $type === 'html' ? $type : 'markdown';

        $skeleton = TemplateSkeletons::get($type, $name, $skeleton);

        return View(MailEclipse::VIEW_NAMESPACE.'::sections.create-template', compact('skeleton'));
    }

    public function view($templateslug = null)
    {
        $template = MailEclipse::getTemplate($templateslug);

        if (is_null($template)) {
            return redirect()->route('templateList');
        }

        return View(MailEclipse::VIEW_NAMESPACE.'::sections.edit-template', compact('template'));
    }

    public function create(Request $request)
    {
        return MailEclipse::createTemplate($request);
    }

    public function select(Request $request)

The parameter $request is not used and could be removed.

    {
        $skeletons = TemplateSkeletons::skeletons();

        return View(MailEclipse::VIEW_NAMESPACE.'::sections.new-template', compact('skeletons'));
    }

    public function delete(Request $request)
    {
        if (MailEclipse::deleteTemplate($request->templateslug)) {
            return response()->json([
                'status' => 'ok',
            ]);
        } else {
            return response()->json([
                'status' => 'error',
            ]);
        }
    }

    public function update(Request $request)
    {
        return MailEclipse::updateTemplate($request);
    }
}