Qeti / POData

services/NorthWind/NorthWindMetadata.php

Unused Use Statements -9 removed lines

@@ -1,17 +1,8 @@
 <?php
 
 use POData\Providers\Metadata\ResourceStreamInfo;
-use POData\Providers\Metadata\ResourceAssociationSetEnd;
-use POData\Providers\Metadata\ResourceAssociationSet;
-use POData\Common\NotImplementedException;
 use POData\Providers\Metadata\Type\EdmPrimitiveType;
-use POData\Providers\Metadata\ResourceSet;
-use POData\Providers\Metadata\ResourcePropertyKind;
-use POData\Providers\Metadata\ResourceProperty;
-use POData\Providers\Metadata\ResourceTypeKind;
-use POData\Providers\Metadata\ResourceType;
 use POData\Common\InvalidOperationException;
-use POData\Providers\Metadata\IMetadataProvider;
 require_once 'POData\Providers\Metadata\IDataServiceMetadataProvider.php';
 use POData\Providers\Metadata\SimpleMetadataProvider;
 //Begin Resource Classes

services/WordPress/WordPressDataService.php

Unused Use Statements -5 removed lines

@@ -8,11 +8,6 @@
 use POData\Configuration\ProtocolVersion;
 use POData\Configuration\ServiceConfiguration;
 use POData\BaseService;
-use POData\OperationContext\ServiceHost;
-use POData\Common\ODataException;
-use POData\Common\ODataConstants;
-use POData\Common\Messages;
-use POData\UriProcessor\UriProcessor;
 require_once 'WordPressMetadata.php';
 require_once 'WordPressQueryProvider.php';
 require_once 'WordPressDSExpressionProvider.php';

Spacing +1 added lines, -1 removed lines

@@ -53,7 +53,7 @@
      */
     public function getService($serviceType)
     {
-      if(($serviceType === 'IMetadataProvider') ||
+      if (($serviceType === 'IMetadataProvider') ||
         ($serviceType === 'IQueryProvider') ||
         ($serviceType === 'IStreamProvider')) {
         if (is_null($this->_wordPressExpressionProvider)) {

services/WordPress/WordPressDSExpressionProvider.php

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 use POData\UriProcessor\QueryProcessor\ExpressionParser\Expressions\ExpressionType;
 use POData\Providers\Metadata\Type\IType;
-use POData\Common\NotImplementedException;
 use POData\Common\ODataConstants;
 use POData\Providers\Expression\IExpressionProvider;
 use POData\Providers\Metadata\ResourceType;

Spacing +11 added lines, -12 removed lines

@@ -84,7 +84,7 @@ 
      */
     public function onLogicalExpression($expressionType, $left, $right)
     {
-        switch($expressionType) {
+        switch ($expressionType) {
         case ExpressionType::AND_LOGICAL:
             return $this->_prepareBinaryExpression(self::LOGICAL_AND, $left, $right);
             break;
@@ -107,7 +107,7 @@ 
      */
     public function onArithmeticExpression($expressionType, $left, $right)
     {
-        switch($expressionType) {
+        switch ($expressionType) {
         case ExpressionType::MULTIPLY:
             return $this->_prepareBinaryExpression(self::MULTIPLY, $left, $right);
             break;
@@ -139,7 +139,7 @@ 
      */
     public function onRelationalExpression($expressionType, $left, $right)
     {
-        switch($expressionType) {
+        switch ($expressionType) {
         case ExpressionType::GREATERTHAN:
             return $this->_prepareBinaryExpression(self::GREATERTHAN, $left, $right);
             break;
@@ -177,7 +177,7 @@ 
      */
     public function onUnaryExpression($expressionType, $child)
     {
-        switch($expressionType) {
+        switch ($expressionType) {
         case ExpressionType::NEGATE:
             return $this->_prepareUnaryExpression(self::NEGATE, $child);
             break;
@@ -243,7 +243,7 @@ 
      */
     public function onFunctionCallExpression($functionDescription, $params)
     {
-        switch($functionDescription->functionName) {
+        switch ($functionDescription->functionName) {
         case ODataConstants::STRFUN_COMPARE:
             return "STRCMP($params[0], $params[1])";
             break;
@@ -270,8 +270,7 @@ 
             break;
         case ODataConstants::STRFUN_SUBSTRING:
             return count($params) == 3 ?
-                "SUBSTRING($params[0], $params[1] + 1, $params[2])" :
-                "SUBSTRING($params[0], $params[1] + 1)";
+                "SUBSTRING($params[0], $params[1] + 1, $params[2])" : "SUBSTRING($params[0], $params[1] + 1)";
             break;
         case ODataConstants::STRFUN_SUBSTRINGOF:
             return "(LOCATE($params[0], $params[1]) > 0)";
@@ -343,14 +342,14 @@ 
         $str = explode(';', $left, 2);
         $str[0] = str_replace('DATETIMECMP', '', $str[0]);
         return self::OPEN_BRAKET
-          . $str[0] . ' ' . $operator
-          . ' ' . $str[1] . self::CLOSE_BRACKET;
+          . $str[0].' '.$operator
+          . ' '.$str[1].self::CLOSE_BRACKET;
       }
 
         return 
             self::OPEN_BRAKET 
-            . $left . ' ' . $operator 
-            . ' ' . $right . self::CLOSE_BRACKET;
+            . $left.' '.$operator 
+            . ' '.$right.self::CLOSE_BRACKET;
     }
 
     /**
@@ -363,6 +362,6 @@ 
      */
     private function _prepareUnaryExpression($operator, $child)
     {
-        return $operator . self::OPEN_BRAKET . $child . self::CLOSE_BRACKET;
+        return $operator.self::OPEN_BRAKET.$child.self::CLOSE_BRACKET;
     }
 }

services/WordPress/WordPressMetadata.php

Unused Use Statements -11 removed lines

@@ -1,20 +1,9 @@
 <?php
 
-use POData\Providers\Metadata\ResourceStreamInfo;
-use POData\Providers\Metadata\ResourceAssociationSetEnd;
-use POData\Providers\Metadata\ResourceAssociationSet;
-use POData\Common\NotImplementedException;
 use POData\Providers\Metadata\Type\EdmPrimitiveType;
-use POData\Providers\Metadata\ResourceSet;
-use POData\Providers\Metadata\ResourcePropertyKind;
-use POData\Providers\Metadata\ResourceProperty;
-use POData\Providers\Metadata\ResourceTypeKind;
-use POData\Providers\Metadata\ResourceType;
 use POData\Common\InvalidOperationException;
-use POData\Providers\Metadata\IMetadataProvider;
 require_once 'POData\Providers\Metadata\IDataServiceMetadataProvider.php';
 use POData\Providers\Metadata\SimpleMetadataProvider;
-use POData\Providers\Metadata\MetadataMapping;
 
 //Begin Resource Classes
 

Spacing +6 added lines, -6 removed lines

@@ -297,8 +297,8 @@ 
     public static function getEntityMapping() {
       if (!is_null(self::$_entityMapping))
       {
-        self::$_entityMapping = array (
-            'Post' => array (
+        self::$_entityMapping = array(
+            'Post' => array(
                 '$MappedTable$' => 'wp_posts',
                 'PostID' => 'ID',
                 'Author' => 'post_author',
@@ -324,7 +324,7 @@ 
                 'CommentCount' => 'comment_count'
               ),
           
-            'Tag' => array (
+            'Tag' => array(
                 '$MappedTable$' => 'wp_terms',
                 'TagID' =>'t.term_id',
                 'Name' =>'t.name',
@@ -332,7 +332,7 @@ 
                 'Description' =>'tt.description'
             ),
           
-            'Category' => array (
+            'Category' => array(
                 '$MappedTable$' => 'wp_terms',
                 'CategoryID' =>'t.term_id',
                 'Name' =>'t.name',
@@ -340,7 +340,7 @@ 
                 'Description' =>'tt.description'
             ),
           
-            'Comment' => array (
+            'Comment' => array(
                 '$MappedTable$' => 'wp_comments',
                 'CommentID', 'comment_id',
                 'PostID', 'comment_post_id',
@@ -358,7 +358,7 @@ 
                 'UserID', 'user_id'
             ),
           
-            'User' => array (
+            'User' => array(
                 '$MappedTable$' => 'wp_users',
                 'UserID' => 'ID',
                 'Login' => 'user_login',

src/POData/BaseService.php

Unused Use Statements -3 removed lines

@@ -5,7 +5,6 @@ 
 use POData\Common\MimeTypes;
 use POData\Common\Version;
 use POData\OperationContext\HTTPRequestMethod;
-use POData\Providers\Metadata\ResourceTypeKind;
 use POData\Common\ErrorHandler;
 use POData\Common\Messages;
 use POData\Common\ODataException;
@@ -30,11 +29,9 @@ 
 use POData\Writers\Json\JsonODataV1Writer;
 use POData\Writers\Json\JsonODataV2Writer;
 use POData\Writers\ResponseWriter;
-
 use POData\Providers\Query\IQueryProvider;
 use POData\Providers\Metadata\IMetadataProvider;
 use POData\OperationContext\IOperationContext;
-
 use POData\Writers\ODataWriterRegistry;
 
 /**

Spacing +16 added lines, -16 removed lines

@@ -316,11 +316,11 @@ 
 		$registry->register(new JsonODataV1Writer());
 		$registry->register(new AtomODataWriter($serviceURI));
 
-		if($serviceVersion->compare(Version::v2()) > -1){
+		if ($serviceVersion->compare(Version::v2()) > -1) {
 			$registry->register(new JsonODataV2Writer());
 		}
 
-		if($serviceVersion->compare(Version::v3()) > -1){
+		if ($serviceVersion->compare(Version::v3()) > -1) {
 			$registry->register(new JsonLightODataWriter(JsonLightMetadataLevel::NONE(), $serviceURI));
 			$registry->register(new JsonLightODataWriter(JsonLightMetadataLevel::MINIMAL(), $serviceURI));
 			$registry->register(new JsonLightODataWriter(JsonLightMetadataLevel::FULL(), $serviceURI));
@@ -351,7 +351,7 @@ 
 
 	    if (is_null($responseContentType) && $request->getTargetKind() != TargetKind::MEDIA_RESOURCE()) {
 		    //the responseContentType can ONLY be null if it's a stream (media resource) and that stream is storing null as the content type
-		    throw new ODataException( Messages::unsupportedMediaType(), 415 );
+		    throw new ODataException(Messages::unsupportedMediaType(), 415);
 	    }
 
 	    $odataModelInstance = null;
@@ -518,10 +518,10 @@ 
 
 	    //if the $format header is present it overrides the accepts header
 	    $format = $host->getQueryStringItem(ODataConstants::HTTPQUERY_STRING_FORMAT);
-	    if(!is_null($format)){
+	    if (!is_null($format)) {
 
             //There's a strange edge case..if application/json is supplied and it's V3
-            if($format == MimeTypes::MIME_APPLICATION_JSON && $requestVersion == Version::v3()){
+            if ($format == MimeTypes::MIME_APPLICATION_JSON && $requestVersion == Version::v3()) {
                 //then it's actual minimalmetadata
                 //TODO: should this be done with the header text too?
                 $format = MimeTypes::MIME_APPLICATION_JSON_MINIMAL_META;
@@ -537,7 +537,7 @@ 
 	    //getTargetKind doesn't deal with link resources directly and this can change things
 	    $targetKind = $request->isLinkUri() ? TargetKind::LINK() : $request->getTargetKind();
 
-	    switch($targetKind){
+	    switch ($targetKind) {
 		    case TargetKind::METADATA():
 			    return HttpProcessUtility::selectMimeType(
 				    $requestAcceptText,
@@ -614,7 +614,7 @@ 
 			    );
 
 		    case TargetKind::MEDIA_RESOURCE():
-			    if (!$request->isNamedStream() && !$request->getTargetResourceType()->isMediaLinkEntry()){
+			    if (!$request->isNamedStream() && !$request->getTargetResourceType()->isMediaLinkEntry()) {
 					throw ODataException::createBadRequestError(
 					    Messages::badRequestInvalidUriForMediaResource(
 						    $host->getAbsoluteRequestUri()->getUrlAsString()
@@ -648,7 +648,7 @@ 
 
 
 	    //If we got here, we just don't know what it is...
-        throw new ODataException( Messages::unsupportedMediaType(), 415 );
+        throw new ODataException(Messages::unsupportedMediaType(), 415);
 
     }
 
@@ -669,7 +669,7 @@ 
      * @return string|null The ETag for the entry object if it has eTag properties 
      *                     NULL otherwise.
      */
-    protected function compareETag(&$entryObject, ResourceType &$resourceType, 
+    protected function compareETag(&$entryObject, ResourceType & $resourceType, 
         &$needToSerializeResponse
     ) {      
         $needToSerializeResponse = true;
@@ -720,7 +720,7 @@ 
             // but that is causing an issue in Linux env where the 
             // firefix browser is unable to parse the ETag in this case.
             // Need to follow up PHP core devs for this. 
-            $eTag = ODataConstants::HTTP_WEAK_ETAG_PREFIX . $eTag . '"';
+            $eTag = ODataConstants::HTTP_WEAK_ETAG_PREFIX.$eTag.'"';
             if (!is_null($ifMatch)) {
                 if (strcmp($eTag, $ifMatch) != 0) {
                     // Requested If-Match value does not match with current 
@@ -743,7 +743,7 @@ 
             // but that is causing an issue in Linux env where the 
             // firefix browser is unable to parse the ETag in this case.
             // Need to follow up PHP core devs for this. 
-            $eTag = ODataConstants::HTTP_WEAK_ETAG_PREFIX . $eTag . '"';
+            $eTag = ODataConstants::HTTP_WEAK_ETAG_PREFIX.$eTag.'"';
         }
 
         return $eTag;
@@ -762,7 +762,7 @@ 
      *                     for use in a URI) there are etag properties, NULL if 
      *                     there is no etag property.
      */
-    protected function getETagForEntry(&$entryObject, ResourceType &$resourceType)
+    protected function getETagForEntry(&$entryObject, ResourceType & $resourceType)
     {
         $eTag = null;
         $comma = null;
@@ -777,18 +777,18 @@ 
             try {
 
 	            //TODO #88...also this seems like dupe work
-                $reflectionProperty  = new \ReflectionProperty($entryObject, $eTagProperty->getName() );
+                $reflectionProperty = new \ReflectionProperty($entryObject, $eTagProperty->getName());
                 $value = $reflectionProperty->getValue($entryObject);
             } catch (\ReflectionException $reflectionException) {
                 throw ODataException::createInternalServerError(
-                    Messages::failedToAccessProperty($eTagProperty->getName(), $resourceType->getName() )
+                    Messages::failedToAccessProperty($eTagProperty->getName(), $resourceType->getName())
                 );
             }
 
             if (is_null($value)) {
-                $eTag = $eTag . $comma. 'null';
+                $eTag = $eTag.$comma.'null';
             } else {
-                $eTag = $eTag . $comma . $type->convertToOData($value);
+                $eTag = $eTag.$comma.$type->convertToOData($value);
             }
 
             $comma = ',';

src/POData/Common/ErrorHandler.php

Unused Use Statements -2 removed lines

@@ -4,9 +4,7 @@
 
 
 use POData\Writers\Json\JsonODataV2Writer;
-
 use POData\Writers\Atom\AtomODataWriter;
-use POData\BaseService;
 use POData\HttpProcessUtility;
 use POData\IService;
 

Spacing +1 added lines, -1 removed lines

@@ -53,7 +53,7 @@
             $exception = new ODataException($exception->getMessage(), HttpStatus::CODE_INTERNAL_SERVER_ERROR);
         }
 
-        $service->getHost()->setResponseVersion(ODataConstants::DATASERVICEVERSION_1_DOT_0 . ';');
+        $service->getHost()->setResponseVersion(ODataConstants::DATASERVICEVERSION_1_DOT_0.';');
 
         // At this point all kind of exceptions will be converted 
         //to 'ODataException' 

src/POData/ObjectModel/ObjectModelSerializer.php

Unused Use Statements -2 removed lines

@@ -12,10 +12,8 @@
 use POData\Providers\Metadata\ResourceTypeKind;
 use POData\Providers\Metadata\ResourcePropertyKind;
 use POData\Providers\Metadata\ResourceProperty;
-use POData\Providers\ProvidersWrapper;
 use POData\Providers\Metadata\Type\Binary;
 use POData\Providers\Metadata\Type\Boolean;
-use POData\Providers\Metadata\Type\String;
 use POData\Providers\Metadata\Type\DateTime;
 use POData\Common\ODataException;
 use POData\Common\Messages;

Spacing +30 added lines, -31 removed lines

@@ -140,7 +140,7 @@ 
                 $this->getCurrentResourceSetWrapper()->getName()
             );
             
-            $url->url = rtrim($this->absoluteServiceUri, '/') . '/' . $relativeUri;
+            $url->url = rtrim($this->absoluteServiceUri, '/').'/'.$relativeUri;
         }
 
         return $url;
@@ -191,7 +191,7 @@ 
     public function writeTopLevelComplexObject(
 	    &$complexValue,
         $propertyName,
-        ResourceType &$resourceType
+        ResourceType & $resourceType
     ) {
 	    $propertyContent = new ODataPropertyContent();
         $this->_writeComplexValue(
@@ -218,7 +218,7 @@ 
     public function writeTopLevelBagObject(
 	    &$BagValue,
         $propertyName,
-        ResourceType &$resourceType
+        ResourceType & $resourceType
     ) {
 
 	    $propertyContent = new ODataPropertyContent();
@@ -245,7 +245,7 @@ 
      */
     public function writeTopLevelPrimitive(
 	    &$primitiveValue,
-        ResourceProperty &$resourceProperty
+        ResourceProperty & $resourceProperty
     ) {
 	    $propertyContent = new ODataPropertyContent();
 	    $propertyContent->properties[] = new ODataProperty();
@@ -287,7 +287,7 @@ 
                 $this->getCurrentResourceSetWrapper()->getName()
             );
 
-            $absoluteUri = rtrim($this->absoluteServiceUri, '/') . '/' . $relativeUri;
+            $absoluteUri = rtrim($this->absoluteServiceUri, '/').'/'.$relativeUri;
             $title = $resourceType->getName();
             //TODO Resolve actual resource type
             $actualResourceType = $resourceType;
@@ -334,18 +334,18 @@ 
      */
     private function _writeFeedElements(
         &$entryObjects,
-        ResourceType &$resourceType,
+        ResourceType & $resourceType,
         $title,
         $absoluteUri,
         $relativeUri,
-        ODataFeed &$feed
+        ODataFeed & $feed
     ) {
         $this->assert(is_array($entryObjects), '_writeFeedElements::is_array($entryObjects)');
         $feed->id = $absoluteUri;
         $feed->title = $title;
         $feed->selfLink = new ODataLink();
         $feed->selfLink->name = ODataConstants::ATOM_SELF_RELATION_ATTRIBUTE_VALUE;
-        $feed->selfLink->title =  $title;
+        $feed->selfLink->title = $title;
         $feed->selfLink->url = $relativeUri;
         
         if (empty($entryObjects)) {
@@ -389,11 +389,11 @@ 
      */
     private function _writeObjectProperties(
 	    $customObject,
-        ResourceType &$resourceType, 
+        ResourceType & $resourceType, 
         $absoluteUri, 
         $relativeUri, 
         &$odataEntry, 
-        ODataPropertyContent &$odataPropertyContent
+        ODataPropertyContent & $odataPropertyContent
     ) {
         $resourceTypeKind = $resourceType->getResourceTypeKind();
         if (is_null($absoluteUri) == ($resourceTypeKind == ResourceTypeKind::ENTITY)
@@ -464,7 +464,7 @@ 
                         $propertyValue,
                         $resourceProperty->getName(),
                         $resourceType2,
-                        $relativeUri . '/' . $resourceProperty->getName(),
+                        $relativeUri.'/'.$resourceProperty->getName(),
                         $odataPropertyContent
                     );
                 } else {
@@ -476,7 +476,7 @@ 
                             $propertyValue,
                             $resourceProperty->getName(),
                             $resourceType1,
-                            $relativeUri . '/' . $resourceProperty->getName(),
+                            $relativeUri.'/'.$resourceProperty->getName(),
                             $odataPropertyContent
                         );
                     } else if ($resourceProperty->getKind() == ResourcePropertyKind::PRIMITIVE 
@@ -541,7 +541,7 @@ 
                         $propertyValue,
                         $propertyName,
                         $bagResourceType,
-                        $relativeUri . '/' . $propertyName,
+                        $relativeUri.'/'.$propertyName,
                         $odataPropertyContent
                     );
                 } else if (ResourceProperty::sIsKindOf($propertyTypeKind, ResourcePropertyKind::PRIMITIVE)) {
@@ -554,7 +554,7 @@ 
                         $propertyValue,
                         $propertyName,
                         $complexResourceType,
-                        $relativeUri . '/' . $propertyName,
+                        $relativeUri.'/'.$propertyName,
                         $odataPropertyContent
                     );
                 } else {
@@ -569,17 +569,16 @@ 
             foreach ($navigationProperties as $navigationPropertyInfo) {
                 $propertyName = $navigationPropertyInfo->resourceProperty->getName();
                 $type = $navigationPropertyInfo->resourceProperty->getKind() == ResourcePropertyKind::RESOURCE_REFERENCE ? 
-                    'application/atom+xml;type=entry':
-                    'application/atom+xml;type=feed';
+                    'application/atom+xml;type=entry' : 'application/atom+xml;type=feed';
                 $link = new ODataLink();
-                $link->name = ODataConstants::ODATA_RELATED_NAMESPACE . $propertyName; 
+                $link->name = ODataConstants::ODATA_RELATED_NAMESPACE.$propertyName; 
                 $link->title = $propertyName;
                 $link->type = $type;
-                $link->url = $relativeUri . '/' . $propertyName;
+                $link->url = $relativeUri.'/'.$propertyName;
 
                 if ($navigationPropertyInfo->expanded) {
-                    $propertyRelativeUri = $relativeUri . '/' . $propertyName;
-                    $propertyAbsoluteUri = trim($absoluteUri, '/') . '/' . $propertyName;
+                    $propertyRelativeUri = $relativeUri.'/'.$propertyName;
+                    $propertyAbsoluteUri = trim($absoluteUri, '/').'/'.$propertyName;
                     $needPop = $this->pushSegmentForNavigationProperty($navigationPropertyInfo->resourceProperty);
                     $navigationPropertyKind = $navigationPropertyInfo->resourceProperty->getKind();
                     $this->assert(
@@ -645,7 +644,7 @@ 
      * @return void
      */
     private function _writePrimitiveValue(&$primitiveValue, 
-        ResourceProperty &$resourceProperty, ODataProperty &$odataProperty
+        ResourceProperty & $resourceProperty, ODataProperty & $odataProperty
     ) {
         if (is_object($primitiveValue)) {
             //TODO ERROR: The property 'PropertyName' 
@@ -684,8 +683,8 @@ 
      * @return void
      */
     private function _writeComplexValue(&$complexValue,
-        $propertyName, ResourceType &$resourceType, $relativeUri,
-        ODataPropertyContent &$odataPropertyContent
+        $propertyName, ResourceType & $resourceType, $relativeUri,
+        ODataPropertyContent & $odataPropertyContent
     ) {
         $odataProperty = new ODataProperty();
         $odataProperty->name = $propertyName;
@@ -724,8 +723,8 @@ 
      * @return void
      */
     private function _writeBagValue(&$BagValue,
-        $propertyName, ResourceType &$resourceType, $relativeUri,
-        ODataPropertyContent &$odataPropertyContent
+        $propertyName, ResourceType & $resourceType, $relativeUri,
+        ODataPropertyContent & $odataPropertyContent
     ) {
         $bagItemResourceTypeKind = $resourceType->getResourceTypeKind();
         $this->assert(
@@ -737,7 +736,7 @@ 
 
         $odataProperty = new ODataProperty();
         $odataProperty->name = $propertyName;
-        $odataProperty->typeName = 'Collection(' . $resourceType->getFullName() .')';
+        $odataProperty->typeName = 'Collection('.$resourceType->getFullName().')';
         if (is_null($BagValue) || (is_array($BagValue) && empty ($BagValue))) {
             $odataProperty->value = null;
         } else {
@@ -784,10 +783,10 @@ 
      */
     private function _writeMediaResourceMetadata(
         $entryObject,
-        ResourceType &$resourceType,
+        ResourceType & $resourceType,
         $title,
         $relativeUri,
-        ODataEntry &$odataEntry
+        ODataEntry & $odataEntry
     ) {
         if ($resourceType->isMediaLinkEntry()) {
             $odataEntry->isMediaLinkEntry = true;
@@ -833,7 +832,7 @@ 
      *                                            
      * @return void
      */
-    private function _primitiveToString(ResourceType &$primtiveResourceType,
+    private function _primitiveToString(ResourceType & $primtiveResourceType,
         $primitiveValue, &$stringValue
     ) {
         $type = $primtiveResourceType->getInstanceType();
@@ -868,8 +867,8 @@ 
      * @return void
      */
     private function _complexObjectToContent(&$complexValue,
-        $propertyName, ResourceType &$resourceType, $relativeUri,
-        ODataPropertyContent &$odataPropertyContent
+        $propertyName, ResourceType & $resourceType, $relativeUri,
+        ODataPropertyContent & $odataPropertyContent
     ) {
         $count = count($this->complexTypeInstanceCollection);
         for ($i = 0; $i < $count; $i++) {

src/POData/ObjectModel/ObjectModelSerializerBase.php

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 
 use POData\Common\ODataConstants;
 use POData\IService;
-use POData\Providers\ProvidersWrapper;
 use POData\Providers\Metadata\ResourceSetWrapper;
 use POData\Providers\Metadata\ResourceProperty;
 use POData\Providers\Metadata\ResourceTypeKind;

Spacing +19 added lines, -19 removed lines

@@ -96,7 +96,7 @@ 
         $this->service = $service;
         $this->request = $request;
         $this->absoluteServiceUri = $service->getHost()->getAbsoluteServiceUri()->getUrlAsString();
-        $this->absoluteServiceUriWithSlash = rtrim($this->absoluteServiceUri, '/') . '/';
+        $this->absoluteServiceUriWithSlash = rtrim($this->absoluteServiceUri, '/').'/';
         $this->_segmentNames = array();
         $this->_segmentResourceSetWrappers = array();
         $this->_segmentResultCounts = array();
@@ -124,7 +124,7 @@ 
     {
         $keyProperties = $resourceType->getKeyProperties();
         $this->assert(count($keyProperties) != 0, 'count($keyProperties) != 0');
-        $keyString = $containerName . '(';
+        $keyString = $containerName.'(';
         $comma = null;
         foreach ($keyProperties as $keyName => $resourceProperty) {
             $keyType = $resourceProperty->getInstanceType();            
@@ -136,7 +136,7 @@ 
             }
             
             $keyValue = $keyType->convertToOData($keyValue);
-            $keyString .= $comma . $keyName.'='.$keyValue;
+            $keyString .= $comma.$keyName.'='.$keyValue;
             $comma = ',';
         }
 
@@ -222,9 +222,9 @@ 
             );
             $value = $this->getPropertyValue($entryObject, $resourceType, $eTagProperty);
             if (is_null($value)) {
-                $eTag = $eTag . $comma. 'null';
+                $eTag = $eTag.$comma.'null';
             } else {
-                $eTag = $eTag . $comma . $type->convertToOData($value);
+                $eTag = $eTag.$comma.$type->convertToOData($value);
             }
 
             $comma = ',';
@@ -235,7 +235,7 @@ 
             // IType::converToOData will perform utf8 and url encode. But we don't
             // want this for eTag value.
             $eTag = urldecode(utf8_decode($eTag));
-            return ODataConstants::HTTP_WEAK_ETAG_PREFIX . rtrim($eTag, ',') . '"';
+            return ODataConstants::HTTP_WEAK_ETAG_PREFIX.rtrim($eTag, ',').'"';
         }
 
         return null;
@@ -270,7 +270,7 @@ 
      * @throws InvalidOperationException If this function invoked with non-navigation
      *                                   property instance.
      */
-    protected function pushSegmentForNavigationProperty(ResourceProperty &$resourceProperty)
+    protected function pushSegmentForNavigationProperty(ResourceProperty & $resourceProperty)
     {
         if ($resourceProperty->getTypeKind() == ResourceTypeKind::ENTITY) {
             $this->assert(!empty($this->_segmentNames), '!is_empty($this->_segmentNames');
@@ -383,7 +383,7 @@ 
      * 
      * @return bool true if the segment was push, false otherwise
      */
-    private function _pushSegment($segmentName, ResourceSetWrapper &$resourceSetWrapper)
+    private function _pushSegment($segmentName, ResourceSetWrapper & $resourceSetWrapper)
     {
         $rootProjectionNode = $this->request->getRootProjectionNode();
         // Even though there is no expand in the request URI, still we need to push
@@ -434,10 +434,10 @@ 
             $queryParameterString = $this->getNextPageLinkQueryParametersForExpandedResourceSet();
         }
 
-        $queryParameterString .= '$skiptoken=' . $skipToken;        
+        $queryParameterString .= '$skiptoken='.$skipToken;        
         $odalaLink = new ODataLink();
         $odalaLink->name = ODataConstants::ATOM_LINK_NEXT_ATTRIBUTE_STRING;
-        $odalaLink->url = rtrim($absoluteUri, '/') . '?' . $queryParameterString;
+        $odalaLink->url = rtrim($absoluteUri, '/').'?'.$queryParameterString;
         return $odalaLink;
     }
 
@@ -462,21 +462,21 @@ 
             $value = $this->service->getHost()->getQueryStringItem($queryOption);
             if (!is_null($value)) {
                 if (!is_null($queryParameterString)) {
-                    $queryParameterString = $queryParameterString . '&';
+                    $queryParameterString = $queryParameterString.'&';
                 }
 
-                $queryParameterString .= $queryOption . '=' . $value;
+                $queryParameterString .= $queryOption.'='.$value;
             }            
         }
 
         $topCountValue = $this->request->getTopOptionCount();
         if (!is_null($topCountValue)) {
-            $remainingCount  = $topCountValue - $this->request->getTopCount();
+            $remainingCount = $topCountValue - $this->request->getTopCount();
             if (!is_null($queryParameterString)) {
                 $queryParameterString .= '&';
             }
 
-            $queryParameterString .= ODataConstants::HTTPQUERY_STRING_TOP . '=' . $remainingCount;
+            $queryParameterString .= ODataConstants::HTTPQUERY_STRING_TOP.'='.$remainingCount;
         }
 
         if (!is_null($queryParameterString)) {
@@ -519,7 +519,7 @@ 
             }
 
             if (!is_null($selectionPaths)) {
-                $queryParameterString = '$select=' . $selectionPaths;
+                $queryParameterString = '$select='.$selectionPaths;
             }
 
             if (!is_null($expansionPaths)) {
@@ -527,7 +527,7 @@ 
                     $queryParameterString .= '&';
                 }
 
-                $queryParameterString = '$expand=' . $expansionPaths;
+                $queryParameterString = '$expand='.$expansionPaths;
             }
 
             if (!is_null($queryParameterString)) {
@@ -637,7 +637,7 @@ 
      */
     private function _buildSelectionAndExpansionPathsForNode(&$parentPathSegments, 
         &$selectionPaths, &$expansionPaths, 
-        ExpandedProjectionNode &$expandedProjectionNode, 
+        ExpandedProjectionNode & $expandedProjectionNode, 
         &$foundSelections, &$foundExpansions
     ) {
         $foundSelections = false;
@@ -668,7 +668,7 @@ 
                         $this->_appendSelectionOrExpandPath(
                             $selectionPaths, 
                             $parentPathSegments, 
-                            $childNode->getPropertyName() . '/*'
+                            $childNode->getPropertyName().'/*'
                         );
                     } else {
                         $expandedChildrenNeededToBeSelected[] = $childNode;
@@ -714,7 +714,7 @@ 
         }
 
         foreach ($parentPathSegments as $parentPathSegment) {
-            $path .= $parentPathSegment . '/';
+            $path .= $parentPathSegment.'/';
         }
 
         $path .= $segmentToAppend;

src/POData/OperationContext/ServiceHost.php

Unused Use Statements -1 removed lines

@@ -8,7 +8,6 @@
 use POData\Common\Url;
 use POData\Common\UrlFormatException;
 use POData\Common\ODataException;
-use POData\Common\InvalidOperationException;
 use POData\OperationContext\Web\WebOperationContext;
 use POData\OperationContext\IOperationContext;
 use POData\Common\Version;

Spacing +15 added lines, -15 removed lines

@@ -86,7 +86,7 @@ 
 	 */
 	public function __construct(IOperationContext $context = null)
     {
-        if(is_null($context)){
+        if (is_null($context)) {
 	        $this->_operationContext = new WebOperationContext();
         } else {
 	        $this->_operationContext = $context;
@@ -162,7 +162,7 @@ 
             $isAbsoluteServiceUri = (strpos($serviceUri, 'http://') === 0)
                 || (strpos($serviceUri, 'https://') === 0);
             try {
-                $this->_absoluteServiceUri = new Url($serviceUri, $isAbsoluteServiceUri );
+                $this->_absoluteServiceUri = new Url($serviceUri, $isAbsoluteServiceUri);
             } catch (UrlFormatException $exception) {
                 throw ODataException::createInternalServerError(Messages::hostMalFormedBaseUriInConfig());
             }
@@ -184,7 +184,7 @@ 
                 // Find index of segment in the request uri that end with .svc
                 // There will be always a .svc segment in the request uri otherwise
                 // uri redirection will not happen.
-                for (; $i >=0; $i--) {
+                for (; $i >= 0; $i--) {
                     $endsWithSvc = (substr_compare($requestUriSegments[$i], '.svc', -strlen('.svc'), strlen('.svc')) === 0);
                     if ($endsWithSvc) {
                         break;
@@ -222,7 +222,7 @@ 
                     . $this->_absoluteRequestUri->getPort();
 
                 for ($l = 0; $l <= $k; $l++) {
-                    $serviceUri .= '/' . $requestUriSegments[$l];
+                    $serviceUri .= '/'.$requestUriSegments[$l];
                 }
                 
                 $this->_absoluteServiceUri = new Url($serviceUri);
@@ -552,18 +552,18 @@ 
      */
     public function setResponseStatusCode($value)
     {
-        $floor = floor($value / 100);
+        $floor = floor($value/100);
         if ($floor >= 1 && $floor <= 5) {
             $statusDescription = HttpStatus::getStatusDescription($value);
             if (!is_null($statusDescription)) {
-                $statusDescription = ' ' . $statusDescription;
+                $statusDescription = ' '.$statusDescription;
             }
 
             $this->_operationContext
-                ->outgoingResponse()->setStatusCode($value . $statusDescription);
+                ->outgoingResponse()->setStatusCode($value.$statusDescription);
         } else {
             throw ODataException::createInternalServerError(
-                'Invalid Status Code' . $value
+                'Invalid Status Code'.$value
             );
         }
     }
@@ -635,37 +635,37 @@ 
 	 * @param string $format the short $format form
 	 * @return string the full mime type corresponding to the short format form for the given version
 	 */
-	public static function translateFormatToMime(Version $responseVersion, $format){
+	public static function translateFormatToMime(Version $responseVersion, $format) {
         //TODO: should the version switches be off of the requestVersion, not the response version? see #91
 
-        switch($format) {
+        switch ($format) {
 
 	        case ODataConstants::FORMAT_XML:
 		        $format = MimeTypes::MIME_APPLICATION_XML;
 		        break;
 
             case ODataConstants::FORMAT_ATOM:
-	            $format = MimeTypes::MIME_APPLICATION_ATOM ;
+	            $format = MimeTypes::MIME_APPLICATION_ATOM;
 		        break;
 
             case ODataConstants::FORMAT_VERBOSE_JSON:
-                if($responseVersion == Version::v3()){
+                if ($responseVersion == Version::v3()) {
 	                //only translatable in 3.0 systems
 	                $format = MimeTypes::MIME_APPLICATION_JSON_VERBOSE;
                 }
                 break;
 
             case ODataConstants::FORMAT_JSON:
-                if($responseVersion == Version::v3()){
+                if ($responseVersion == Version::v3()) {
                     $format = MimeTypes::MIME_APPLICATION_JSON_MINIMAL_META;
-                } else{
+                } else {
 	                $format = MimeTypes::MIME_APPLICATION_JSON;
                 }
 		        break;
 
         }
 
-	    return $format . ';q=1.0';
+	    return $format.';q=1.0';
     }